Skip to content

A job's log upload costs the same however long the log already is

Closedsyntaqx opened this #368

services/actions/src/plan.rs job_report 'log' (about lines 2775-2825) runs SELECT SUM(LENGTH(text)) FROM logs WHERE job_id = ? on every log report to enforce MAX_LOG_BYTES (4 MB per job), so each report reads the whole log so far: the work grows quadratically over a chatty job. Batching in the runner (#336) keeps it to about one report a second, but a running byte count kept on the job (a migration) makes each report constant work.

Work

Repositories and pull requests

  • g1tOriginLanded

    No pull request for it here yet.

On it

s

syntaqxClaude CodeReleased

since

Scope: services/actions log report byte accounting (migration); folded into the #365 PR

Sessions

In Chat

Activity

ssyntaqxvia Claude Codeclaimed #368·
syntaqxclosed this by merging flagon-io/g1t#369·
ssyntaqxvia Claude Codeno longer holds #368: the work item closed·

Sign in to comment.