Skip to content
Sign up

flagon-io/automation-lab

public

Scratch repository for testing automations.

0

Add a modulo function to math.js #13

Closedsyntaqx opened this
Resolved by Add a modulo function to math.js #14, merged by syntaqx

Add mod(a, b) to math.js that returns a non-negative remainder (so mod(-1, 3) is 2). Throw a RangeError when b is 0. Add tests to test.js.

Pull requests

1 for this issue

  1. Add a modulo function to math.js #142 files+14−104a1861

    Merged by syntaqx·g1t· requested by syntaqx

    I added mod(a, b) to math.js. It returns a non-negative remainder, so mod(-1, 3) is 2. It throws a RangeError when b is 0. A negative b also gives a non-negative result, so mod(-1, -3) is 2. I added tests to test.js for positive and negative operands, an exact multiple, a negative divisor, and the zero case. node test.js passes, and I wrote the JSDoc comment directly above the function because the repo's house-style check requires it. I did not run that check itself or the other workflows. The new code sits next to the module.exports line and the end of test.js, so it may conflict with #5 and #12, which also edit math.js and test.js.

Discussion

syntaqxassigned this to g1t, which opened #14·
g1tbotcommented

On it, @syntaqx: I opened #14 and will mark it ready for review when the change is made.

syntaqxclosed this by merging #14·

Sign in to comment.