A pull request that is ready but waiting on you says so first on Home and Code's overview, with a link to merge an agent's changes automatically when ready
3 files+9−30/3 viewed
| 195 | 195 | at most twice, or as often as the repository's **Revisions before asking | |
| 196 | 196 | you** allows. | |
| 197 | 197 | 4. **Ready to merge.** The required checks passed and it is approved. | |
| 198 | − | Merging is yours, unless the repository says otherwise (below). | |
| 198 | + | Merging is yours, unless the repository says otherwise (below). Until | |
| 199 | + | you merge it, Home and Code's overview list it as waiting for you to | |
| 200 | + | merge it, with a link to **Merge automatically when ready** in the | |
| 201 | + | repository's branch settings for a pull request g1t made. | |
| 199 | 202 | ||
| 200 | 203 | Agents are told to run the same tests and linters the workflows run before | |
| 201 | 204 | they finish, so most failures are caught in the sandbox. What "done" means |
| 393 | 393 | key, | |
| 394 | 394 | kind: "ready", | |
| 395 | 395 | title: pull.title, | |
| 396 | − | detail: lowConfidence ? confidenceAsk(lowConfidence) : "Its required checks passed and it was approved. It lands when you merge it.", | |
| 396 | + | // The ask first: a list cuts the sentence short, and "it lands" alone reads as stuck. | |
| 397 | + | detail: lowConfidence ? confidenceAsk(lowConfidence) : "Waiting for you to merge it. It was approved and its required checks passed.", | |
| 397 | 398 | to, | |
| 398 | 399 | action: "Merge", | |
| 399 | 400 | at: Date.parse(pull.updatedAt), | |
| ⋯ | |||
| 406 | 407 | fields: { action: "merge" }, | |
| 407 | 408 | done: "Merging", | |
| 408 | 409 | }), | |
| 410 | + | // This repository leaves landing an agent's change to a person; say where that is changed. | |
| 411 | + | link: isAgent(pull.agent) ? { label: "Merge automatically when ready", to: `/${repo.namespace}/${repo.name}/settings/branches` } : null, | |
| 409 | 412 | }); | |
| 410 | 413 | } else if (!lifecycle && pull.status === "open" && pull.checkStatus === "failed") { | |
| 411 | 414 | // Taken out of the merge queue: its change failed combined with what was ahead. | |
| 176 | 176 | <GitPullRequest size={16} className="mt-0.5 shrink-0 text-warn" /> | |
| 177 | 177 | <span className="min-w-0 grow"> | |
| 178 | 178 | <span className="block truncate text-sm font-medium text-fg">{row.title}</span> | |
| 179 | − | <span className="block truncate text-xs text-muted"> | |
| 179 | + | <span className="line-clamp-2 text-xs text-muted"> | |
| 180 | 180 | {row.repo ? `${row.repo.name}${row.ref ? ` ${row.ref}` : ""} · ` : ""} | |
| 181 | 181 | {row.ask} | |
| 182 | 182 | </span> |