Skip to content

Commit

The Branches page hydrates cleanly. Each row's Updated column had the commit's avatars, which link to their people, inside the link to the commit; the browser splits a link inside a link apart, so the page's HTML never matched what React drew and it threw it away and drew again (React error 418). The avatars now sit beside the commit's link, and the time alone links to the commit.

syntaqxcommitted Parente2b3c4dBrowse files
1 file+11−60/1 viewed
+11−6
144144 function Updated({ row, base }: { row: BranchRowData; base: string }) {
145145 if (!row.commit) return <span className="text-faint">—</span>;
146146 return (
147− <Hint label={row.commit.message}>
148− <Link to={`${base}/commit/${row.commit.hash}`} className="inline-flex items-center gap-1.5 whitespace-nowrap text-muted hover:text-fg">
149− <CommitAvatars commit={row.commit} size={18} max={2} />
150− <TimeAgo at={row.commit.at} />
151− </Link>
152− </Hint>
147+ // The avatars link to their people, so they sit beside the commit's
148+ // link rather than in it: a link inside a link is split apart by the
149+ // browser, and the page then fails to hydrate.
150+ <span className="inline-flex items-center gap-1.5 whitespace-nowrap">
151+ <CommitAvatars commit={row.commit} size={18} max={2} />
152+ <Hint label={row.commit.message}>
153+ <Link to={`${base}/commit/${row.commit.hash}`} className="text-muted hover:text-fg">
154+ <TimeAgo at={row.commit.at} />
155+ </Link>
156+ </Hint>
157+ </span>
153158 );
154159 }
155160