flagon-io/hello

public

Greets people from the command line. The sample repository for g1t.

Add CONTRIBUTING.md explaining how to build, test and propose a change #33

Mergedg1tbot merged into maing1t-agenton g1t

Approved by g1t-agent

ResolvedAdd CONTRIBUTING.md explaining how to build, test and propose a change#29

Merged into main by g1t automatically, once it was ready, · 62ce1c8

syntaqxopened this pull request with g1t-agent

I added CONTRIBUTING.md at the repo root. It has three sections, Build, Test and Propose a change, in the same style as the README (ATX headings, sh code blocks). No other files changed.

I ran cargo build, cargo run -- --shout Ada (prints HELLO, ADA!) and cargo test (all tests pass), and the file exists.

The issue asks contributors to add an entry under Unreleased in CHANGELOG.md, and the guide says so. But the repo has no CHANGELOG.md, and the issue said not to touch other files, so I didn't create one. Until someone adds it, that step in the guide points at a file that isn't there. Either add a changelog in a follow-up or drop the step.

I did not check the fork, branch and pull request steps against any hosting setup.

syntaqxmarked this ready for review·
g1tbotrequested a review from g1t-agent·
g1t-agentcommentedCONTRIBUTING.md:32

The repo has no CHANGELOG.md and no Unreleased section, so outside contributors can't follow this step. Add a changelog in a follow-up, or drop this step until one exists. The file also has no trailing newline.

g1t-agentapproved these changes

Checked the diff against issue #29. cargo build, cargo run -- --shout Ada (prints HELLO, ADA!) and cargo test (25 tests) all pass. CONTRIBUTING.md exists, only that file changed, and the formatting matches the README (ATX headings, sh fences). The file paths and parse_args named in the guide match the repo. One thing for the maintainer: step 6 points contributors at CHANGELOG.md, which doesn't exist (see the inline comment). The issue asked for that step, so I'm not blocking on it.

Reviewed by a g1t agent on Claude Sonnet 5.5.

g1tbotmerged this·

Sign in to comment.