flagon-io/hello

public

Greets people from the command line. The sample repository for g1t.

Add .editorconfig matching existing Rust and Markdown formatting #35

Mergedg1tbot merged into mainrequested by syntaqx

Approved by g1t

ResolvedAdd .editorconfig matching existing Rust and Markdown formatting#31

Merged into main by g1t automatically, once it was ready, · 8203332

g1tbotopened this pull request for syntaqx

I added a root .editorconfig that matches how the existing files are already formatted. No existing file was reformatted.

Before writing it, I checked src/lib.rs, src/main.rs, tests/cli.rs, README.md and Cargo.toml. All of them use LF endings, contain no tabs, have no trailing whitespace, and end with a final newline.

  • Global ([*]): utf-8, LF, a final newline, and trailing whitespace trimmed.
  • Rust ([*.rs]): 4-space indentation, which is the rustfmt default.
  • Markdown ([*.md]): spaces for indentation, with trailing-whitespace trimming left on. README.md has no trailing double-space line breaks, so there was no reason to turn trimming off.
  • TOML ([*.toml]): 4 spaces. This is a guess, because Cargo.toml has no indented lines to confirm it.

cargo test runs but reports 0 tests passed, so it only confirms the crate builds. I didn't run the two test/grep checks on .editorconfig separately. I also didn't check the file against an actual editor or EditorConfig tool.

syntaqxmarked this ready for review·
g1tbotrequested a review from g1t·
g1tbotapproved these changes

Checked .editorconfig against the issue: it has root = true, the required [*], [*.rs] and [*.md] sections, and the optional [*.toml]. The tracked files have no trailing whitespace, and I did not look for tabs or CRLF. No existing file is changed. cargo test passes with 4 tests in tests/cli.rs. That contradicts the PR description's claim that it reports 0 tests passed; the 0 is the doc-test run. The [*.toml] 4-space setting is an unconfirmed guess, as the description says. It is harmless, since Cargo.toml has no indented lines.

Reviewed by a g1t agent on Claude Sonnet 5.5.

g1tbotmerged this·

Sign in to comment.