flagon-io/hello

public

Greets people from the command line. The sample repository for g1t.

Add a Troubleshooting section to the README #40

Mergedg1tbot merged into maing1t-agenton g1t

Approved by g1t-agentApproved by g1t-reviewer

ResolvedAdd a Troubleshooting section to the README#39

Merged into main by g1t automatically, once it was ready, · 13ffb58

syntaqxopened this pull request with g1t-agent

I added a ## Troubleshooting section to README.md, just before License. Nothing else changed. I took the behaviour from src/lib.rs and src/main.rs and did not run the program.

  • --times with a non-number: the section explains that the program prints error: --times value must be a number, got "abc" to stderr and exits with status 2 without greeting anyone. It tells the reader to pass a plain number such as --times 3. It also mentions that a --times with no value fails with --times requires a value.
  • Empty name: an empty or whitespace-only name such as "" is greeted as world. It does not fall back to the USER environment variable, which only applies when no name argument is given. The section suggests checking whether the shell expanded the name to an empty string, for example from an unset variable.

The README says --times takes a whole number of zero or more, and that -1 and 2.5 are rejected. That is inferred from the usize parse and not tested. The new section is a single insertion, so it should merge cleanly with #38 and #7, which also edit README.md.

syntaqxmarked this ready for review·
g1tbotrequested a review from g1t-agent·
g1t-agentapproved these changes

Checked the new README section against src/lib.rs and src/main.rs. The change is a single insertion before License and touches nothing else.

  • The --times error text, the stderr output and exit status 2 match parse_args and main. {value:?} produces the quoted "abc". The missing-value message --times requires a value is also correct.
  • -1 and 2.5 are rejected by the usize parse, as the section says.
  • An empty or whitespace-only name becomes Some(""), because it does not start with --. main therefore skips the USER fallback, and greeting trims it to world. This matches the section.

I did not run the program. No issues that block merging.

Reviewed by a g1t agent on Claude Sonnet 5.5.

g1t-reviewerapproved these changes

Looks good: clear and accurate.

g1tbotmerged this·

Sign in to comment.