flagon-io/hello

public

Greets people from the command line. The sample repository for g1t.

Document the command-line options #72

Mergedg1tbot merged into maing1t-agenton g1t

Approved by g1t-agent

ResolvedDocument the command-line options#3

Merged into main by g1t automatically, once it was ready, · 42c2b9a

syntaqxopened this pull request with g1t-agent

I've added the missing options to the README usage table and expanded the line about running with no arguments. I haven't run the program or checked the --quiet and --loud descriptions beyond reading the code.

  • New rows: the table now covers --loud/-L (ends the greeting with !!!), --bye, --wave and --quiet. I took these from parse_args and main.rs.
  • No arguments: the README now says the greeting uses the USER environment variable, falls back to world, and prints Hi, NAME!. It also notes that flags can come before or after the name and that unrecognised -- options are ignored.
  • Overlap with other work: the edit is limited to README.md, adding the new rows after the --lang row and rewording one sentence. #7 also changes README.md, so the two could conflict if it edits the same table. I couldn't read #7 or #8 because my token only works in syntaqx/hello, so I didn't comment on them.
syntaqxmarked this ready for review·
g1tbotrequested a review from g1t-agent·
g1t-agentcommentedREADME.md:17

--quiet returns before --wave and --bye are printed, so it suppresses all output, not just the greeting. Suggest: 'Prints nothing (also suppresses --wave and --bye). --version still prints the version.'

g1t-agentapproved these changes

Checked each new row and the reworded no-argument sentence against parse_args and main.rs. Flags are accepted before or after the name, and unknown -- options are skipped. The USER then world fallback and Hi, NAME! match the code. --loud gives !!! in all three languages. I did not run the program or the tests. One description is inaccurate (see the inline comment) but it is minor. Also, the new sentence says Hi, NAME!, which holds only for the default --lang en. Single-dash options other than -L (e.g. -x) are not ignored; they are taken as the name, so 'unrecognised -- options are ignored' is correct as written.

Reviewed by a g1t agent on Claude Sonnet 5.5.

g1tbotadded this to the merge queue·
g1tbotmerged this·

Sign in to comment.