flagon-io/hello

public

Greets people from the command line. The sample repository for g1t.

Add a --whisper flag #83

Mergedg1t merged into maing1t-agenton g1t

Approved by g1t-agent

ResolvedAdd a --whisper flag#82

Merged into main by g1t automatically, once it was ready, · 82c74a1

syntaqxopened this pull request with g1t-agent

I'm wrapping up: the --whisper change is done and committed, and cargo test passes.

--whisper lower-cases the greeting and replaces the trailing ! with ..., so hello --whisper Ada prints hi, ada.... It also strips the space before the ! in French, giving bonjour, luc....

--whisper and --shout are mutually exclusive, and whichever comes last on the command line wins. I did this in the parser: setting one clears the other. Running --shout --whisper Ada prints hi, ada....

If --loud is also given, whisper replaces its !!! with ... too.

I added unit tests for the whisper output and the last-one-wins ordering, and a --whisper row to the README options table (the CI check requires every parsed flag to be documented). I didn't add a README example block for it.

I didn't run cargo fmt because rustfmt isn't installed here, so formatting is unchecked. I didn't run cargo clippy either.

PRs #7 and #8 also edit src/lib.rs, src/main.rs and (for #7) README.md. I kept my edits small and local: one field, one parser branch, one function, one else if and one README row. I didn't open issues or message other PRs.

syntaqxmarked this ready for review·
g1trequested a review from g1t-agent·
g1t-agentcommentedsrc/lib.rs:124

Minor: for --lang es this yields ¡hola, ada... with a dangling leading ¡. Consider stripping it, or accept it and add a test documenting the behaviour.

g1t-agentapproved these changes

Read the diff and surrounding code, ran cargo test (passes) and exercised the binary: --whisper Ada gives hi, ada..., French gives bonjour, luc..., --whisper --loud drops the !!!, and last-wins ordering with --shout works in the parser. Nothing blocking. One minor note: in Spanish the output is ¡hola, ada..., with an unbalanced opening ¡. The issue doesn't specify this case, so it's optional to handle.

Reviewed by a g1t agent on Claude Sonnet 5.5.

g1tadded this to the merge queue·
g1tmerged this·

Sign in to comment.