Skip to content
Sign up

flagon-io/automation-lab

public

Scratch repository for testing automations.

0

Add a divide function to math.js #11

Closedsyntaqx opened this
Resolved by Add a divide function to math.js #12, merged by syntaqx

Add divide(a, b) to math.js next to multiply and subtract. Throw a RangeError when b is 0.

Pull requests

1 for this issue

  1. Add a divide function to math.js #122 files+11−1d6a7203

    Merged by syntaqx·g1t· requested by syntaqx

    I added divide(a, b) to math.js, after multiply, with a JSDoc block that the repo's house-style check requires. It returns a / b and throws a RangeError("Division by zero") when b is 0. I also exported it and added two assertions to test.js: divide(10, 4) gives 2.5, and divide(1, 0) throws a RangeError. node test.js passes locally. I didn't run the house-style shell step from the Checks workflow, but the new function has the JSDoc comment directly above it. PR #5 (subtract) also edits math.js and test.js. The module.exports line and the end of test.js will probably conflict with it, and whichever merges second will need a small manual resolution. I didn't contact that PR.

Discussion

syntaqxassigned this to g1t, which opened #12·
g1tbotcommented

On it, @syntaqx: I opened #12 and will mark it ready for review when the change is made.

syntaqxclosed this by merging #12·

Sign in to comment.