| 1 | //! The inbox, kept beside the event log. See `g1t_contracts::inbox`. |
| 2 | //! |
| 3 | //! As each batch arrives from the bus, the events that tell someone are |
| 4 | //! read against what they name (the work service's `inbox_subject`), who |
| 5 | //! subscribes to it and who watches its repository (subscriptions.rs), and |
| 6 | //! each person told gets their thread about it brought to the top, unread, |
| 7 | //! with a line added to its history. Who is told is worked out in |
| 8 | //! [`notices`], from the event, its subject and that audience alone: |
| 9 | //! |
| 10 | //! | Event | Who | Reason | Severity | |
| 11 | //! | --- | --- | --- | --- | |
| 12 | //! | `pull.stalled` | the pull request's owner, and its work item's owner and assignees | agent | warning | |
| 13 | //! | `pull.review_requested` | the reviewers asked, and the people each team asked tells | review_requested | warning | |
| 14 | //! | `work_item.assigned`, `pull.assigned` | the people newly assigned | assign | info | |
| 15 | //! | `checks.completed`, failed or errored | the pull request's owner | ci_activity | error | |
| 16 | //! | `workflow.completed`, failed | the pull request's owner, or whoever pushed | ci_activity | error | |
| 17 | //! | `deployment.failed` | the pull request's owner, or whoever pushed; watchers | ci_activity | error | |
| 18 | //! | `deployment.succeeded` | watchers; it settles the failure before it | subscribed | success | |
| 19 | //! | `pull.auto_merge_disabled` | whoever turned it on, unless g1t handed it to the merge queue | state_change | warning | |
| 20 | //! | `pull.merged`, `pull.closed`, `work_item.closed`, `work_item.reopened` | everyone subscribed | state_change | success for a merge, else info | |
| 21 | //! | `comment.created` | everyone mentioned, the people of teams mentioned, then everyone subscribed | mention, team_mention, or why they are subscribed | info (success for an approval) | |
| 22 | //! | `comment.created` by a workspace's agent | the same, shown as "Margo (agent)"; a review also tells the owner, "(advisory)" | the same, or author | the same | |
| 23 | //! | `commit_comment.created` | everyone mentioned, the people of teams mentioned, and the commit's author when their address is a g1t account's; one thread per commit | mention, team_mention, author | info | |
| 24 | //! | `work_item.opened`, `pull.opened` | whoever was assigned, asked to review or mentioned in its description (people and teams); watchers | assign, review_requested, mention, team_mention, subscribed | info | |
| 25 | //! | `secret_scanning_alert.summary`, `code_scanning_alert.summary`, `vulnerability_alert.summary` | the workspace's owners and security managers, whoever pushed a refused push, and watchers who chose security and may see findings; one thread per repository and alert type | security_alert | error for critical or high (told at once), info for the rest (a digest, unless the person chose at once) | |
| 26 | //! | `security_advisory.reported` | the workspace's owners and security managers | security_alert | warning | |
| 27 | //! | `secret_scanning.bypass_requested`, `.bypass_reviewed` | the reviewers named; the requester | security_alert | warning; info | |
| 28 | //! |
| 29 | //! What leaves nothing for a person to do settles their item about it |
| 30 | //! (marks it done): see "Settling" below for which event settles what. |
| 31 | //! A merge or a close reaches each thread's history but settles it at |
| 32 | //! once, so it is neither left unread nor pushed. |
| 33 | //! |
| 34 | //! Watchers of a repository at `all` (or `custom`, for the kinds they |
| 35 | //! chose) hear of every work item and pull request opened, commented on, |
| 36 | //! closed, reopened or merged, and of deployments. Anyone who ignores the |
| 37 | //! thread or the repository hears of nothing on it; anyone who |
| 38 | //! unsubscribed hears only of what is asked of them. |
| 39 | //! |
| 40 | //! A work item belongs to a workspace and is one thread (`item:<id>`), |
| 41 | //! however many repositories it is linked to. Watchers of each of them |
| 42 | //! hear of it; whoever ignores its origin hears of nothing on it. Its |
| 43 | //! items are kept with its workspace and its origin, if it has one, and |
| 44 | //! are shown to the workspace's members and to whoever can read the |
| 45 | //! origin. Those who hear of it only by watching another repository it is |
| 46 | //! linked to are not pushed it live: whether they may see it is known only |
| 47 | //! when their inbox is read. |
| 48 | //! |
| 49 | //! Nobody is told of what they did themselves, though an outcome they set |
| 50 | //! off (checks, a workflow, a deployment, g1t's work) is theirs to hear of. |
| 51 | //! g1t is never told. A failure here is logged and the batch goes on: the |
| 52 | //! bus never waits on the inbox, so an item can be missed, but nothing else |
| 53 | //! is held up. |
| 54 | |
| 55 | use std::collections::{HashMap, HashSet}; |
| 56 | |
| 57 | use g1t_contracts::credentials::Principal; |
| 58 | use g1t_contracts::events::{Event, WorkspaceRenamed}; |
| 59 | use g1t_contracts::identity::{AGENT_ID, UsernamesArgs}; |
| 60 | use g1t_contracts::inbox::*; |
| 61 | use g1t_contracts::repos::{PathByIdArgs, ReadableArgs, Repo, RepoPath}; |
| 62 | use g1t_contracts::security::SeverityCounts; |
| 63 | use g1t_contracts::security_suite::{AlertType, SecuritySummary}; |
| 64 | use g1t_contracts::time::rfc3339; |
| 65 | use g1t_contracts::{new_id, system}; |
| 66 | use g1t_kit::now_ms; |
| 67 | use serde::Deserialize; |
| 68 | use worker::wasm_bindgen::JsValue; |
| 69 | use worker::{D1Database, D1PreparedStatement, Fetcher, Result}; |
| 70 | |
| 71 | use crate::subscriptions::{self, Audience}; |
| 72 | |
| 73 | /// Items marked done are kept this long, then removed. |
| 74 | pub const DONE_DAYS: u32 = 30; |
| 75 | /// No item is kept longer than this, unless it was saved. |
| 76 | pub const MAX_DAYS: u32 = 180; |
| 77 | /// Unread warnings shown ahead of everything else on the first page. |
| 78 | const MAX_RANKED: u32 = 20; |
| 79 | const MAX_TITLE: usize = 200; |
| 80 | const MAX_BODY: usize = 300; |
| 81 | |
| 82 | /// What the inbox asks about an event before deciding who is told. |
| 83 | #[derive(Debug, Default, PartialEq, Eq)] |
| 84 | pub struct Wanted { |
| 85 | /// The repository; for a work item, its origin, if it has one. |
| 86 | pub repo_id: Option<String>, |
| 87 | /// The work item or pull request, when the event names one. |
| 88 | pub number: Option<u32>, |
| 89 | pub comment_id: Option<String>, |
| 90 | /// When the event is about a work item. |
| 91 | pub item: Option<WantedItem>, |
| 92 | } |
| 93 | |
| 94 | /// The work item an event is about. |
| 95 | #[derive(Debug, Default, PartialEq, Eq)] |
| 96 | pub struct WantedItem { |
| 97 | pub id: String, |
| 98 | /// The workspace's slug. |
| 99 | pub workspace: String, |
| 100 | /// Every repository it is linked to, its origin first. |
| 101 | pub repo_ids: Vec<String>, |
| 102 | } |
| 103 | |
| 104 | impl Wanted { |
| 105 | /// The repository's id, or empty for a work item without an origin. |
| 106 | fn repo(&self) -> &str { |
| 107 | self.repo_id.as_deref().unwrap_or_default() |
| 108 | } |
| 109 | } |
| 110 | |
| 111 | /// One person to tell, and what. |
| 112 | #[derive(Debug, PartialEq, Eq)] |
| 113 | pub struct Notice { |
| 114 | pub username: String, |
| 115 | pub reason: Reason, |
| 116 | pub severity: Severity, |
| 117 | pub title: String, |
| 118 | pub body: String, |
| 119 | } |
| 120 | |
| 121 | /// Who did it, as far as is known. |
| 122 | #[derive(Debug, Default)] |
| 123 | pub struct Actor { |
| 124 | pub id: Option<String>, |
| 125 | pub username: Option<String>, |
| 126 | } |
| 127 | |
| 128 | impl Actor { |
| 129 | fn is(&self, person: &Principal) -> bool { |
| 130 | self.id.as_deref().is_some_and(|id| id == person.id) || self.is_named(&person.username) |
| 131 | } |
| 132 | |
| 133 | fn is_named(&self, username: &str) -> bool { |
| 134 | self.username.as_deref().is_some_and(|name| name.eq_ignore_ascii_case(username)) |
| 135 | } |
| 136 | |
| 137 | /// A person's name, for a title: never g1t's ids. |
| 138 | fn name(&self) -> Option<&str> { |
| 139 | self.username.as_deref().filter(|name| !is_g1t(name)) |
| 140 | } |
| 141 | } |
| 142 | |
| 143 | pub(crate) fn is_g1t(username: &str) -> bool { |
| 144 | username.eq_ignore_ascii_case(system::USERNAME) || username.eq_ignore_ascii_case("g1t-agent") |
| 145 | } |
| 146 | |
| 147 | pub(crate) fn is_g1t_id(id: &str) -> bool { |
| 148 | system::is_system_id(id) || id == AGENT_ID |
| 149 | } |
| 150 | |
| 151 | /// Events that end what an agent was waiting on a person for: it picked |
| 152 | /// back up, its head moved, a merge was asked for, or it is over. |
| 153 | const RESUMES: [&str; 5] = ["pull.resumed", "pull.updated", "pull.merge_requested", "pull.merged", "pull.closed"]; |
| 154 | |
| 155 | /// The work item an event's data names (`itemId`, with its workspace and |
| 156 | /// linked repositories), if any. |
| 157 | fn item_of(data: &serde_json::Value) -> Option<WantedItem> { |
| 158 | let id = data["itemId"].as_str().filter(|id| !id.is_empty())?; |
| 159 | Some(WantedItem { |
| 160 | id: id.to_owned(), |
| 161 | workspace: data["workspace"].as_str().unwrap_or_default().to_lowercase(), |
| 162 | repo_ids: names(data, "repoIds"), |
| 163 | }) |
| 164 | } |
| 165 | |
| 166 | /// The work item events the inbox tells people of. |
| 167 | const ITEM_TOLD: [&str; 4] = ["work_item.opened", "work_item.closed", "work_item.reopened", "work_item.assigned"]; |
| 168 | |
| 169 | /// The work item or pull request an event names, and what to read for it. |
| 170 | /// None for events the inbox does not tell anyone of. |
| 171 | pub fn wants(event: &Event) -> Option<Wanted> { |
| 172 | let data = &event.data; |
| 173 | let text = |key: &str| data[key].as_str().filter(|value| !value.is_empty()).map(str::to_owned); |
| 174 | let number = |key: &str| data[key].as_u64().and_then(|n| u32::try_from(n).ok()); |
| 175 | let repo_id = text("repoId").or_else(|| event.repo_id.clone()); |
| 176 | // A work item's events, and comments on one: it may have no origin. |
| 177 | let on_item = event.kind == "comment.created" && data["itemId"].is_string(); |
| 178 | if ITEM_TOLD.contains(&event.kind.as_str()) || on_item { |
| 179 | return Some(Wanted { |
| 180 | repo_id, |
| 181 | number: Some(number("number")?), |
| 182 | comment_id: if on_item { Some(text("commentId")?) } else { None }, |
| 183 | item: Some(item_of(data)?), |
| 184 | }); |
| 185 | } |
| 186 | let repo_id = repo_id?; |
| 187 | let on = |number: Option<u32>, comment_id: Option<String>| { |
| 188 | Some(Wanted { |
| 189 | repo_id: Some(repo_id.clone()), |
| 190 | number, |
| 191 | comment_id, |
| 192 | item: None, |
| 193 | }) |
| 194 | }; |
| 195 | match event.kind.as_str() { |
| 196 | "pull.stalled" | "pull.merged" | "pull.closed" | "pull.opened" | "pull.auto_merge_disabled" |
| 197 | | "pull.review_requested" | "pull.assigned" => on(Some(number("number")?), None), |
| 198 | "checks.completed" => match data["status"].as_str() { |
| 199 | Some("failed" | "errored") => on(Some(number("number")?), None), |
| 200 | _ => None, |
| 201 | }, |
| 202 | "workflow.completed" => match data["conclusion"].as_str() { |
| 203 | Some("failure") => on(number("pull"), None), |
| 204 | _ => None, |
| 205 | }, |
| 206 | "deployment.failed" | "deployment.succeeded" => on(number("number"), None), |
| 207 | // A workflow run's jobs wait for their environment's reviewers. |
| 208 | "deployment.review_requested" => on(None, None), |
| 209 | "comment.created" => on(Some(number("number")?), Some(text("commentId")?)), |
| 210 | // A commit is a thread of its own, its link the commit's page. |
| 211 | "commit_comment.created" => on(None, None), |
| 212 | // Security alerts are threads of their own, not of a work item. |
| 213 | kind if SECURITY_EVENTS.contains(&kind) => on(None, None), |
| 214 | _ => None, |
| 215 | } |
| 216 | } |
| 217 | |
| 218 | /// The security service's events the inbox tells people of: each scan's |
| 219 | /// summary of what it opened and fixed (one thread per repository and |
| 220 | /// alert type, brought up to date by the next scan; never one item per |
| 221 | /// alert), push protection bypasses asked for and decided, vulnerability |
| 222 | /// reports, and advisories published. The per-alert `.created`, `.fixed` |
| 223 | /// and `.dismissed` events are for webhooks. |
| 224 | pub const SECURITY_EVENTS: [&str; 7] = [ |
| 225 | "secret_scanning_alert.summary", |
| 226 | "code_scanning_alert.summary", |
| 227 | "vulnerability_alert.summary", |
| 228 | "secret_scanning.bypass_requested", |
| 229 | "secret_scanning.bypass_reviewed", |
| 230 | "security_advisory.reported", |
| 231 | "security_advisory.published", |
| 232 | ]; |
| 233 | |
| 234 | /// Where an event's items go: which thread, what it is, and where it is. |
| 235 | #[derive(Clone, Debug, PartialEq, Eq)] |
| 236 | pub struct Thread { |
| 237 | pub key: String, |
| 238 | pub kind: Option<SubjectKind>, |
| 239 | pub number: Option<u32>, |
| 240 | pub run_id: Option<String>, |
| 241 | /// A path, for a subject with a page of its own. |
| 242 | pub link: Option<String>, |
| 243 | } |
| 244 | |
| 245 | /// The thread key of a pull request. |
| 246 | pub fn numbered_thread(repo_id: &str, number: u32) -> String { |
| 247 | format!("{repo_id}#{number}") |
| 248 | } |
| 249 | |
| 250 | /// What a work item's thread key starts with: `item:<item_id>`. |
| 251 | pub const ITEM_THREAD: &str = "item:"; |
| 252 | |
| 253 | /// The thread key of a work item. |
| 254 | pub fn item_thread(item_id: &str) -> String { |
| 255 | format!("{ITEM_THREAD}{item_id}") |
| 256 | } |
| 257 | |
| 258 | /// Whether people subscribe to a thread: a work item's or a pull request's. |
| 259 | pub fn subscribable(thread: &str) -> bool { |
| 260 | thread.starts_with(ITEM_THREAD) || thread.contains('#') |
| 261 | } |
| 262 | |
| 263 | /// The thread of a workflow on a branch: `<repo_id>/run/<workflow>@<branch>`. |
| 264 | pub fn run_thread(repo_id: &str, data: &serde_json::Value) -> String { |
| 265 | let text = |key: &str| data[key].as_str().filter(|value| !value.is_empty()).map(str::to_owned); |
| 266 | let branch = text("ref").unwrap_or_default(); |
| 267 | let branch = branch.strip_prefix("refs/heads/").unwrap_or(&branch).to_owned(); |
| 268 | let workflow = text("path").or_else(|| text("workflow")).unwrap_or_default(); |
| 269 | format!("{repo_id}/run/{workflow}@{branch}") |
| 270 | } |
| 271 | |
| 272 | /// The thread of a project's production, or of one pull request's preview: |
| 273 | /// `<repo_id>/deploy/<project_id>/<production|number>`. |
| 274 | pub fn deploy_thread(repo_id: &str, data: &serde_json::Value, number: Option<u32>) -> String { |
| 275 | let which = number.map_or_else(|| "production".to_owned(), |number| number.to_string()); |
| 276 | format!("{repo_id}/deploy/{}/{which}", data["projectId"].as_str().unwrap_or_default()) |
| 277 | } |
| 278 | |
| 279 | /// The thread an event's items go to. |
| 280 | pub fn thread_of(event: &Event, wanted: &Wanted, subject: Option<&InboxSubject>) -> Thread { |
| 281 | let data = &event.data; |
| 282 | let text = |key: &str| data[key].as_str().filter(|value| !value.is_empty()).map(str::to_owned); |
| 283 | match event.kind.as_str() { |
| 284 | // A project's production, or one pull request's preview. |
| 285 | "deployment.failed" | "deployment.succeeded" => { |
| 286 | Thread { |
| 287 | key: deploy_thread(wanted.repo(), data, wanted.number), |
| 288 | kind: Some(SubjectKind::Deploy), |
| 289 | number: wanted.number, |
| 290 | run_id: text("deploymentId"), |
| 291 | link: text("path"), |
| 292 | } |
| 293 | } |
| 294 | // One run's deployment to one environment, waiting for review. |
| 295 | "deployment.review_requested" => Thread { |
| 296 | key: format!( |
| 297 | "{}/review/{}/{}", |
| 298 | wanted.repo(), |
| 299 | text("runId").unwrap_or_default(), |
| 300 | text("environment").unwrap_or_default() |
| 301 | ), |
| 302 | kind: Some(SubjectKind::Run), |
| 303 | number: None, |
| 304 | run_id: text("runId"), |
| 305 | link: text("link"), |
| 306 | }, |
| 307 | // A workflow on a branch: its next failure bumps the same thread. |
| 308 | "workflow.completed" if subject.is_none() => { |
| 309 | Thread { |
| 310 | key: run_thread(wanted.repo(), data), |
| 311 | kind: Some(SubjectKind::Run), |
| 312 | number: None, |
| 313 | run_id: text("runId"), |
| 314 | link: None, |
| 315 | } |
| 316 | } |
| 317 | // One commit's comments (work/src/commit_comments.rs). |
| 318 | "commit_comment.created" => Thread { |
| 319 | key: format!("{}/commit/{}", wanted.repo(), text("commit").unwrap_or_default()), |
| 320 | kind: None, |
| 321 | number: None, |
| 322 | run_id: None, |
| 323 | link: text("link"), |
| 324 | }, |
| 325 | // A repository's alerts of one type (`rep_1/security/vulnerability`), |
| 326 | // its reports, one advisory, or one bypass request: the page is the link. |
| 327 | kind if SECURITY_EVENTS.contains(&kind) => { |
| 328 | let which = match kind { |
| 329 | "security_advisory.reported" => "reports".to_owned(), |
| 330 | "security_advisory.published" => format!("advisories/{}", text("id").unwrap_or_default()), |
| 331 | _ if kind.ends_with(".summary") => text("alertType").unwrap_or_else(|| "alerts".to_owned()), |
| 332 | _ => text("requestId").or_else(|| text("alertId")).unwrap_or_else(|| event.id.clone()), |
| 333 | }; |
| 334 | Thread { |
| 335 | key: format!("{}/security/{which}", wanted.repo()), |
| 336 | kind: None, |
| 337 | number: None, |
| 338 | run_id: None, |
| 339 | link: text("link"), |
| 340 | } |
| 341 | } |
| 342 | // A work item: one thread, wherever it is linked. |
| 343 | _ if wanted.item.is_some() => Thread { |
| 344 | key: item_thread(wanted.item.as_ref().map_or("", |item| item.id.as_str())), |
| 345 | kind: Some(SubjectKind::Item), |
| 346 | number: wanted.number, |
| 347 | run_id: None, |
| 348 | link: None, |
| 349 | }, |
| 350 | _ => match wanted.number { |
| 351 | Some(number) => Thread { |
| 352 | key: numbered_thread(wanted.repo(), number), |
| 353 | kind: subject.and_then(|subject| subject.kind), |
| 354 | number: Some(number), |
| 355 | run_id: None, |
| 356 | link: None, |
| 357 | }, |
| 358 | None => Thread { |
| 359 | key: format!("event/{}", event.id), |
| 360 | kind: None, |
| 361 | number: None, |
| 362 | run_id: None, |
| 363 | link: None, |
| 364 | }, |
| 365 | }, |
| 366 | } |
| 367 | } |
| 368 | |
| 369 | // --- Settling ---------------------------------------------------------------- |
| 370 | // |
| 371 | // An item is settled (marked done, and read) by the event that leaves |
| 372 | // nothing for its person to do about it, so the inbox, its count, Home's |
| 373 | // Needs you and `g1t status` show only what still waits on someone. A |
| 374 | // settled item stays in Done, with its history, until it is purged; new |
| 375 | // activity on its thread brings it back. |
| 376 | // |
| 377 | // | Item | Settled by | |
| 378 | // | --- | --- | |
| 379 | // | g1t stopped and needs you (`agent`) | `pull.resumed`, `pull.updated`, `pull.merge_requested`, `pull.merged`, `pull.closed` | |
| 380 | // | Anything on a work item or pull request | `work_item.closed`, `pull.merged`, `pull.closed`, after it is told (`closes`) | |
| 381 | // | Your own item on a thread | your comment or review on it (`handled_by`) | |
| 382 | // | A review asked of you | `pull.review_request_removed` naming you or your team | |
| 383 | // | Checks failed on a pull request (`ci_activity`) | `checks.completed` passed on its head | |
| 384 | // | A workflow failed on a branch | the next `workflow.completed` success of that workflow on that branch | |
| 385 | // | A deployment failed | `deployment.succeeded` of that project's production, or that preview | |
| 386 | // | A deployment waits for your review | `workflow.completed` of its run, however it ended | |
| 387 | // | A push protection bypass to review | `secret_scanning.bypass_reviewed` | |
| 388 | // | A token waits for your approval | `token.approval_reviewed` | |
| 389 | // | A workspace invitation | `workspace_invitation.accepted`, `.declined`, `.revoked` | |
| 390 | // | A scan's alerts | the next scan's summary with none open (`refresh_security_thread`) | |
| 391 | |
| 392 | /// Which threads a settle reaches. |
| 393 | #[derive(Clone, Debug, PartialEq, Eq)] |
| 394 | pub enum Scope { |
| 395 | /// One thread. |
| 396 | Thread(String), |
| 397 | /// Every thread matching a GLOB pattern, such as one pull request's |
| 398 | /// previews in every project: `rep_1/deploy/*/7`. |
| 399 | Matching(String), |
| 400 | } |
| 401 | |
| 402 | /// Items an event settles. |
| 403 | #[derive(Clone, Debug, PartialEq, Eq)] |
| 404 | pub struct Settle { |
| 405 | pub scope: Scope, |
| 406 | /// One person's item, or everyone's. |
| 407 | pub username: Option<String>, |
| 408 | /// Only items whose latest activity was for one of these reasons; any when empty. |
| 409 | pub reasons: Vec<Reason>, |
| 410 | /// Only items whose latest activity was one of these events; any when empty. |
| 411 | pub events: Vec<&'static str>, |
| 412 | /// Why, in a few words (`settled_reason`): "CI passed in run 330", "Merged". |
| 413 | pub why: Option<String>, |
| 414 | /// Who settled it, when a person or g1t did (`settled_by`): a username, or g1t. |
| 415 | pub by: Option<String>, |
| 416 | } |
| 417 | |
| 418 | /// An item a settle reached: whose, and its thread. |
| 419 | #[derive(Clone, Debug, PartialEq, Eq, Hash, Deserialize)] |
| 420 | pub struct Settled { |
| 421 | pub username: String, |
| 422 | pub thread: String, |
| 423 | } |
| 424 | |
| 425 | impl Settle { |
| 426 | fn thread(thread: impl Into<String>) -> Self { |
| 427 | Settle { |
| 428 | scope: Scope::Thread(thread.into()), |
| 429 | username: None, |
| 430 | reasons: Vec::new(), |
| 431 | events: Vec::new(), |
| 432 | why: None, |
| 433 | by: None, |
| 434 | } |
| 435 | } |
| 436 | |
| 437 | fn matching(pattern: impl Into<String>) -> Self { |
| 438 | Settle { |
| 439 | scope: Scope::Matching(pattern.into()), |
| 440 | ..Settle::thread("") |
| 441 | } |
| 442 | } |
| 443 | |
| 444 | fn because(mut self, reasons: &[Reason]) -> Self { |
| 445 | self.reasons = reasons.to_vec(); |
| 446 | self |
| 447 | } |
| 448 | |
| 449 | fn after(mut self, events: &[&'static str]) -> Self { |
| 450 | self.events = events.to_vec(); |
| 451 | self |
| 452 | } |
| 453 | |
| 454 | fn of(mut self, username: &str) -> Self { |
| 455 | self.username = Some(username.trim().trim_start_matches('@').to_lowercase()); |
| 456 | self |
| 457 | } |
| 458 | |
| 459 | /// Says why it settled, and who settled it when someone did. |
| 460 | fn saying(mut self, why: impl Into<String>, by: Option<&str>) -> Self { |
| 461 | self.why = Some(why.into()); |
| 462 | self.by = by.map(|name| name.trim().trim_start_matches('@').to_lowercase()).filter(|name| !name.is_empty()); |
| 463 | self |
| 464 | } |
| 465 | |
| 466 | /// The statement that settles the items, as of `now`, naming whose it |
| 467 | /// settled and their threads. |
| 468 | fn statement(&self, db: &D1Database, now: &str) -> Result<D1PreparedStatement> { |
| 469 | let mut values: Vec<JsValue> = vec![ |
| 470 | now.into(), |
| 471 | self.why.as_deref().map_or(JsValue::NULL, JsValue::from), |
| 472 | self.by.as_deref().map_or(JsValue::NULL, JsValue::from), |
| 473 | ]; |
| 474 | let mut conditions = vec!["done_at IS NULL".to_owned()]; |
| 475 | let bind = |values: &mut Vec<JsValue>, value: &str| { |
| 476 | values.push(value.into()); |
| 477 | format!("?{}", values.len()) |
| 478 | }; |
| 479 | match &self.scope { |
| 480 | Scope::Thread(thread) => conditions.push(format!("thread = {}", bind(&mut values, thread))), |
| 481 | Scope::Matching(pattern) => conditions.push(format!("thread GLOB {}", bind(&mut values, pattern))), |
| 482 | } |
| 483 | if let Some(username) = &self.username { |
| 484 | conditions.push(format!("username = {}", bind(&mut values, username))); |
| 485 | } |
| 486 | if !self.reasons.is_empty() { |
| 487 | let marks: Vec<String> = self.reasons.iter().map(|reason| bind(&mut values, reason.as_str())).collect(); |
| 488 | conditions.push(format!("reason IN ({})", marks.join(", "))); |
| 489 | } |
| 490 | if !self.events.is_empty() { |
| 491 | let marks: Vec<String> = self.events.iter().map(|kind| bind(&mut values, kind)).collect(); |
| 492 | conditions.push(format!("event IN ({})", marks.join(", "))); |
| 493 | } |
| 494 | db.prepare(format!( |
| 495 | "UPDATE inbox_items SET done_at = ?1, read_at = COALESCE(read_at, ?1), settled_reason = ?2, settled_by = ?3 |
| 496 | WHERE {} RETURNING username, thread", |
| 497 | conditions.join(" AND ") |
| 498 | )) |
| 499 | .bind(&values) |
| 500 | } |
| 501 | } |
| 502 | |
| 503 | /// The work item or pull request an event names, as its thread. |
| 504 | fn numbered(event: &Event) -> Option<String> { |
| 505 | if let Some(item) = item_of(&event.data) { |
| 506 | return Some(item_thread(&item.id)); |
| 507 | } |
| 508 | let repo_id = event.data["repoId"].as_str().map(str::to_owned).or_else(|| event.repo_id.clone())?; |
| 509 | let number = event.data["number"].as_u64().and_then(|n| u32::try_from(n).ok())?; |
| 510 | Some(numbered_thread(&repo_id, number)) |
| 511 | } |
| 512 | |
| 513 | /// Why an agent's wait is over, by the event that ended it (`RESUMES`). |
| 514 | fn resumed_because(kind: &str) -> &'static str { |
| 515 | match kind { |
| 516 | "pull.resumed" => "g1t went on", |
| 517 | "pull.updated" => "New commits were pushed", |
| 518 | "pull.merge_requested" => "Merge was asked for", |
| 519 | "pull.merged" => "Merged", |
| 520 | _ => "Closed", |
| 521 | } |
| 522 | } |
| 523 | |
| 524 | /// What an event settles before its own notices are written: what it |
| 525 | /// supersedes. A success after a failure, a review given or no longer |
| 526 | /// asked for, a request answered. `actor` is who caused it, by username |
| 527 | /// (g1t for g1t), when known: each settle says why, and who did. |
| 528 | pub fn settles(event: &Event, actor: Option<&str>) -> Vec<Settle> { |
| 529 | let data = &event.data; |
| 530 | let text = |key: &str| data[key].as_str().filter(|value| !value.is_empty()).map(str::to_owned); |
| 531 | let repo_id = text("repoId").or_else(|| event.repo_id.clone()); |
| 532 | let mut settled = Vec::new(); |
| 533 | let kind = event.kind.as_str(); |
| 534 | // What an agent was waiting on a person for is over. |
| 535 | if RESUMES.contains(&kind) |
| 536 | && let Some(thread) = numbered(event) |
| 537 | { |
| 538 | settled.push(Settle::thread(thread).because(&[Reason::Agent]).saying(resumed_because(kind), actor)); |
| 539 | } |
| 540 | match kind { |
| 541 | // Reviews no longer asked for, of the people or the teams named. |
| 542 | "pull.review_request_removed" => { |
| 543 | if let Some(thread) = numbered(event) { |
| 544 | let people = names(data, "reviewers").into_iter().chain(teams_asked(data).into_iter().flat_map(|(_, people)| people)); |
| 545 | for name in people.collect::<HashSet<_>>() { |
| 546 | settled.push( |
| 547 | Settle::thread(thread.clone()) |
| 548 | .because(&[Reason::ReviewRequested]) |
| 549 | .of(&name) |
| 550 | .saying("Review no longer asked of you", actor), |
| 551 | ); |
| 552 | } |
| 553 | } |
| 554 | } |
| 555 | // A workspace invitation answered or revoked no longer waits on its person. |
| 556 | _ if INVITATION_ANSWERED.contains(&kind) => { |
| 557 | if let Some(thread) = text("thread").filter(|thread| thread.starts_with("invitation:")) { |
| 558 | let why = match kind { |
| 559 | "workspace_invitation.accepted" => "Invitation accepted", |
| 560 | "workspace_invitation.declined" => "Invitation declined", |
| 561 | _ => "Invitation revoked", |
| 562 | }; |
| 563 | settled.push(Settle::thread(thread).because(&[Reason::ReviewRequested]).saying(why, actor)); |
| 564 | } |
| 565 | } |
| 566 | // A token approved, denied or revoked no longer waits on the owners. |
| 567 | "token.approval_reviewed" => { |
| 568 | let (thread, _) = workspace_notices(event, None); |
| 569 | settled.push(Settle::thread(thread).because(&[Reason::ReviewRequested]).saying("Token request decided", actor)); |
| 570 | } |
| 571 | // Every check on its head passes now (or none fails): the failure |
| 572 | // its owner was told of is behind them. |
| 573 | "checks.completed" if data["status"].as_str() == Some("passed") => { |
| 574 | if let Some(thread) = numbered(event) { |
| 575 | let why = match text("commit") { |
| 576 | Some(commit) => format!("Checks passed on {}", short(&commit)), |
| 577 | None => "Checks passed".to_owned(), |
| 578 | }; |
| 579 | settled.push(Settle::thread(thread).because(&[Reason::CiActivity]).saying(why, None)); |
| 580 | } |
| 581 | } |
| 582 | "workflow.completed" => { |
| 583 | if let Some(repo_id) = &repo_id { |
| 584 | let workflow = text("workflow").unwrap_or_else(|| "The workflow".to_owned()); |
| 585 | let run = data["number"].as_u64().map(|n| format!(" in run {n}")).unwrap_or_default(); |
| 586 | // The workflow passes on the branch again: its failures there are over. |
| 587 | if data["conclusion"].as_str() == Some("success") && data["pull"].as_u64().is_none() { |
| 588 | settled.push(Settle::thread(run_thread(repo_id, data)).saying(format!("{workflow} passed{run}"), None)); |
| 589 | } |
| 590 | // Its run is over, however it ended: no deployment of it waits for review. |
| 591 | if let Some(id) = text("runId") { |
| 592 | settled.push( |
| 593 | Settle::matching(format!("{repo_id}/review/{id}/*")) |
| 594 | .because(&[Reason::ReviewRequested]) |
| 595 | .saying(format!("{workflow} finished{run}"), None), |
| 596 | ); |
| 597 | } |
| 598 | } |
| 599 | } |
| 600 | // It deployed: the failure before it is over. |
| 601 | "deployment.succeeded" => { |
| 602 | if let Some(repo_id) = &repo_id { |
| 603 | let number = data["number"].as_u64().and_then(|n| u32::try_from(n).ok()); |
| 604 | let what = match number { |
| 605 | Some(n) => format!("Preview of #{n}"), |
| 606 | None => text("project").map_or_else(|| "Production".to_owned(), |project| format!("Production of {project}")), |
| 607 | }; |
| 608 | let commit = text("commit").map(|commit| format!(" at {}", short(&commit))).unwrap_or_default(); |
| 609 | let by = actor.map(str::to_owned).or_else(|| text("triggeredBy")); |
| 610 | settled.push( |
| 611 | Settle::thread(deploy_thread(repo_id, data, number)) |
| 612 | .after(&["deployment.failed"]) |
| 613 | .saying(format!("{what} deployed{commit}"), by.as_deref()), |
| 614 | ); |
| 615 | } |
| 616 | } |
| 617 | // A bypass decided no longer waits on its reviewers. |
| 618 | "secret_scanning.bypass_reviewed" => { |
| 619 | if let (Some(repo_id), Some(which)) = (&repo_id, text("requestId").or_else(|| text("alertId"))) { |
| 620 | settled.push( |
| 621 | Settle::thread(format!("{repo_id}/security/{which}")) |
| 622 | .because(&[Reason::SecurityAlert]) |
| 623 | .saying("Bypass request decided", actor), |
| 624 | ); |
| 625 | } |
| 626 | } |
| 627 | _ => {} |
| 628 | } |
| 629 | settled |
| 630 | } |
| 631 | |
| 632 | /// The events after which nothing is left to do about a work item or pull |
| 633 | /// request: every item about it is settled once its own notices are |
| 634 | /// written, so they reach each thread's history but nobody's inbox, and |
| 635 | /// are not pushed. What landed shows on Home instead. |
| 636 | pub const CLOSES: [&str; 3] = ["pull.merged", "pull.closed", "work_item.closed"]; |
| 637 | |
| 638 | /// What an event settles once its own notices are written: everything |
| 639 | /// about a work item or pull request that is over, a pull request's |
| 640 | /// previews with it. `actor` is who merged or closed it, by username. |
| 641 | pub fn closes(event: &Event, actor: Option<&str>) -> Vec<Settle> { |
| 642 | if !CLOSES.contains(&event.kind.as_str()) { |
| 643 | return Vec::new(); |
| 644 | } |
| 645 | let Some(thread) = numbered(event) else { |
| 646 | return Vec::new(); |
| 647 | }; |
| 648 | let why = match event.kind.as_str() { |
| 649 | "pull.merged" => "Merged", |
| 650 | "work_item.closed" if event.data["reason"].as_str() == Some("not_planned") => "Closed as not planned", |
| 651 | _ => "Closed", |
| 652 | }; |
| 653 | let mut settled = vec![Settle::thread(thread).saying(why, actor)]; |
| 654 | if event.kind.starts_with("pull.") |
| 655 | && let (Some(repo_id), Some(number)) = ( |
| 656 | event.data["repoId"].as_str().map(str::to_owned).or_else(|| event.repo_id.clone()), |
| 657 | event.data["number"].as_u64(), |
| 658 | ) |
| 659 | { |
| 660 | settled.push(Settle::matching(format!("{repo_id}/deploy/*/{number}")).saying(why, actor)); |
| 661 | } |
| 662 | settled |
| 663 | } |
| 664 | |
| 665 | /// The item a person's own comment or review settles: theirs on that |
| 666 | /// thread, which they have answered. Never an agent's, nor g1t's. |
| 667 | pub fn handled_by(event: &Event, subject: Option<&InboxSubject>) -> Option<Settle> { |
| 668 | if event.kind != "comment.created" { |
| 669 | return None; |
| 670 | } |
| 671 | let comment = subject?.comment.as_ref().filter(|comment| !comment.event && comment.agent.is_none())?; |
| 672 | if is_g1t_id(&comment.author.id) || is_g1t(&comment.author.username) { |
| 673 | return None; |
| 674 | } |
| 675 | let why = if comment.verdict.is_some() { "Reviewed" } else { "Commented" }; |
| 676 | Some(Settle::thread(numbered(event)?).of(&comment.author.username).saying(why, Some(&comment.author.username))) |
| 677 | } |
| 678 | |
| 679 | /// Collects who is told, each once with the most specific reason, never |
| 680 | /// the actor, never g1t, and never anyone ignoring the thread. |
| 681 | struct Told<'a> { |
| 682 | actor: &'a Actor, |
| 683 | audience: &'a Audience, |
| 684 | notices: Vec<Notice>, |
| 685 | } |
| 686 | |
| 687 | impl Told<'_> { |
| 688 | /// `asked`: something asked of the person directly, told even when |
| 689 | /// they unsubscribed from the thread. |
| 690 | fn tell(&mut self, username: &str, reason: Reason, severity: Severity, title: &str, body: &str, asked: bool) { |
| 691 | let username = username.trim().trim_start_matches('@').to_lowercase(); |
| 692 | if username.is_empty() |
| 693 | || is_g1t(&username) |
| 694 | || self.actor.is_named(&username) |
| 695 | || self.audience.ignores(&username) |
| 696 | || (!asked && self.audience.unsubscribed(&username)) |
| 697 | { |
| 698 | return; |
| 699 | } |
| 700 | let notice = Notice { |
| 701 | username, |
| 702 | reason, |
| 703 | severity, |
| 704 | title: clip(title, MAX_TITLE), |
| 705 | body: clip(body, MAX_BODY), |
| 706 | }; |
| 707 | match self.notices.iter_mut().find(|told| told.username == notice.username) { |
| 708 | Some(told) if notice.reason.rank() < told.reason.rank() => *told = notice, |
| 709 | Some(_) => {} |
| 710 | None => self.notices.push(notice), |
| 711 | } |
| 712 | } |
| 713 | |
| 714 | /// A person known by id as well as name, such as an author. |
| 715 | fn tell_person(&mut self, person: &Principal, reason: Reason, severity: Severity, title: &str, body: &str, asked: bool) { |
| 716 | if is_g1t_id(&person.id) || self.actor.is(person) { |
| 717 | return; |
| 718 | } |
| 719 | self.tell(&person.username, reason, severity, title, body, asked); |
| 720 | } |
| 721 | |
| 722 | /// Everyone subscribed to a work item or pull request: its owner and |
| 723 | /// author, its assignees and reviewers, and whoever subscribed by |
| 724 | /// commenting, being mentioned or by hand. `reason` overrides why |
| 725 | /// each is told, as a state change does. |
| 726 | fn tell_subscribed(&mut self, subject: &InboxSubject, reason: Option<Reason>, severity: Severity, title: &str, body: &str) { |
| 727 | let why = |own: Reason| reason.unwrap_or(own); |
| 728 | self.tell_person(subject.owner(), why(Reason::Author), severity, title, body, false); |
| 729 | self.tell_person(&subject.author, why(Reason::Author), severity, title, body, false); |
| 730 | for name in &subject.assignees { |
| 731 | self.tell(name, why(Reason::Assign), severity, title, body, false); |
| 732 | } |
| 733 | for name in &subject.reviewers { |
| 734 | self.tell(name, why(Reason::ReviewRequested), severity, title, body, false); |
| 735 | } |
| 736 | let subscribed: Vec<(String, Reason)> = self.audience.subscribed().collect(); |
| 737 | for (name, own) in subscribed { |
| 738 | self.tell(&name, why(own), severity, title, body, false); |
| 739 | } |
| 740 | } |
| 741 | |
| 742 | /// Everyone watching the repository for this kind of activity. |
| 743 | fn tell_watchers(&mut self, kind: &str, severity: Severity, title: &str, body: &str) { |
| 744 | let watching: Vec<String> = self.audience.watching(kind).collect(); |
| 745 | for name in watching { |
| 746 | self.tell(&name, Reason::Subscribed, severity, title, body, false); |
| 747 | } |
| 748 | } |
| 749 | } |
| 750 | |
| 751 | fn clip(text: &str, max: usize) -> String { |
| 752 | let text = text.trim(); |
| 753 | if text.chars().count() <= max { |
| 754 | return text.to_owned(); |
| 755 | } |
| 756 | let cut: String = text.chars().take(max - 1).collect(); |
| 757 | format!("{}…", cut.trim_end()) |
| 758 | } |
| 759 | |
| 760 | /// The kind of activity a watcher chooses: `work_items` or `pulls`. |
| 761 | fn activity_of(subject: &InboxSubject) -> &'static str { |
| 762 | match subject.kind { |
| 763 | Some(SubjectKind::Pull) => "pulls", |
| 764 | _ => "work_items", |
| 765 | } |
| 766 | } |
| 767 | |
| 768 | /// The names in an event's list field, such as the reviewers just asked. |
| 769 | /// The teams an event asked to review: each `workspace/slug` with the |
| 770 | /// people it tells. |
| 771 | fn teams_asked(data: &serde_json::Value) -> Vec<(String, Vec<String>)> { |
| 772 | data["teams"] |
| 773 | .as_array() |
| 774 | .map(|teams| { |
| 775 | teams |
| 776 | .iter() |
| 777 | .filter_map(|team| Some((team["team"].as_str()?.to_owned(), names(team, "notified")))) |
| 778 | .collect() |
| 779 | }) |
| 780 | .unwrap_or_default() |
| 781 | } |
| 782 | |
| 783 | fn names(data: &serde_json::Value, key: &str) -> Vec<String> { |
| 784 | data[key] |
| 785 | .as_array() |
| 786 | .map(|names| names.iter().filter_map(|name| name.as_str().map(str::to_owned)).collect()) |
| 787 | .unwrap_or_default() |
| 788 | } |
| 789 | |
| 790 | /// Who is told of `event`, in `repo` (`owner/name`, or for a work item its |
| 791 | /// workspace), given what it names and who follows it. `actor` is who |
| 792 | /// caused it; outcomes nobody chose (checks, workflows, deployments, g1t |
| 793 | /// stopping) are told whoever caused them. |
| 794 | pub fn notices(event: &Event, repo: &str, actor: &Actor, subject: Option<&InboxSubject>, audience: &Audience) -> Vec<Notice> { |
| 795 | let nobody = Actor::default(); |
| 796 | let data = &event.data; |
| 797 | // The work item or pull request, as titles name it: `acme/rocket#12`, |
| 798 | // or `acme#12` for a work item. |
| 799 | let at = match data["number"].as_u64().or(data["pull"].as_u64()) { |
| 800 | Some(number) if subject.is_some() => format!("{repo}#{number}"), |
| 801 | _ => repo.to_owned(), |
| 802 | }; |
| 803 | let outcome = matches!( |
| 804 | event.kind.as_str(), |
| 805 | "checks.completed" |
| 806 | | "workflow.completed" |
| 807 | | "pull.stalled" |
| 808 | | "deployment.failed" |
| 809 | | "deployment.succeeded" |
| 810 | | "deployment.review_requested" |
| 811 | ) || SECURITY_EVENTS.contains(&event.kind.as_str()); |
| 812 | let mut told = Told { |
| 813 | actor: if outcome { &nobody } else { actor }, |
| 814 | audience, |
| 815 | notices: Vec::new(), |
| 816 | }; |
| 817 | // Who did it, as titles name them. |
| 818 | let who = actor.name().unwrap_or("g1t"); |
| 819 | |
| 820 | match (event.kind.as_str(), subject) { |
| 821 | ("pull.stalled", Some(pull)) => { |
| 822 | let detail = data["detail"].as_str().map(str::trim).filter(|detail| !detail.is_empty()); |
| 823 | let (title, body) = (format!("g1t stopped on {at} and needs you"), detail.unwrap_or(&pull.title).to_owned()); |
| 824 | told.tell_person(pull.owner(), Reason::Agent, Severity::Warning, &title, &body, true); |
| 825 | if let Some(item) = &pull.item { |
| 826 | told.tell_person(item.owner(), Reason::Agent, Severity::Warning, &title, &body, true); |
| 827 | for name in &item.assignees { |
| 828 | told.tell(name, Reason::Agent, Severity::Warning, &title, &body, true); |
| 829 | } |
| 830 | } |
| 831 | } |
| 832 | // Whoever turned auto-merge on hears that it is off, unless they |
| 833 | // turned it off themselves: it will not merge without them now. |
| 834 | // Not when g1t handed it to the merge queue, which lands it: there |
| 835 | // is nothing for them to do. |
| 836 | ("pull.auto_merge_disabled", Some(pull)) => { |
| 837 | if data["queued"].as_bool() == Some(true) { |
| 838 | return told.notices; |
| 839 | } |
| 840 | if let Some(by) = data["autoMergeBy"].as_str() { |
| 841 | let detail = data["detail"].as_str().map(str::trim).filter(|detail| !detail.is_empty()); |
| 842 | let title = format!("Auto-merge was turned off on {at}"); |
| 843 | told.tell(by, Reason::StateChange, Severity::Warning, &title, detail.unwrap_or(&pull.title), true); |
| 844 | } |
| 845 | } |
| 846 | ("pull.review_requested", Some(pull)) => { |
| 847 | // Asked because the CODEOWNERS file says they own what changed. |
| 848 | let owned = data["codeOwners"].as_bool() == Some(true); |
| 849 | let title = if owned { |
| 850 | format!("{at} changes files you own") |
| 851 | } else { |
| 852 | format!("{who} asked you to review {at}") |
| 853 | }; |
| 854 | for name in names(data, "reviewers") { |
| 855 | told.tell(&name, Reason::ReviewRequested, Severity::Warning, &title, &pull.title, true); |
| 856 | } |
| 857 | for (team, people) in teams_asked(data) { |
| 858 | let title = if owned { |
| 859 | format!("{at} changes files @{team} owns") |
| 860 | } else { |
| 861 | format!("{who} asked @{team} to review {at}") |
| 862 | }; |
| 863 | for name in people { |
| 864 | told.tell(&name, Reason::ReviewRequested, Severity::Warning, &title, &pull.title, true); |
| 865 | } |
| 866 | } |
| 867 | } |
| 868 | ("work_item.assigned" | "pull.assigned", Some(on)) => { |
| 869 | let title = format!("{who} assigned you to {at}"); |
| 870 | for name in names(data, "added") { |
| 871 | told.tell(&name, Reason::Assign, Severity::Info, &title, &on.title, true); |
| 872 | } |
| 873 | } |
| 874 | ("work_item.opened" | "pull.opened", Some(on)) => { |
| 875 | let title = format!("{who} opened {at}"); |
| 876 | for name in &on.assignees { |
| 877 | told.tell(name, Reason::Assign, Severity::Info, &format!("{who} assigned you to {at}"), &on.title, true); |
| 878 | } |
| 879 | for name in &on.reviewers { |
| 880 | told.tell(name, Reason::ReviewRequested, Severity::Warning, &format!("{who} asked you to review {at}"), &on.title, true); |
| 881 | } |
| 882 | for name in &on.mentions { |
| 883 | told.tell(name, Reason::Mention, Severity::Info, &format!("{who} mentioned you on {at}"), &on.title, true); |
| 884 | } |
| 885 | for team in &on.team_mentions { |
| 886 | let title = format!("{who} mentioned @{} on {at}", team.team); |
| 887 | for name in &team.members { |
| 888 | told.tell(name, Reason::TeamMention, Severity::Info, &title, &on.title, true); |
| 889 | } |
| 890 | } |
| 891 | told.tell_watchers(activity_of(on), Severity::Info, &title, &on.title); |
| 892 | } |
| 893 | ("checks.completed", Some(pull)) => { |
| 894 | let title = match data["status"].as_str() { |
| 895 | Some("errored") => format!("Checks could not run on {at}"), |
| 896 | _ => format!("Checks failed on {at}"), |
| 897 | }; |
| 898 | told.tell_person(pull.owner(), Reason::CiActivity, Severity::Error, &title, &pull.title, true); |
| 899 | } |
| 900 | ("workflow.completed", subject) => { |
| 901 | let workflow = data["workflow"].as_str().filter(|name| !name.is_empty()).unwrap_or("A workflow"); |
| 902 | match subject { |
| 903 | Some(pull) => { |
| 904 | let title = format!("{workflow} failed on {at}"); |
| 905 | told.tell_person(pull.owner(), Reason::CiActivity, Severity::Error, &title, &pull.title, true); |
| 906 | } |
| 907 | None => { |
| 908 | // Not on a pull request: whoever pushed the commit it ran on. |
| 909 | let branch = data["ref"].as_str().unwrap_or_default(); |
| 910 | let branch = branch.strip_prefix("refs/heads/").unwrap_or(branch); |
| 911 | let title = format!("{workflow} failed on {branch} in {repo}"); |
| 912 | let body = format!("Run {} at {}", data["number"], short(data["sha"].as_str().unwrap_or_default())); |
| 913 | if let Some(id) = &actor.id |
| 914 | && !is_g1t_id(id) |
| 915 | && let Some(name) = &actor.username |
| 916 | { |
| 917 | told.tell(name, Reason::CiActivity, Severity::Error, &title, &body, true); |
| 918 | } |
| 919 | } |
| 920 | } |
| 921 | } |
| 922 | ("deployment.failed" | "deployment.succeeded", subject) => { |
| 923 | let failed = event.kind == "deployment.failed"; |
| 924 | let project = data["project"].as_str().filter(|name| !name.is_empty()).unwrap_or(repo); |
| 925 | let what = match subject { |
| 926 | Some(_) => format!("The preview of {at}"), |
| 927 | None => format!("Production of {project}"), |
| 928 | }; |
| 929 | let (title, severity) = if failed { |
| 930 | (format!("{what} failed to deploy"), Severity::Error) |
| 931 | } else { |
| 932 | (format!("{what} is live"), Severity::Success) |
| 933 | }; |
| 934 | let body = match (failed, data["error"].as_str().map(str::trim).filter(|error| !error.is_empty())) { |
| 935 | (true, Some(error)) => error.to_owned(), |
| 936 | _ => match subject { |
| 937 | Some(pull) => pull.title.clone(), |
| 938 | None => format!("Commit {}", short(data["commit"].as_str().unwrap_or_default())), |
| 939 | }, |
| 940 | }; |
| 941 | // A failure is whoever answers for it's to fix. A success after |
| 942 | // one tells them nothing: it settles the failure's item instead |
| 943 | // (`settles`), so there is nothing left in their inbox about it. |
| 944 | if failed { |
| 945 | match subject { |
| 946 | Some(pull) => told.tell_person(pull.owner(), Reason::CiActivity, severity, &title, &body, true), |
| 947 | None => { |
| 948 | let pusher = actor |
| 949 | .id |
| 950 | .as_deref() |
| 951 | .filter(|id| !is_g1t_id(id)) |
| 952 | .and(actor.username.as_deref()) |
| 953 | .or_else(|| data["triggeredBy"].as_str()); |
| 954 | if let Some(name) = pusher { |
| 955 | told.tell(name, Reason::CiActivity, severity, &title, &body, true); |
| 956 | } |
| 957 | } |
| 958 | } |
| 959 | } |
| 960 | told.tell_watchers("deployments", severity, &title, &body); |
| 961 | } |
| 962 | ("pull.merged" | "pull.closed" | "work_item.closed" | "work_item.reopened", Some(on)) => { |
| 963 | let (verb, severity) = match event.kind.as_str() { |
| 964 | "pull.merged" => ("merged", Severity::Success), |
| 965 | "work_item.reopened" => ("reopened", Severity::Info), |
| 966 | _ => ("closed", Severity::Info), |
| 967 | }; |
| 968 | let title = match (actor.name(), landed_by(data)) { |
| 969 | (_, Some(what)) if event.kind == "work_item.closed" => format!("{at} was closed by {what}"), |
| 970 | (Some(name), _) => format!("{name} {verb} {at}"), |
| 971 | (None, _) => format!("{at} was {verb}"), |
| 972 | }; |
| 973 | told.tell_subscribed(on, Some(Reason::StateChange), severity, &title, &on.title); |
| 974 | told.tell_watchers(activity_of(on), severity, &title, &on.title); |
| 975 | } |
| 976 | ("deployment.review_requested", _) => { |
| 977 | let environment = data["environment"].as_str().unwrap_or("an environment"); |
| 978 | let workflow = data["workflow"].as_str().unwrap_or("A workflow"); |
| 979 | let title = format!("{workflow} is waiting for your review to deploy to {environment} in {repo}"); |
| 980 | let body = data["title"].as_str().unwrap_or_default(); |
| 981 | // Those the actions service names: the environment's reviewers. |
| 982 | for name in names(data, "notify") { |
| 983 | told.tell(&name, Reason::ReviewRequested, Severity::Warning, &title, body, true); |
| 984 | } |
| 985 | } |
| 986 | (kind, None) if SECURITY_EVENTS.contains(&kind) => { |
| 987 | let what = data["title"].as_str().unwrap_or("A security alert"); |
| 988 | match kind { |
| 989 | "secret_scanning.bypass_requested" => { |
| 990 | let title = format!("{who} asked to bypass push protection in {repo}"); |
| 991 | for name in names(data, "notify") { |
| 992 | told.tell(&name, Reason::SecurityAlert, Severity::Warning, &title, what, true); |
| 993 | } |
| 994 | } |
| 995 | "secret_scanning.bypass_reviewed" => { |
| 996 | let verdict = data["state"].as_str().unwrap_or("reviewed"); |
| 997 | let title = format!("Your request to bypass push protection in {repo} was {verdict}"); |
| 998 | for name in names(data, "notify") { |
| 999 | told.tell(&name, Reason::SecurityAlert, Severity::Info, &title, what, true); |
| 1000 | } |
| 1001 | } |
| 1002 | // Something to act on: the owners and security managers, at once. |
| 1003 | "security_advisory.reported" => { |
| 1004 | let title = format!("A vulnerability was reported privately to {repo}"); |
| 1005 | for name in names(data, "notify") { |
| 1006 | told.tell(&name, Reason::SecurityAlert, Severity::Warning, &title, what, true); |
| 1007 | } |
| 1008 | } |
| 1009 | // Published for everyone: watchers who chose security. |
| 1010 | "security_advisory.published" => { |
| 1011 | let title = format!("{repo} published a security advisory"); |
| 1012 | told.tell_watchers("security", Severity::Info, &title, what); |
| 1013 | } |
| 1014 | // A scan's summary. One that opened nothing is no news: it |
| 1015 | // brings the thread up to date instead (deliver_one). Whether |
| 1016 | // what is not urgent is told now or in a digest is each |
| 1017 | // person's choice, applied there too. |
| 1018 | _ => { |
| 1019 | let Some(summary) = security_summary(event) else { |
| 1020 | return told.notices; |
| 1021 | }; |
| 1022 | if summary.opened_count == 0 { |
| 1023 | return told.notices; |
| 1024 | } |
| 1025 | let severity = if summary.urgent() { Severity::Error } else { Severity::Info }; |
| 1026 | let (title, pushed) = summary_titles(repo, &summary); |
| 1027 | let body = summary.latest.clone().unwrap_or_default(); |
| 1028 | // Whoever pushed a refused push must act: told at once, whatever was found. |
| 1029 | if let Some(pusher) = &summary.pusher { |
| 1030 | told.tell(pusher, Reason::SecurityAlert, Severity::Error, &pushed, &body, true); |
| 1031 | } |
| 1032 | for name in &summary.notify { |
| 1033 | told.tell(name, Reason::SecurityAlert, severity, &title, &body, true); |
| 1034 | } |
| 1035 | // Watchers who chose security alerts, if they may see findings: |
| 1036 | // the service lists who may (`members`), as findings are never |
| 1037 | // shown to someone who cannot change the code. |
| 1038 | let members = names(data, "members"); |
| 1039 | let watching: Vec<String> = told.audience.watching("security").collect(); |
| 1040 | for name in watching.iter().filter(|name| members.iter().any(|member| member.eq_ignore_ascii_case(name))) { |
| 1041 | told.tell(name, Reason::SecurityAlert, severity, &title, &body, false); |
| 1042 | } |
| 1043 | } |
| 1044 | } |
| 1045 | } |
| 1046 | // The work service names who: the people and teams mentioned, and |
| 1047 | // the commit's author when they have an account. |
| 1048 | ("commit_comment.created", None) => { |
| 1049 | let short = data["commit"].as_str().map(short).unwrap_or_default(); |
| 1050 | let at = format!("{repo}@{short}"); |
| 1051 | let body = data["excerpt"].as_str().unwrap_or_default(); |
| 1052 | for name in names(data, "mentions") { |
| 1053 | told.tell(&name, Reason::Mention, Severity::Info, &format!("{who} mentioned you on {at}"), body, true); |
| 1054 | } |
| 1055 | for team in data["teamMentions"].as_array().into_iter().flatten() { |
| 1056 | let title = format!("{who} mentioned @{} on {at}", team["team"].as_str().unwrap_or_default()); |
| 1057 | for name in names(team, "members") { |
| 1058 | told.tell(&name, Reason::TeamMention, Severity::Info, &title, body, true); |
| 1059 | } |
| 1060 | } |
| 1061 | if let Some(author) = data["commitAuthor"].as_str() { |
| 1062 | told.tell(author, Reason::Author, Severity::Info, &format!("{who} commented on your commit {at}"), body, false); |
| 1063 | } |
| 1064 | } |
| 1065 | ("comment.created", Some(on)) => { |
| 1066 | let Some(comment) = on.comment.as_ref().filter(|comment| !comment.event) else { |
| 1067 | return Vec::new(); |
| 1068 | }; |
| 1069 | // Whoever wrote it is the actor, whatever the event says. One of |
| 1070 | // the workspace's agents is shown by its name, marked as an |
| 1071 | // agent; its handle is not a person's, so nobody is left out |
| 1072 | // for sharing it, and whoever it acted for hears of it as of |
| 1073 | // anything they set off. |
| 1074 | let writer = match &comment.agent { |
| 1075 | Some(agent) => Actor { id: Some(agent.id.clone()), username: None }, |
| 1076 | None => Actor { |
| 1077 | id: Some(comment.author.id.clone()), |
| 1078 | username: Some(comment.author.username.clone()), |
| 1079 | }, |
| 1080 | }; |
| 1081 | told.actor = &writer; |
| 1082 | let who = match &comment.agent { |
| 1083 | Some(agent) => format!("{} (agent)", agent.display_name), |
| 1084 | None => comment.author.username.clone(), |
| 1085 | }; |
| 1086 | let advisory = if comment.advisory { " (advisory)" } else { "" }; |
| 1087 | let body = if comment.excerpt.is_empty() { &on.title } else { &comment.excerpt }; |
| 1088 | for name in &comment.mentions { |
| 1089 | let title = format!("{who} mentioned you on {at}"); |
| 1090 | told.tell(name, Reason::Mention, Severity::Info, &title, body, true); |
| 1091 | } |
| 1092 | for team in &comment.team_mentions { |
| 1093 | let title = format!("{who} mentioned @{} on {at}", team.team); |
| 1094 | for name in &team.members { |
| 1095 | told.tell(name, Reason::TeamMention, Severity::Info, &title, body, true); |
| 1096 | } |
| 1097 | } |
| 1098 | let (severity, title) = match comment.verdict.as_deref() { |
| 1099 | Some("approve") => (Severity::Success, format!("{who} approved {at}{advisory}")), |
| 1100 | Some("request_changes") => (Severity::Info, format!("{who} asked for changes on {at}{advisory}")), |
| 1101 | _ if comment.advisory => (Severity::Info, format!("{who} reviewed {at}{advisory}")), |
| 1102 | _ => (Severity::Info, format!("{who} commented on {at}")), |
| 1103 | }; |
| 1104 | // An approval or a request for changes (or an agent's review) |
| 1105 | // is the owner's to hear of whatever they chose; the rest, as |
| 1106 | // they subscribed. |
| 1107 | if comment.verdict.is_some() || comment.advisory { |
| 1108 | told.tell_person(on.owner(), Reason::Author, severity, &title, body, true); |
| 1109 | } |
| 1110 | told.tell_subscribed(on, None, severity, &title, body); |
| 1111 | told.tell_watchers(activity_of(on), severity, &title, body); |
| 1112 | return told.notices; |
| 1113 | } |
| 1114 | _ => {} |
| 1115 | } |
| 1116 | told.notices |
| 1117 | } |
| 1118 | |
| 1119 | /// Who an event subscribes to its work item or pull request without asking, |
| 1120 | /// and why: whoever commented, whoever they mentioned, the people assigned |
| 1121 | /// and the reviewers asked. Never g1t. |
| 1122 | pub fn subscribes(event: &Event, subject: Option<&InboxSubject>) -> Vec<(String, Reason)> { |
| 1123 | let mut people: Vec<(String, Reason)> = Vec::new(); |
| 1124 | let mut add = |name: &str, reason: Reason| { |
| 1125 | let name = name.trim().trim_start_matches('@').to_lowercase(); |
| 1126 | if !name.is_empty() && !is_g1t(&name) && !people.iter().any(|(had, _)| *had == name) { |
| 1127 | people.push((name, reason)); |
| 1128 | } |
| 1129 | }; |
| 1130 | match event.kind.as_str() { |
| 1131 | "comment.created" => { |
| 1132 | if let Some(comment) = subject.and_then(|subject| subject.comment.as_ref()).filter(|comment| !comment.event) { |
| 1133 | // An agent is no person to subscribe; its handle may be someone's name. |
| 1134 | if !is_g1t_id(&comment.author.id) && comment.agent.is_none() { |
| 1135 | add(&comment.author.username, Reason::Comment); |
| 1136 | } |
| 1137 | for name in &comment.mentions { |
| 1138 | add(name, Reason::Mention); |
| 1139 | } |
| 1140 | for team in &comment.team_mentions { |
| 1141 | for name in &team.members { |
| 1142 | add(name, Reason::TeamMention); |
| 1143 | } |
| 1144 | } |
| 1145 | } |
| 1146 | } |
| 1147 | "work_item.opened" | "pull.opened" => { |
| 1148 | if let Some(on) = subject { |
| 1149 | for name in &on.mentions { |
| 1150 | add(name, Reason::Mention); |
| 1151 | } |
| 1152 | for team in &on.team_mentions { |
| 1153 | for name in &team.members { |
| 1154 | add(name, Reason::TeamMention); |
| 1155 | } |
| 1156 | } |
| 1157 | } |
| 1158 | } |
| 1159 | "work_item.assigned" | "pull.assigned" => { |
| 1160 | for name in names(&event.data, "added") { |
| 1161 | add(&name, Reason::Assign); |
| 1162 | } |
| 1163 | } |
| 1164 | "pull.review_requested" => { |
| 1165 | for name in names(&event.data, "reviewers") { |
| 1166 | add(&name, Reason::ReviewRequested); |
| 1167 | } |
| 1168 | for (_, people) in teams_asked(&event.data) { |
| 1169 | for name in people { |
| 1170 | add(&name, Reason::ReviewRequested); |
| 1171 | } |
| 1172 | } |
| 1173 | } |
| 1174 | _ => {} |
| 1175 | } |
| 1176 | people |
| 1177 | } |
| 1178 | |
| 1179 | fn short(sha: &str) -> &str { |
| 1180 | sha.get(..7).unwrap_or(sha) |
| 1181 | } |
| 1182 | |
| 1183 | /// What landed a work item, as a close says it: the pull request |
| 1184 | /// (`acme/rocket#9`) or the commit (`acme/rocket@1a2b3c4`), from its |
| 1185 | /// `resolution`. |
| 1186 | fn landed_by(data: &serde_json::Value) -> Option<String> { |
| 1187 | let resolution = &data["resolution"]; |
| 1188 | let repo = resolution["repo"].as_str().filter(|repo| !repo.is_empty())?; |
| 1189 | match (resolution["pull"].as_u64(), resolution["commit"].as_str()) { |
| 1190 | (Some(pull), _) => Some(format!("{repo}#{pull}")), |
| 1191 | (None, Some(commit)) => Some(format!("{repo}@{}", short(commit))), |
| 1192 | _ => None, |
| 1193 | } |
| 1194 | } |
| 1195 | |
| 1196 | // --- Security summaries ------------------------------------------------------ |
| 1197 | |
| 1198 | /// The scan summary a `<type>_alert.summary` event carries. |
| 1199 | pub fn security_summary(event: &Event) -> Option<SecuritySummary> { |
| 1200 | if !event.kind.ends_with("_alert.summary") { |
| 1201 | return None; |
| 1202 | } |
| 1203 | serde_json::from_value(event.data.clone()).ok() |
| 1204 | } |
| 1205 | |
| 1206 | /// "1 critical, 2 high": the counts that are not zero, worst first. |
| 1207 | pub fn breakdown(counts: &SeverityCounts) -> String { |
| 1208 | [("critical", counts.critical), ("high", counts.high), ("medium", counts.medium), ("low", counts.low), ("unknown", counts.unknown)] |
| 1209 | .into_iter() |
| 1210 | .filter(|(_, n)| *n > 0) |
| 1211 | .map(|(name, n)| format!("{n} {name}")) |
| 1212 | .collect::<Vec<_>>() |
| 1213 | .join(", ") |
| 1214 | } |
| 1215 | |
| 1216 | /// "vulnerability" or "vulnerabilities", as a count wants. |
| 1217 | fn alerts_called(alert_type: &str, n: u32) -> &'static str { |
| 1218 | match (AlertType::parse(alert_type), n) { |
| 1219 | (Some(AlertType::SecretScanning), 1) => "secret", |
| 1220 | (Some(AlertType::SecretScanning), _) => "secrets", |
| 1221 | (Some(AlertType::CodeScanning), 1) => "code scanning alert", |
| 1222 | (Some(AlertType::CodeScanning), _) => "code scanning alerts", |
| 1223 | (Some(AlertType::Vulnerability), 1) => "vulnerability", |
| 1224 | (Some(AlertType::Vulnerability), _) => "vulnerabilities", |
| 1225 | (None, 1) => "security alert", |
| 1226 | (None, _) => "security alerts", |
| 1227 | } |
| 1228 | } |
| 1229 | |
| 1230 | /// What a scan's item says to those who look after the repository ("3 new |
| 1231 | /// vulnerabilities in acme/rocket: 1 critical, 2 high"), and to whoever |
| 1232 | /// pushed a push that was refused. |
| 1233 | pub fn summary_titles(repo: &str, summary: &SecuritySummary) -> (String, String) { |
| 1234 | let n = summary.opened_count; |
| 1235 | let counts = breakdown(&summary.new_by_severity); |
| 1236 | let title = if counts.is_empty() { |
| 1237 | format!("{n} new {} in {repo}", alerts_called(&summary.alert_type, n)) |
| 1238 | } else { |
| 1239 | format!("{n} new {} in {repo}: {counts}", alerts_called(&summary.alert_type, n)) |
| 1240 | }; |
| 1241 | let pushed = match summary.blocked { |
| 1242 | 0 | 1 => format!("A push to {repo} was blocked: it adds a secret"), |
| 1243 | n => format!("A push to {repo} was blocked: it adds {n} secrets"), |
| 1244 | }; |
| 1245 | (title, pushed) |
| 1246 | } |
| 1247 | |
| 1248 | /// What a scan that opened nothing makes the thread say: how many alerts |
| 1249 | /// are open now ("2 open vulnerabilities in acme/rocket: 2 high"), or that |
| 1250 | /// none is, with what changed as the line of history. |
| 1251 | pub fn refreshed_text(repo: &str, summary: &SecuritySummary) -> (String, String) { |
| 1252 | let open = summary.open_total(); |
| 1253 | let mut changes = Vec::new(); |
| 1254 | if summary.fixed_count > 0 { |
| 1255 | changes.push(format!("{} fixed", summary.fixed_count)); |
| 1256 | } |
| 1257 | if summary.dismissed_count > 0 { |
| 1258 | changes.push(format!("{} dismissed", summary.dismissed_count)); |
| 1259 | } |
| 1260 | let title = if open == 0 { |
| 1261 | format!("No open {} in {repo}", alerts_called(&summary.alert_type, 2)) |
| 1262 | } else { |
| 1263 | format!("{open} open {} in {repo}: {}", alerts_called(&summary.alert_type, open), breakdown(&summary.open)) |
| 1264 | }; |
| 1265 | (title, changes.join(", ")) |
| 1266 | } |
| 1267 | |
| 1268 | /// Where a scan summary's notice goes for one person. |
| 1269 | #[derive(Clone, Copy, Debug, PartialEq, Eq)] |
| 1270 | pub enum Delivery { |
| 1271 | /// Their inbox, now. |
| 1272 | Now, |
| 1273 | /// Their next security digest. |
| 1274 | Digest, |
| 1275 | /// Nowhere. |
| 1276 | Never, |
| 1277 | } |
| 1278 | |
| 1279 | /// The policy: critical and high alerts, and a refused push, reach the |
| 1280 | /// people the service names (the workspace's owners and security managers, |
| 1281 | /// the pusher) at once whatever they chose, and watchers at once unless |
| 1282 | /// they turned security alerts off. Everything else waits for the person's |
| 1283 | /// digest, or comes at once or never, as they chose. |
| 1284 | pub fn security_delivery(summary: &SecuritySummary, username: &str, settings: &InboxSettings) -> Delivery { |
| 1285 | if summary.urgent() { |
| 1286 | let named = summary.notify.iter().any(|name| name.eq_ignore_ascii_case(username)) |
| 1287 | || summary.pusher.as_deref().is_some_and(|pusher| pusher.eq_ignore_ascii_case(username)); |
| 1288 | return if named || settings.security_alerts { Delivery::Now } else { Delivery::Never }; |
| 1289 | } |
| 1290 | match settings.security_digest { |
| 1291 | DigestCadence::AtOnce => Delivery::Now, |
| 1292 | DigestCadence::Daily | DigestCadence::Weekly => Delivery::Digest, |
| 1293 | DigestCadence::Off => Delivery::Never, |
| 1294 | } |
| 1295 | } |
| 1296 | |
| 1297 | /// Brings every person's thread about a repository's alerts of one type up |
| 1298 | /// to date after a scan that opened nothing: the title says what is open |
| 1299 | /// now, a line of history says what changed, and a thread with nothing |
| 1300 | /// left open is done. Nobody is woken: what was read stays read, and the |
| 1301 | /// thread keeps its place. |
| 1302 | async fn refresh_security_thread(db: &D1Database, thread: &str, repo: &str, summary: &SecuritySummary, event: &Event) -> Result<()> { |
| 1303 | let (title, body) = refreshed_text(repo, summary); |
| 1304 | let now = now_ms(); |
| 1305 | let at = rfc3339(now); |
| 1306 | let settled = i32::from(summary.open_total() == 0); |
| 1307 | db.batch(vec![ |
| 1308 | db.prepare( |
| 1309 | "UPDATE inbox_items SET event_id = ?1, event = ?2, title = ?3, body = ?4, updated_at = ?5, activity = activity + 1, |
| 1310 | done_at = CASE WHEN ?6 = 1 THEN COALESCE(done_at, ?5) ELSE done_at END, |
| 1311 | read_at = CASE WHEN ?6 = 1 THEN COALESCE(read_at, ?5) ELSE read_at END, |
| 1312 | settled_reason = CASE WHEN ?6 = 1 AND done_at IS NULL THEN 'Nothing left open after the latest scan' ELSE settled_reason END, |
| 1313 | settled_by = CASE WHEN ?6 = 1 AND done_at IS NULL THEN NULL ELSE settled_by END |
| 1314 | WHERE thread = ?7 |
| 1315 | AND NOT EXISTS (SELECT 1 FROM inbox_activity a WHERE a.event_id = ?1 AND a.username = inbox_items.username)", |
| 1316 | ) |
| 1317 | .bind(&[ |
| 1318 | event.id.as_str().into(), |
| 1319 | event.kind.as_str().into(), |
| 1320 | title.as_str().into(), |
| 1321 | body.as_str().into(), |
| 1322 | at.as_str().into(), |
| 1323 | settled.into(), |
| 1324 | thread.into(), |
| 1325 | ])?, |
| 1326 | db.prepare( |
| 1327 | "INSERT OR IGNORE INTO inbox_activity (id, item_id, username, event_id, event, reason, severity, title, body, actor, created_at) |
| 1328 | SELECT ?1 || ':' || username, id, username, ?2, ?3, 'security_alert', 'info', ?4, ?5, NULL, ?6 FROM inbox_items WHERE thread = ?7", |
| 1329 | ) |
| 1330 | .bind(&[ |
| 1331 | new_id("ntf", now).into(), |
| 1332 | event.id.as_str().into(), |
| 1333 | event.kind.as_str().into(), |
| 1334 | title.as_str().into(), |
| 1335 | body.as_str().into(), |
| 1336 | event.time.as_str().into(), |
| 1337 | thread.into(), |
| 1338 | ])?, |
| 1339 | ]) |
| 1340 | .await?; |
| 1341 | Ok(()) |
| 1342 | } |
| 1343 | |
| 1344 | /// Where an item is on g1t.sh: a work item's in its workspace, the rest in |
| 1345 | /// their repository. |
| 1346 | pub fn url( |
| 1347 | repo: Option<&str>, |
| 1348 | workspace: Option<&str>, |
| 1349 | subject: Option<SubjectKind>, |
| 1350 | number: Option<u32>, |
| 1351 | run_id: Option<&str>, |
| 1352 | link: Option<&str>, |
| 1353 | ) -> String { |
| 1354 | if let Some(link) = link.filter(|link| link.starts_with('/')) { |
| 1355 | return link.to_owned(); |
| 1356 | } |
| 1357 | if let (Some(SubjectKind::Item), Some(workspace), Some(number)) = (subject, workspace.filter(|slug| !slug.is_empty()), number) { |
| 1358 | return format!("/{workspace}/-/work/{number}"); |
| 1359 | } |
| 1360 | let Some(repo) = repo else { |
| 1361 | return "/inbox".to_owned(); |
| 1362 | }; |
| 1363 | match (subject, number, run_id) { |
| 1364 | (Some(SubjectKind::Pull), Some(number), _) => format!("/{repo}/pull/{number}"), |
| 1365 | (Some(SubjectKind::Run), _, Some(run)) => format!("/{repo}/actions/runs/{run}"), |
| 1366 | (Some(SubjectKind::Deploy), Some(number), _) => format!("/{repo}/pull/{number}"), |
| 1367 | _ => format!("/{repo}"), |
| 1368 | } |
| 1369 | } |
| 1370 | |
| 1371 | // --- Writing --------------------------------------------------------------- |
| 1372 | |
| 1373 | /// The services the inbox reads from as events arrive. |
| 1374 | pub struct Sources<'a> { |
| 1375 | pub work: &'a Fetcher, |
| 1376 | pub repos: &'a Fetcher, |
| 1377 | pub identity: &'a Fetcher, |
| 1378 | /// The notify service, told of each new item for live toasts and pushes; None, nobody is. |
| 1379 | pub notify: Option<&'a Fetcher>, |
| 1380 | } |
| 1381 | |
| 1382 | /// One notice written, and whether it was news (not a redelivery): what |
| 1383 | /// may be emailed. |
| 1384 | struct Written { |
| 1385 | notice: Notice, |
| 1386 | /// The repository its email is checked against: none for a work item |
| 1387 | /// without an origin, which is not emailed. |
| 1388 | repo_id: Option<String>, |
| 1389 | url: String, |
| 1390 | event_id: String, |
| 1391 | /// Its event leaves nothing to do (`CLOSES`): settled once written. |
| 1392 | closing: bool, |
| 1393 | /// Pushed live: not for someone who hears of a work item only by |
| 1394 | /// watching a repository it is linked to other than its origin. |
| 1395 | live: bool, |
| 1396 | /// The thread it is on, which notify keeps with what it replays. |
| 1397 | thread: String, |
| 1398 | } |
| 1399 | |
| 1400 | /// Writes the items a batch from the bus calls for. Never fails the batch: |
| 1401 | /// what cannot be worked out is logged and left. |
| 1402 | pub async fn deliver(db: &D1Database, sources: &Sources<'_>, events: &[Event]) { |
| 1403 | // Everyone who caused one, named in one call: notices and settles say who. |
| 1404 | let names = actor_names(sources, events).await; |
| 1405 | let actor_of = |event: &Event| -> Option<String> { |
| 1406 | match event.actor.as_deref() { |
| 1407 | Some(id) if is_g1t_id(id) => Some(system::USERNAME.to_owned()), |
| 1408 | Some(id) => names.get(id).map(|name| name.to_lowercase()), |
| 1409 | None => None, |
| 1410 | } |
| 1411 | }; |
| 1412 | // Whose items were settled, and on which threads, to tell once at the end. |
| 1413 | let mut settled: HashSet<Settled> = HashSet::new(); |
| 1414 | // What the batch supersedes goes first, so its own notices start afresh. |
| 1415 | let superseded: Vec<Settle> = events.iter().flat_map(|event| settles(event, actor_of(event).as_deref())).collect(); |
| 1416 | match settle(db, &superseded).await { |
| 1417 | Ok(items) => settled.extend(items), |
| 1418 | Err(error) => worker::console_error!("inbox: items not settled: {error}"), |
| 1419 | } |
| 1420 | deliver_events(db, sources, events, &names, &mut settled).await; |
| 1421 | // What is over goes last, after its own notices reached each thread's history. |
| 1422 | let over: Vec<Settle> = events.iter().flat_map(|event| closes(event, actor_of(event).as_deref())).collect(); |
| 1423 | match settle(db, &over).await { |
| 1424 | Ok(items) => settled.extend(items), |
| 1425 | Err(error) => worker::console_error!("inbox: closed threads not settled: {error}"), |
| 1426 | } |
| 1427 | if let Some(notify) = sources.notify { |
| 1428 | let mut threads: HashMap<&str, Vec<String>> = HashMap::new(); |
| 1429 | for item in &settled { |
| 1430 | threads.entry(item.username.as_str()).or_default().push(item.thread.clone()); |
| 1431 | } |
| 1432 | for (username, threads) in threads { |
| 1433 | tell_inbox_settled(db, notify, username, threads).await; |
| 1434 | } |
| 1435 | } |
| 1436 | } |
| 1437 | |
| 1438 | /// The usernames of whoever caused the events that tell, watch or settle |
| 1439 | /// anything, by account id, in one call. g1t is not looked up. |
| 1440 | async fn actor_names(sources: &Sources<'_>, events: &[Event]) -> HashMap<String, String> { |
| 1441 | let ids: Vec<String> = events |
| 1442 | .iter() |
| 1443 | .filter(|event| { |
| 1444 | wants(event).is_some() || event.kind == "repo.created" || !settles(event, None).is_empty() || !closes(event, None).is_empty() |
| 1445 | }) |
| 1446 | .filter_map(|event| event.actor.clone()) |
| 1447 | .filter(|id| !is_g1t_id(id)) |
| 1448 | .collect::<HashSet<_>>() |
| 1449 | .into_iter() |
| 1450 | .collect(); |
| 1451 | if ids.is_empty() { |
| 1452 | return HashMap::new(); |
| 1453 | } |
| 1454 | g1t_kit::call(sources.identity, "usernames", &UsernamesArgs { ids }).await.unwrap_or_else(|error| { |
| 1455 | worker::console_error!("inbox: could not name who acted: {error}"); |
| 1456 | HashMap::new() |
| 1457 | }) |
| 1458 | } |
| 1459 | |
| 1460 | async fn deliver_events(db: &D1Database, sources: &Sources<'_>, events: &[Event], names: &HashMap<String, String>, settled: &mut HashSet<Settled>) { |
| 1461 | // A workspace's own notices, about no repository (workspace_notices). |
| 1462 | for event in events.iter().filter(|event| WORKSPACE_EVENTS.contains(&event.kind.as_str())) { |
| 1463 | if let Err(error) = deliver_workspace(db, event).await { |
| 1464 | worker::console_error!("inbox: {} {} not delivered: {error}", event.kind, event.id); |
| 1465 | } else if let Some(notify) = sources.notify { |
| 1466 | // Notify: the feed tells each person once per event, redelivered or not. |
| 1467 | let (thread, told) = workspace_notices(event, None); |
| 1468 | let link = event.data["link"].as_str().filter(|link| link.starts_with('/')).unwrap_or("/inbox"); |
| 1469 | let live = told |
| 1470 | .iter() |
| 1471 | .map(|notice| (notice.username.clone(), live_notification(&event.id, notice, link, &event.time, Some(&thread)))) |
| 1472 | .collect(); |
| 1473 | tell_live(notify, live).await; |
| 1474 | for notice in &told { |
| 1475 | tell_inbox_count(db, notify, ¬ice.username).await; |
| 1476 | } |
| 1477 | } |
| 1478 | } |
| 1479 | let wanted: Vec<(&Event, Wanted)> = events |
| 1480 | .iter() |
| 1481 | .filter_map(|event| wants(event).map(|wanted| (event, wanted))) |
| 1482 | .collect(); |
| 1483 | let created: Vec<&Event> = events.iter().filter(|event| event.kind == "repo.created").collect(); |
| 1484 | if wanted.is_empty() && created.is_empty() { |
| 1485 | return; |
| 1486 | } |
| 1487 | for event in created { |
| 1488 | if let Err(error) = subscriptions::watch_created(db, event, names).await { |
| 1489 | worker::console_error!("inbox: {} {} not watched: {error}", event.kind, event.id); |
| 1490 | } |
| 1491 | } |
| 1492 | let mut paths: HashMap<String, Option<RepoPath>> = HashMap::new(); |
| 1493 | let mut watchers: HashMap<String, Vec<subscriptions::Watcher>> = HashMap::new(); |
| 1494 | let mut written: Vec<Written> = Vec::new(); |
| 1495 | for (event, wanted) in wanted { |
| 1496 | match deliver_one(db, sources, names, &mut paths, &mut watchers, event, wanted, settled).await { |
| 1497 | Ok(mut news) => written.append(&mut news), |
| 1498 | Err(error) => worker::console_error!("inbox: {} {} not delivered: {error}", event.kind, event.id), |
| 1499 | } |
| 1500 | } |
| 1501 | // Notify: every item that was news, live in the person's tabs |
| 1502 | // (services/notify), but for what is over, which is settled at once: |
| 1503 | // nobody is pushed a notification that is already done. |
| 1504 | if let Some(notify) = sources.notify { |
| 1505 | let live = written |
| 1506 | .iter() |
| 1507 | .filter(|item| !item.closing && item.live) |
| 1508 | .map(|item| { |
| 1509 | let live = live_notification(&item.event_id, &item.notice, &item.url, &rfc3339(now_ms()), Some(&item.thread)); |
| 1510 | (item.notice.username.clone(), live) |
| 1511 | }) |
| 1512 | .collect::<Vec<_>>(); |
| 1513 | tell_live(notify, live).await; |
| 1514 | let people: HashSet<&str> = written.iter().filter(|item| !item.closing).map(|item| item.notice.username.as_str()).collect(); |
| 1515 | for username in people { |
| 1516 | if !settled.iter().any(|item| item.username == username) { |
| 1517 | tell_inbox_count(db, notify, username).await; |
| 1518 | } |
| 1519 | } |
| 1520 | } |
| 1521 | if let Err(error) = email(db, sources.identity, written).await { |
| 1522 | worker::console_error!("inbox: emails not sent: {error}"); |
| 1523 | } |
| 1524 | } |
| 1525 | |
| 1526 | /// Events about a workspace rather than a repository, each naming who to |
| 1527 | /// tell (`notify`), what to say (`title`, `body`) and where it is (`link`): |
| 1528 | /// identity's personal access token approvals. |
| 1529 | /// |
| 1530 | /// | Event | Who | Reason | Severity | |
| 1531 | /// | --- | --- | --- | --- | |
| 1532 | /// | `token.approval_requested` | the workspace's owners | review_requested | warning | |
| 1533 | /// | `token.approval_reviewed` | the token's owner | author | info | |
| 1534 | /// | `workspace_invitation.created` | the person invited | review_requested | warning | |
| 1535 | /// | `workspace_invitation.accepted` | who invited them | author | success | |
| 1536 | /// | `workspace_invitation.declined` | who invited them | author | info | |
| 1537 | /// |
| 1538 | /// An invitation's item for the person invited is done once it is |
| 1539 | /// accepted, declined or revoked (`workspace_invitation.revoked`, which |
| 1540 | /// tells nobody). |
| 1541 | pub const WORKSPACE_EVENTS: [&str; 5] = [ |
| 1542 | "token.approval_requested", |
| 1543 | "token.approval_reviewed", |
| 1544 | "workspace_invitation.created", |
| 1545 | "workspace_invitation.accepted", |
| 1546 | "workspace_invitation.declined", |
| 1547 | ]; |
| 1548 | |
| 1549 | /// Events that close what a workspace invitation asked of its person. |
| 1550 | pub const INVITATION_ANSWERED: [&str; 3] = |
| 1551 | ["workspace_invitation.accepted", "workspace_invitation.declined", "workspace_invitation.revoked"]; |
| 1552 | |
| 1553 | /// The notices a workspace event calls for, and the thread they go to. |
| 1554 | pub fn workspace_notices(event: &Event, actor: Option<&str>) -> (String, Vec<Notice>) { |
| 1555 | let data = &event.data; |
| 1556 | let text = |key: &str| data[key].as_str().unwrap_or_default().to_owned(); |
| 1557 | let (reason, severity) = match event.kind.as_str() { |
| 1558 | "token.approval_requested" | "workspace_invitation.created" => (Reason::ReviewRequested, Severity::Warning), |
| 1559 | "workspace_invitation.accepted" => (Reason::Author, Severity::Success), |
| 1560 | _ => (Reason::Author, Severity::Info), |
| 1561 | }; |
| 1562 | // An invitation names its own thread; a token approval's is the token's. |
| 1563 | let thread = match data["thread"].as_str().filter(|thread| !thread.is_empty()) { |
| 1564 | Some(thread) => thread.to_owned(), |
| 1565 | None => format!("workspace:{}/token/{}", text("workspace"), text("tokenId")), |
| 1566 | }; |
| 1567 | let notices = names(data, "notify") |
| 1568 | .into_iter() |
| 1569 | .map(|name| name.to_lowercase()) |
| 1570 | .filter(|name| actor.is_none_or(|actor| !actor.eq_ignore_ascii_case(name)) && !is_g1t(name)) |
| 1571 | .collect::<HashSet<_>>() |
| 1572 | .into_iter() |
| 1573 | .map(|username| Notice { username, reason, severity, title: text("title"), body: text("body") }) |
| 1574 | .collect(); |
| 1575 | (thread, notices) |
| 1576 | } |
| 1577 | |
| 1578 | /// Writes a workspace event's notices: a thread each, with no repository. |
| 1579 | async fn deliver_workspace(db: &D1Database, event: &Event) -> Result<()> { |
| 1580 | let (thread, told) = workspace_notices(event, None); |
| 1581 | if told.is_empty() { |
| 1582 | return Ok(()); |
| 1583 | } |
| 1584 | let now = now_ms(); |
| 1585 | let workspace = event.data["workspace"].as_str().unwrap_or_default().to_lowercase(); |
| 1586 | let link = event.data["link"].as_str().filter(|link| link.starts_with('/')); |
| 1587 | let mut statements = Vec::new(); |
| 1588 | for notice in &told { |
| 1589 | let username = notice.username.as_str(); |
| 1590 | statements.push(db.prepare(BUMP).bind(&[ |
| 1591 | new_id("ntf", now).into(), |
| 1592 | username.into(), |
| 1593 | thread.as_str().into(), |
| 1594 | event.id.as_str().into(), |
| 1595 | event.kind.as_str().into(), |
| 1596 | notice.reason.as_str().into(), |
| 1597 | notice.severity.as_str().into(), |
| 1598 | notice.title.as_str().into(), |
| 1599 | notice.body.as_str().into(), |
| 1600 | workspace.as_str().into(), |
| 1601 | JsValue::NULL, |
| 1602 | JsValue::NULL, |
| 1603 | JsValue::NULL, |
| 1604 | JsValue::NULL, |
| 1605 | JsValue::NULL, |
| 1606 | link.map_or(JsValue::NULL, JsValue::from), |
| 1607 | JsValue::NULL, |
| 1608 | event.time.as_str().into(), |
| 1609 | new_id("ntf", now).into(), |
| 1610 | ])?); |
| 1611 | statements.push( |
| 1612 | db.prepare( |
| 1613 | "INSERT OR IGNORE INTO inbox_activity (id, item_id, username, event_id, event, reason, severity, title, body, actor, created_at) |
| 1614 | SELECT ?1, id, ?2, ?4, ?5, ?6, ?7, ?8, ?9, NULL, ?10 FROM inbox_items WHERE username = ?2 AND thread = ?3", |
| 1615 | ) |
| 1616 | .bind(&[ |
| 1617 | new_id("ntf", now).into(), |
| 1618 | username.into(), |
| 1619 | thread.as_str().into(), |
| 1620 | event.id.as_str().into(), |
| 1621 | event.kind.as_str().into(), |
| 1622 | notice.reason.as_str().into(), |
| 1623 | notice.severity.as_str().into(), |
| 1624 | notice.title.as_str().into(), |
| 1625 | notice.body.as_str().into(), |
| 1626 | event.time.as_str().into(), |
| 1627 | ])?, |
| 1628 | ); |
| 1629 | } |
| 1630 | db.batch(statements).await?; |
| 1631 | Ok(()) |
| 1632 | } |
| 1633 | |
| 1634 | /// Settles items (see [`settles`]), in one batch. Returns the items it |
| 1635 | /// settled, by person and thread, so their counts can be told again and |
| 1636 | /// notify can stop replaying them. |
| 1637 | async fn settle(db: &D1Database, settled: &[Settle]) -> Result<HashSet<Settled>> { |
| 1638 | if settled.is_empty() { |
| 1639 | return Ok(HashSet::new()); |
| 1640 | } |
| 1641 | let now = rfc3339(now_ms()); |
| 1642 | let statements = settled.iter().map(|settle| settle.statement(db, &now)).collect::<Result<Vec<_>>>()?; |
| 1643 | let mut items = HashSet::new(); |
| 1644 | for result in db.batch(statements).await? { |
| 1645 | items.extend(result.results::<Settled>()?); |
| 1646 | } |
| 1647 | Ok(items) |
| 1648 | } |
| 1649 | |
| 1650 | #[allow(clippy::too_many_arguments)] |
| 1651 | async fn deliver_one( |
| 1652 | db: &D1Database, |
| 1653 | sources: &Sources<'_>, |
| 1654 | names: &HashMap<String, String>, |
| 1655 | paths: &mut HashMap<String, Option<RepoPath>>, |
| 1656 | watchers: &mut HashMap<String, Vec<subscriptions::Watcher>>, |
| 1657 | event: &Event, |
| 1658 | wanted: Wanted, |
| 1659 | settled: &mut HashSet<Settled>, |
| 1660 | ) -> Result<Vec<Written>> { |
| 1661 | if let Some(repo_id) = &wanted.repo_id |
| 1662 | && !paths.contains_key(repo_id) |
| 1663 | { |
| 1664 | let path: Option<RepoPath> = g1t_kit::call(sources.repos, "path_by_id", &PathByIdArgs { id: repo_id.clone() }).await?; |
| 1665 | paths.insert(repo_id.clone(), path); |
| 1666 | } |
| 1667 | let path = wanted.repo_id.as_ref().and_then(|repo_id| paths.get(repo_id).cloned().flatten()); |
| 1668 | // A repository that is gone tells nobody; a work item stays in its |
| 1669 | // workspace when its origin goes. |
| 1670 | if path.is_none() && wanted.item.is_none() { |
| 1671 | return Ok(Vec::new()); |
| 1672 | } |
| 1673 | let subject: Option<InboxSubject> = match wanted.number { |
| 1674 | Some(number) => { |
| 1675 | let found: Option<InboxSubject> = g1t_kit::call( |
| 1676 | sources.work, |
| 1677 | "inbox_subject", |
| 1678 | &InboxSubjectArgs { |
| 1679 | repo_id: wanted.repo_id.clone(), |
| 1680 | number, |
| 1681 | item_id: wanted.item.as_ref().map(|item| item.id.clone()), |
| 1682 | comment_id: wanted.comment_id.clone(), |
| 1683 | }, |
| 1684 | ) |
| 1685 | .await?; |
| 1686 | if found.is_none() { |
| 1687 | return Ok(Vec::new()); |
| 1688 | } |
| 1689 | found |
| 1690 | } |
| 1691 | None => None, |
| 1692 | }; |
| 1693 | let actor = Actor { |
| 1694 | id: event.actor.clone(), |
| 1695 | username: match event.actor.as_deref() { |
| 1696 | Some(id) if is_g1t_id(id) => Some(system::USERNAME.to_owned()), |
| 1697 | Some(id) => names.get(id).map(|name| name.to_lowercase()), |
| 1698 | None => None, |
| 1699 | }, |
| 1700 | }; |
| 1701 | let thread = thread_of(event, &wanted, subject.as_ref()); |
| 1702 | // Whoever commented has answered what was on the thread for them. |
| 1703 | if let Some(handled) = handled_by(event, subject.as_ref()) { |
| 1704 | settled.extend(settle(db, &[handled]).await?); |
| 1705 | } |
| 1706 | // Who watches it: its repository's watchers, or a work item's linked |
| 1707 | // repositories', its origin's first. |
| 1708 | let linked: Vec<&str> = wanted.item.as_ref().map_or_else(Vec::new, |item| { |
| 1709 | item.repo_ids |
| 1710 | .iter() |
| 1711 | .map(String::as_str) |
| 1712 | .filter(|id| wanted.repo_id.as_deref() != Some(*id)) |
| 1713 | .collect() |
| 1714 | }); |
| 1715 | for repo_id in wanted.repo_id.iter().map(String::as_str).chain(linked.iter().copied()) { |
| 1716 | if !watchers.contains_key(repo_id) { |
| 1717 | watchers.insert(repo_id.to_owned(), subscriptions::watchers(db, repo_id).await?); |
| 1718 | } |
| 1719 | } |
| 1720 | let own = wanted.repo_id.as_ref().and_then(|id| watchers.get(id)).cloned().unwrap_or_default(); |
| 1721 | let others: Vec<Vec<subscriptions::Watcher>> = linked.iter().map(|id| watchers.get(*id).cloned().unwrap_or_default()).collect(); |
| 1722 | let (watching, elsewhere) = subscriptions::linked_watchers(own, &others); |
| 1723 | let audience = Audience { |
| 1724 | subscriptions: match thread.kind { |
| 1725 | Some(SubjectKind::Item | SubjectKind::Pull) => subscriptions::of_thread(db, &thread.key).await?, |
| 1726 | _ => Vec::new(), |
| 1727 | }, |
| 1728 | watchers: watching, |
| 1729 | }; |
| 1730 | let repo = path.as_ref().map(|path| format!("{}/{}", path.namespace, path.name).to_lowercase()); |
| 1731 | // Where titles say it is: a work item's workspace, else the repository. |
| 1732 | let workspace = match &wanted.item { |
| 1733 | Some(item) => item.workspace.clone(), |
| 1734 | None => path.as_ref().map(|path| path.namespace.to_lowercase()).unwrap_or_default(), |
| 1735 | }; |
| 1736 | let place = match &wanted.item { |
| 1737 | Some(item) => item.workspace.clone(), |
| 1738 | None => repo.clone().unwrap_or_default(), |
| 1739 | }; |
| 1740 | let mut told = notices(event, &place, &actor, subject.as_ref(), &audience); |
| 1741 | let mut statements = |
| 1742 | subscriptions::auto_subscribe(db, &thread.key, wanted.repo_id.as_deref(), &subscribes(event, subject.as_ref()), &event.time)?; |
| 1743 | // A scan's summary: one that opened nothing brings the thread up to date |
| 1744 | // without waking anyone, and what is not urgent waits for each person's |
| 1745 | // digest, or comes at once or never, as they chose (security_delivery). |
| 1746 | if let (Some(summary), Some(path)) = (security_summary(event), &path) { |
| 1747 | if summary.opened_count == 0 { |
| 1748 | refresh_security_thread(db, &thread.key, &place, &summary, event).await?; |
| 1749 | return Ok(Vec::new()); |
| 1750 | } |
| 1751 | let people: Vec<String> = told.iter().map(|notice| notice.username.clone()).collect(); |
| 1752 | let settings = subscriptions::settings_of(db, &people).await?; |
| 1753 | let now = now_ms(); |
| 1754 | let mut kept = Vec::with_capacity(told.len()); |
| 1755 | for notice in told { |
| 1756 | let setting = settings.get(¬ice.username).cloned().unwrap_or_default(); |
| 1757 | match security_delivery(&summary, ¬ice.username, &setting) { |
| 1758 | Delivery::Now => kept.push(notice), |
| 1759 | Delivery::Digest => statements.push(crate::security_digest::queue(db, ¬ice.username, path, &summary, &event.id, now)?), |
| 1760 | Delivery::Never => {} |
| 1761 | } |
| 1762 | } |
| 1763 | told = kept; |
| 1764 | } |
| 1765 | if told.is_empty() { |
| 1766 | if !statements.is_empty() { |
| 1767 | db.batch(statements).await?; |
| 1768 | } |
| 1769 | return Ok(Vec::new()); |
| 1770 | } |
| 1771 | let now = now_ms(); |
| 1772 | let link = thread.link.as_deref(); |
| 1773 | let item_url = url(repo.as_deref(), Some(&workspace), thread.kind, thread.number, thread.run_id.as_deref(), link); |
| 1774 | // Three statements a notice: its thread brought up (unless this event |
| 1775 | // was told before), a line of history, and the history kept short. |
| 1776 | let first = statements.len(); |
| 1777 | for notice in &told { |
| 1778 | let username = notice.username.as_str(); |
| 1779 | let values: Vec<JsValue> = vec![ |
| 1780 | new_id("ntf", now).into(), |
| 1781 | username.into(), |
| 1782 | thread.key.as_str().into(), |
| 1783 | event.id.as_str().into(), |
| 1784 | event.kind.as_str().into(), |
| 1785 | notice.reason.as_str().into(), |
| 1786 | notice.severity.as_str().into(), |
| 1787 | notice.title.as_str().into(), |
| 1788 | notice.body.as_str().into(), |
| 1789 | workspace.as_str().into(), |
| 1790 | wanted.repo_id.as_deref().map_or(JsValue::NULL, JsValue::from), |
| 1791 | repo.as_deref().map_or(JsValue::NULL, JsValue::from), |
| 1792 | thread.kind.map_or(JsValue::NULL, |kind| kind.as_str().into()), |
| 1793 | thread.number.map_or(JsValue::NULL, JsValue::from), |
| 1794 | thread.run_id.as_deref().map_or(JsValue::NULL, JsValue::from), |
| 1795 | link.map_or(JsValue::NULL, JsValue::from), |
| 1796 | actor.username.as_deref().map_or(JsValue::NULL, JsValue::from), |
| 1797 | event.time.as_str().into(), |
| 1798 | // Same prefix as item ids, so old and new sort by time together. |
| 1799 | new_id("ntf", now).into(), |
| 1800 | ]; |
| 1801 | statements.push(db.prepare(BUMP).bind(&values)?); |
| 1802 | statements.push( |
| 1803 | db.prepare( |
| 1804 | "INSERT OR IGNORE INTO inbox_activity (id, item_id, username, event_id, event, reason, severity, title, body, actor, created_at) |
| 1805 | SELECT ?1, id, ?2, ?4, ?5, ?6, ?7, ?8, ?9, ?10, ?11 FROM inbox_items WHERE username = ?2 AND thread = ?3 |
| 1806 | RETURNING username", |
| 1807 | ) |
| 1808 | .bind(&[ |
| 1809 | new_id("ntf", now).into(), |
| 1810 | username.into(), |
| 1811 | thread.key.as_str().into(), |
| 1812 | event.id.as_str().into(), |
| 1813 | event.kind.as_str().into(), |
| 1814 | notice.reason.as_str().into(), |
| 1815 | notice.severity.as_str().into(), |
| 1816 | notice.title.as_str().into(), |
| 1817 | notice.body.as_str().into(), |
| 1818 | actor.username.as_deref().map_or(JsValue::NULL, JsValue::from), |
| 1819 | event.time.as_str().into(), |
| 1820 | ])?, |
| 1821 | ); |
| 1822 | statements.push( |
| 1823 | db.prepare( |
| 1824 | "DELETE FROM inbox_activity |
| 1825 | WHERE item_id = (SELECT id FROM inbox_items WHERE username = ?1 AND thread = ?2) |
| 1826 | AND id NOT IN ( |
| 1827 | SELECT a.id FROM inbox_activity a |
| 1828 | WHERE a.item_id = (SELECT id FROM inbox_items WHERE username = ?1 AND thread = ?2) |
| 1829 | ORDER BY a.id DESC LIMIT ?3)", |
| 1830 | ) |
| 1831 | .bind(&[username.into(), thread.key.as_str().into(), MAX_ACTIVITY.into()])?, |
| 1832 | ); |
| 1833 | } |
| 1834 | let results = db.batch(statements).await?; |
| 1835 | #[derive(Deserialize)] |
| 1836 | struct Told { |
| 1837 | username: String, |
| 1838 | } |
| 1839 | // A line of history written means the event is news to that person. |
| 1840 | let mut news = HashSet::new(); |
| 1841 | for (at, _) in told.iter().enumerate() { |
| 1842 | if let Some(result) = results.get(first + at * 3 + 1) |
| 1843 | && let Ok(rows) = result.results::<Told>() |
| 1844 | { |
| 1845 | news.extend(rows.into_iter().map(|row| row.username)); |
| 1846 | } |
| 1847 | } |
| 1848 | Ok(told |
| 1849 | .into_iter() |
| 1850 | .filter(|notice| news.contains(¬ice.username)) |
| 1851 | .map(|notice| Written { |
| 1852 | live: !(notice.reason == Reason::Subscribed && elsewhere.contains(¬ice.username)), |
| 1853 | notice, |
| 1854 | repo_id: wanted.repo_id.clone(), |
| 1855 | url: item_url.clone(), |
| 1856 | event_id: event.id.clone(), |
| 1857 | closing: CLOSES.contains(&event.kind.as_str()), |
| 1858 | thread: thread.key.clone(), |
| 1859 | }) |
| 1860 | .collect()) |
| 1861 | } |
| 1862 | |
| 1863 | /// Brings a person's thread up with new activity, or starts it. `?1` id, |
| 1864 | /// `?2` username, `?3` thread, `?4` event id, `?5` event type, `?6` reason, |
| 1865 | /// `?7` severity, `?8` title, `?9` body, `?10` workspace, `?11` repo id, |
| 1866 | /// `?12` repo, `?13` subject, `?14` number, `?15` run id, `?16` link, `?17` |
| 1867 | /// actor, `?18` time, `?19` the time-sortable id lists order by. Nothing |
| 1868 | /// happens when the person was already told of this event. While the |
| 1869 | /// thread is unread its most urgent severity is kept; done or not, it |
| 1870 | /// comes back to the inbox. A snooze stands. |
| 1871 | pub(crate) const BUMP: &str = "INSERT INTO inbox_items (id, username, thread, event_id, event, reason, severity, title, body, |
| 1872 | workspace, repo_id, repo, subject, number, run_id, link, actor, created_at, updated_at, bumped, activity) |
| 1873 | SELECT ?1, ?2, ?3, ?4, ?5, ?6, ?7, ?8, ?9, ?10, ?11, ?12, ?13, ?14, ?15, ?16, ?17, ?18, ?18, ?19, 1 |
| 1874 | WHERE NOT EXISTS (SELECT 1 FROM inbox_activity WHERE event_id = ?4 AND username = ?2) |
| 1875 | ON CONFLICT (username, thread) DO UPDATE SET |
| 1876 | event_id = excluded.event_id, |
| 1877 | event = excluded.event, |
| 1878 | reason = excluded.reason, |
| 1879 | severity = CASE |
| 1880 | WHEN inbox_items.read_at IS NULL AND inbox_items.done_at IS NULL |
| 1881 | AND (CASE inbox_items.severity WHEN 'warning' THEN 0 WHEN 'error' THEN 1 WHEN 'success' THEN 2 ELSE 3 END) |
| 1882 | < (CASE excluded.severity WHEN 'warning' THEN 0 WHEN 'error' THEN 1 WHEN 'success' THEN 2 ELSE 3 END) |
| 1883 | THEN inbox_items.severity ELSE excluded.severity END, |
| 1884 | title = excluded.title, |
| 1885 | body = excluded.body, |
| 1886 | workspace = excluded.workspace, |
| 1887 | repo = excluded.repo, |
| 1888 | subject = COALESCE(excluded.subject, inbox_items.subject), |
| 1889 | number = COALESCE(excluded.number, inbox_items.number), |
| 1890 | run_id = COALESCE(excluded.run_id, inbox_items.run_id), |
| 1891 | link = COALESCE(excluded.link, inbox_items.link), |
| 1892 | actor = excluded.actor, |
| 1893 | updated_at = excluded.updated_at, |
| 1894 | bumped = excluded.bumped, |
| 1895 | activity = inbox_items.activity + 1, |
| 1896 | read_at = NULL, |
| 1897 | done_at = NULL, |
| 1898 | settled_reason = NULL, |
| 1899 | settled_by = NULL"; |
| 1900 | |
| 1901 | /// What the notify service is told of an inbox item (`FeedNotification` in |
| 1902 | /// @g1t/contracts): its kind from why the person was told, the workspace |
| 1903 | /// from where it links, and the item's title and first line. |
| 1904 | pub fn live_notification(event_id: &str, notice: &Notice, url: &str, at: &str, thread: Option<&str>) -> serde_json::Value { |
| 1905 | let kind = match notice.reason { |
| 1906 | Reason::ReviewRequested => "approval", |
| 1907 | Reason::Mention | Reason::TeamMention => "mention", |
| 1908 | // A critical or high alert, a refused push, a report or a bypass to |
| 1909 | // review: toasted like a mention. A digest, or what came at once by |
| 1910 | // choice, is an ordinary inbox item. |
| 1911 | Reason::SecurityAlert if notice.severity != Severity::Info => "security", |
| 1912 | _ => "inbox", |
| 1913 | }; |
| 1914 | let path = url.split(['?', '#']).next().unwrap_or_default(); |
| 1915 | let mut segments = path.trim_start_matches('/').split('/'); |
| 1916 | let workspace = segments.next().unwrap_or_default().to_lowercase(); |
| 1917 | let repo = segments.next().map(|name| format!("{workspace}/{name}")); |
| 1918 | let name = repo.unwrap_or_else(|| if workspace.is_empty() { "g1t".to_owned() } else { workspace.clone() }); |
| 1919 | serde_json::json!({ |
| 1920 | "id": format!("inbox:{event_id}"), |
| 1921 | "kind": kind, |
| 1922 | "workspace": workspace, |
| 1923 | "title": notice.title, |
| 1924 | "body": clip(¬ice.body, 140), |
| 1925 | "href": if url.starts_with('/') { url } else { "/inbox" }, |
| 1926 | "actor": { "kind": "system", "id": name, "name": name }, |
| 1927 | "inbox_thread": thread, |
| 1928 | "created_at": at, |
| 1929 | }) |
| 1930 | } |
| 1931 | |
| 1932 | /// What the notify service is told when a person's inbox count changes |
| 1933 | /// (its `set_inbox`): the count as it now is, never a difference, so a |
| 1934 | /// call repeated or out of order still ends right. |
| 1935 | pub fn inbox_count_update(username: &str, unread: u32) -> serde_json::Value { |
| 1936 | serde_json::json!({ "username": username.to_lowercase(), "unread": unread }) |
| 1937 | } |
| 1938 | |
| 1939 | /// What the notify service is told when some of a person's items settled |
| 1940 | /// (its `set_inbox` with `settled`): the count as it now is, and the |
| 1941 | /// threads that settled, whose notifications it then stops replaying to |
| 1942 | /// tabs that open later and drops from open tabs' lists. |
| 1943 | pub fn inbox_settled_update(username: &str, unread: u32, threads: &[String]) -> serde_json::Value { |
| 1944 | let mut threads: Vec<&str> = threads.iter().map(String::as_str).collect(); |
| 1945 | threads.sort_unstable(); |
| 1946 | threads.dedup(); |
| 1947 | serde_json::json!({ "username": username.to_lowercase(), "unread": unread, "settled": threads }) |
| 1948 | } |
| 1949 | |
| 1950 | /// Tells the notify service a person's unread count as it now is, so every |
| 1951 | /// tab of theirs shows it at once: after items arrive, and after marks made |
| 1952 | /// anywhere (the site, the API, MCP). Logged and left when it fails. |
| 1953 | pub async fn tell_inbox_count(db: &D1Database, notify: &Fetcher, username: &str) { |
| 1954 | let counted = counts(db, InboxCountsArgs { username: username.to_owned() }).await; |
| 1955 | let told: Result<serde_json::Value> = match counted { |
| 1956 | Ok(counts) => g1t_kit::call(notify, "set_inbox", &inbox_count_update(username, counts.unread)).await, |
| 1957 | Err(error) => Err(error), |
| 1958 | }; |
| 1959 | if let Err(error) = told { |
| 1960 | worker::console_error!("inbox: live count not sent: {error}"); |
| 1961 | } |
| 1962 | } |
| 1963 | |
| 1964 | /// Tells the notify service a person's count after items of theirs |
| 1965 | /// settled, with the threads that did. Logged and left when it fails. |
| 1966 | pub async fn tell_inbox_settled(db: &D1Database, notify: &Fetcher, username: &str, threads: Vec<String>) { |
| 1967 | let counted = counts(db, InboxCountsArgs { username: username.to_owned() }).await; |
| 1968 | let told: Result<serde_json::Value> = match counted { |
| 1969 | Ok(counts) => g1t_kit::call(notify, "set_inbox", &inbox_settled_update(username, counts.unread, &threads)).await, |
| 1970 | Err(error) => Err(error), |
| 1971 | }; |
| 1972 | if let Err(error) = told { |
| 1973 | worker::console_error!("inbox: settled items not told: {error}"); |
| 1974 | } |
| 1975 | } |
| 1976 | |
| 1977 | /// Hands items to the notify service, one call each. Logged and left when it |
| 1978 | /// cannot be reached: the inbox and email do not wait on it. |
| 1979 | pub(crate) async fn tell_live(notify: &Fetcher, items: Vec<(String, serde_json::Value)>) { |
| 1980 | #[derive(serde::Serialize)] |
| 1981 | struct NotifyArgs { |
| 1982 | username: String, |
| 1983 | notification: serde_json::Value, |
| 1984 | } |
| 1985 | for (username, notification) in items { |
| 1986 | let told: Result<serde_json::Value> = g1t_kit::call(notify, "notify", &NotifyArgs { username, notification }).await; |
| 1987 | if let Err(error) = told { |
| 1988 | worker::console_error!("inbox: live notification not sent: {error}"); |
| 1989 | } |
| 1990 | } |
| 1991 | } |
| 1992 | |
| 1993 | /// Emails what was news to people who asked to be emailed for its reason. |
| 1994 | /// Identity sends each, only to a confirmed address and only if the person |
| 1995 | /// can still read the repository (a work item's origin; one without is |
| 1996 | /// not emailed). |
| 1997 | async fn email(db: &D1Database, identity: &Fetcher, written: Vec<Written>) -> Result<()> { |
| 1998 | let written: Vec<Written> = written.into_iter().filter(|item| item.repo_id.is_some()).collect(); |
| 1999 | if written.is_empty() { |
| 2000 | return Ok(()); |
| 2001 | } |
| 2002 | let people: Vec<String> = written |
| 2003 | .iter() |
| 2004 | .map(|item| item.notice.username.clone()) |
| 2005 | .collect::<HashSet<_>>() |
| 2006 | .into_iter() |
| 2007 | .collect(); |
| 2008 | let settings = subscriptions::settings_of(db, &people).await?; |
| 2009 | for item in written { |
| 2010 | let wants = settings.get(&item.notice.username).map_or(&DEFAULT_EMAIL[..], |settings| &settings.email[..]); |
| 2011 | if !wants.contains(&item.notice.reason) { |
| 2012 | continue; |
| 2013 | } |
| 2014 | let sent: Result<bool> = g1t_kit::call( |
| 2015 | identity, |
| 2016 | "notify_by_email", |
| 2017 | &NotifyByEmailArgs { |
| 2018 | username: item.notice.username.clone(), |
| 2019 | repo_id: item.repo_id.clone().unwrap_or_default(), |
| 2020 | subject: item.notice.title.clone(), |
| 2021 | intro: item.notice.body.clone(), |
| 2022 | quote: None, |
| 2023 | path: item.url.clone(), |
| 2024 | reason: item.notice.reason, |
| 2025 | }, |
| 2026 | ) |
| 2027 | .await; |
| 2028 | if let Err(error) = sent { |
| 2029 | worker::console_error!("inbox: email to {} not sent: {error}", item.notice.username); |
| 2030 | } |
| 2031 | } |
| 2032 | Ok(()) |
| 2033 | } |
| 2034 | |
| 2035 | // --- Reading and changing ---------------------------------------------------- |
| 2036 | |
| 2037 | #[derive(Deserialize)] |
| 2038 | pub(crate) struct Row { |
| 2039 | pub(crate) id: String, |
| 2040 | #[serde(default)] |
| 2041 | thread: Option<String>, |
| 2042 | reason: String, |
| 2043 | severity: String, |
| 2044 | title: String, |
| 2045 | body: String, |
| 2046 | event: Option<String>, |
| 2047 | workspace: Option<String>, |
| 2048 | pub(crate) repo_id: Option<String>, |
| 2049 | repo: Option<String>, |
| 2050 | subject: Option<String>, |
| 2051 | number: Option<f64>, |
| 2052 | run_id: Option<String>, |
| 2053 | link: Option<String>, |
| 2054 | actor: Option<String>, |
| 2055 | activity: Option<f64>, |
| 2056 | created_at: String, |
| 2057 | updated_at: Option<String>, |
| 2058 | read_at: Option<String>, |
| 2059 | done_at: Option<String>, |
| 2060 | saved: f64, |
| 2061 | snoozed_until: Option<String>, |
| 2062 | bumped: Option<String>, |
| 2063 | settled_reason: Option<String>, |
| 2064 | settled_by: Option<String>, |
| 2065 | } |
| 2066 | |
| 2067 | impl Row { |
| 2068 | pub(crate) fn into_item(self) -> InboxItem { |
| 2069 | let subject = self.subject.as_deref().and_then(SubjectKind::parse); |
| 2070 | let number = self.number.map(|n| n as u32); |
| 2071 | // A work item whose thread still has its issue's number, until the |
| 2072 | // work service's numbers arrive (work_items.rs): the old link, |
| 2073 | // which leads to it. |
| 2074 | let legacy = subject == Some(SubjectKind::Item) && self.thread.as_deref().is_some_and(|thread| !thread.starts_with(ITEM_THREAD)); |
| 2075 | let link = match (legacy, &self.repo, number) { |
| 2076 | (true, Some(repo), Some(number)) => Some(format!("/{repo}/issues/{number}")), |
| 2077 | _ => self.link.clone(), |
| 2078 | }; |
| 2079 | InboxItem { |
| 2080 | url: url(self.repo.as_deref(), self.workspace.as_deref(), subject, number, self.run_id.as_deref(), link.as_deref()), |
| 2081 | id: self.id, |
| 2082 | reason: Reason::parse(&self.reason).unwrap_or(Reason::Subscribed), |
| 2083 | severity: Severity::parse(&self.severity).unwrap_or(Severity::Info), |
| 2084 | title: self.title, |
| 2085 | body: self.body, |
| 2086 | event: self.event, |
| 2087 | repo: self.repo, |
| 2088 | workspace: self.workspace, |
| 2089 | subject, |
| 2090 | number, |
| 2091 | actor: self.actor, |
| 2092 | count: self.activity.map_or(1, |n| n as u32), |
| 2093 | updated_at: self.updated_at.unwrap_or_else(|| self.created_at.clone()), |
| 2094 | created_at: self.created_at, |
| 2095 | read_at: self.read_at, |
| 2096 | done_at: self.done_at, |
| 2097 | saved: self.saved != 0.0, |
| 2098 | snoozed_until: self.snoozed_until, |
| 2099 | settled_reason: self.settled_reason, |
| 2100 | settled_by: self.settled_by, |
| 2101 | } |
| 2102 | } |
| 2103 | } |
| 2104 | |
| 2105 | pub(crate) const COLUMNS: &str = "id, thread, reason, severity, title, body, event, workspace, repo_id, repo, subject, number, run_id, |
| 2106 | link, actor, activity, created_at, updated_at, read_at, done_at, saved, snoozed_until, bumped, |
| 2107 | settled_reason, settled_by"; |
| 2108 | |
| 2109 | /// The conditions that pick a view's items, after `username = ?1`; `?2` is now. |
| 2110 | fn view_filter(view: InboxView) -> &'static str { |
| 2111 | match view { |
| 2112 | InboxView::Inbox => "done_at IS NULL AND (snoozed_until IS NULL OR snoozed_until <= ?2)", |
| 2113 | InboxView::Saved => "saved = 1", |
| 2114 | InboxView::Done => "done_at IS NOT NULL", |
| 2115 | } |
| 2116 | } |
| 2117 | |
| 2118 | /// Whether a list ranks unread warnings first: the inbox itself, unfiltered. |
| 2119 | fn ranked(a: &ListInboxArgs) -> bool { |
| 2120 | a.view == InboxView::Inbox |
| 2121 | && a.severity.is_none() |
| 2122 | && a.reason.is_none() |
| 2123 | && !a.participating |
| 2124 | && a.repo_id.is_none() |
| 2125 | && !a.unread |
| 2126 | && a.since.is_none() |
| 2127 | && a.updated_before.is_none() |
| 2128 | } |
| 2129 | |
| 2130 | /// The conditions a list's filters add, and the values they bind, numbered |
| 2131 | /// after the `bound` values already given. |
| 2132 | fn filters(a: &ListInboxArgs, bound: usize) -> (Vec<String>, Vec<String>) { |
| 2133 | let mut conditions = Vec::new(); |
| 2134 | let mut values: Vec<String> = Vec::new(); |
| 2135 | let mut bind = |value: &str, condition: &str| { |
| 2136 | values.push(value.to_owned()); |
| 2137 | conditions.push(condition.replace('?', &format!("?{}", bound + values.len()))); |
| 2138 | }; |
| 2139 | if let Some(severity) = a.severity { |
| 2140 | bind(severity.as_str(), "severity = ?"); |
| 2141 | } |
| 2142 | if let Some(reason) = a.reason { |
| 2143 | bind(reason.as_str(), "reason = ?"); |
| 2144 | } |
| 2145 | if let Some(repo_id) = &a.repo_id { |
| 2146 | bind(repo_id, "repo_id = ?"); |
| 2147 | } |
| 2148 | if let Some(since) = &a.since { |
| 2149 | bind(since.trim(), "COALESCE(updated_at, created_at) >= ?"); |
| 2150 | } |
| 2151 | if let Some(before) = &a.updated_before { |
| 2152 | bind(before.trim(), "COALESCE(updated_at, created_at) < ?"); |
| 2153 | } |
| 2154 | if a.participating { |
| 2155 | conditions.push("reason NOT IN ('manual', 'subscribed')".to_owned()); |
| 2156 | } |
| 2157 | if a.unread { |
| 2158 | conditions.push("read_at IS NULL".to_owned()); |
| 2159 | } |
| 2160 | (conditions, values) |
| 2161 | } |
| 2162 | |
| 2163 | pub async fn list(db: &D1Database, repos: &Fetcher, a: ListInboxArgs) -> Result<InboxPage> { |
| 2164 | let Some(viewer) = &a.viewer else { |
| 2165 | return Ok(InboxPage::default()); |
| 2166 | }; |
| 2167 | let username = viewer.username.to_lowercase(); |
| 2168 | let now = rfc3339(now_ms()); |
| 2169 | let limit = a.limit.unwrap_or(DEFAULT_INBOX_PAGE).clamp(1, MAX_INBOX_PAGE); |
| 2170 | let mut values: Vec<JsValue> = vec![username.as_str().into(), now.as_str().into()]; |
| 2171 | let mut conditions = vec!["username = ?1".to_owned(), view_filter(a.view).to_owned()]; |
| 2172 | let (filtered, bound) = filters(&a, values.len()); |
| 2173 | conditions.extend(filtered); |
| 2174 | values.extend(bound.iter().map(|value| JsValue::from(value.as_str()))); |
| 2175 | let ranked = ranked(&a); |
| 2176 | // Unread warnings lead the first page, and are left out of the rest. |
| 2177 | let leading = "severity = 'warning' AND read_at IS NULL"; |
| 2178 | let mut rest = conditions.clone(); |
| 2179 | let mut rest_values = values.clone(); |
| 2180 | if ranked { |
| 2181 | rest.push(format!("NOT ({leading})")); |
| 2182 | } |
| 2183 | if let Some(before) = &a.before { |
| 2184 | rest_values.push(before.as_str().into()); |
| 2185 | rest.push(format!("bumped < ?{}", rest_values.len())); |
| 2186 | } |
| 2187 | rest_values.push((limit + 1).into()); |
| 2188 | let order = if a.view == InboxView::Done { "done_at DESC, bumped DESC" } else { "bumped DESC" }; |
| 2189 | let mut statements = vec![ |
| 2190 | db.prepare(format!( |
| 2191 | "SELECT {COLUMNS} FROM inbox_items WHERE {} ORDER BY {order} LIMIT ?{}", |
| 2192 | rest.join(" AND "), |
| 2193 | rest_values.len() |
| 2194 | )) |
| 2195 | .bind(&rest_values)?, |
| 2196 | ]; |
| 2197 | if ranked && a.before.is_none() { |
| 2198 | statements.push( |
| 2199 | db.prepare(format!( |
| 2200 | "SELECT {COLUMNS} FROM inbox_items WHERE {} AND {leading} ORDER BY bumped DESC LIMIT ?3", |
| 2201 | conditions.join(" AND ") |
| 2202 | )) |
| 2203 | .bind(&[username.as_str().into(), now.as_str().into(), MAX_RANKED.into()])?, |
| 2204 | ); |
| 2205 | } |
| 2206 | let results = db.batch(statements).await?; |
| 2207 | let mut rows = results.first().map(|result| result.results::<Row>()).transpose()?.unwrap_or_default(); |
| 2208 | let next = if rows.len() > limit as usize { |
| 2209 | rows.truncate(limit as usize); |
| 2210 | rows.last().map(|row| row.bumped.clone().unwrap_or_else(|| row.id.clone())) |
| 2211 | } else { |
| 2212 | None |
| 2213 | }; |
| 2214 | let mut items: Vec<Row> = results.get(1).map(|result| result.results::<Row>()).transpose()?.unwrap_or_default(); |
| 2215 | items.extend(rows); |
| 2216 | let items = readable_only(db, repos, &a.viewer, &username, items).await?; |
| 2217 | Ok(InboxPage { |
| 2218 | items: items.into_iter().map(Row::into_item).collect(), |
| 2219 | next, |
| 2220 | }) |
| 2221 | } |
| 2222 | |
| 2223 | /// The workspaces whose work items the viewer sees all of: those they are |
| 2224 | /// a member of, lowercased. |
| 2225 | fn member_of(viewer: &g1t_contracts::Viewer) -> Vec<String> { |
| 2226 | let Some(user) = viewer else { |
| 2227 | return Vec::new(); |
| 2228 | }; |
| 2229 | user.workspaces |
| 2230 | .iter() |
| 2231 | .filter(|membership| g1t_contracts::access::workspace_role(user, &membership.slug).is_some()) |
| 2232 | .map(|membership| membership.slug.to_lowercase()) |
| 2233 | .collect() |
| 2234 | } |
| 2235 | |
| 2236 | impl Row { |
| 2237 | /// A work item of one of these workspaces, which a member sees |
| 2238 | /// whatever its origin. |
| 2239 | fn seen_as_member(&self, members: &[String]) -> bool { |
| 2240 | self.subject.as_deref() == Some(SubjectKind::Item.as_str()) |
| 2241 | && self.workspace.as_deref().is_some_and(|slug| members.iter().any(|member| member.eq_ignore_ascii_case(slug))) |
| 2242 | } |
| 2243 | } |
| 2244 | |
| 2245 | /// Rows the viewer may still see: about repositories they can read, and |
| 2246 | /// work items of workspaces they belong to or whose origin they can read. |
| 2247 | /// The rest are removed from their inbox as they are found. |
| 2248 | pub(crate) async fn readable_only(db: &D1Database, repos: &Fetcher, viewer: &g1t_contracts::Viewer, username: &str, mut rows: Vec<Row>) -> Result<Vec<Row>> { |
| 2249 | let members = member_of(viewer); |
| 2250 | // A work item outside the viewer's workspaces with no origin is not theirs to see. |
| 2251 | let unseen: Vec<String> = rows |
| 2252 | .iter() |
| 2253 | .filter(|row| row.subject.as_deref() == Some(SubjectKind::Item.as_str()) && row.repo_id.is_none() && !row.seen_as_member(&members)) |
| 2254 | .map(|row| row.id.clone()) |
| 2255 | .collect(); |
| 2256 | let ids: Vec<String> = rows |
| 2257 | .iter() |
| 2258 | .filter(|row| !row.seen_as_member(&members)) |
| 2259 | .filter_map(|row| row.repo_id.clone()) |
| 2260 | .collect::<HashSet<_>>() |
| 2261 | .into_iter() |
| 2262 | .collect(); |
| 2263 | let gone: Vec<String> = if ids.is_empty() { |
| 2264 | Vec::new() |
| 2265 | } else { |
| 2266 | let readable: Vec<Repo> = g1t_kit::call( |
| 2267 | repos, |
| 2268 | "readable", |
| 2269 | &ReadableArgs { |
| 2270 | ids: ids.clone(), |
| 2271 | viewer: viewer.clone(), |
| 2272 | }, |
| 2273 | ) |
| 2274 | .await?; |
| 2275 | let readable: HashSet<String> = readable.into_iter().map(|repo| repo.id).collect(); |
| 2276 | ids.into_iter().filter(|id| !readable.contains(id)).collect() |
| 2277 | }; |
| 2278 | if !gone.is_empty() || !unseen.is_empty() { |
| 2279 | forget(db, username, &gone, &unseen, &members).await?; |
| 2280 | rows.retain(|row| { |
| 2281 | !unseen.contains(&row.id) && (row.seen_as_member(&members) || row.repo_id.as_ref().is_none_or(|id| !gone.contains(id))) |
| 2282 | }); |
| 2283 | } |
| 2284 | Ok(rows) |
| 2285 | } |
| 2286 | |
| 2287 | /// Removes a person's items about repositories they cannot read (but for |
| 2288 | /// work items of the workspaces they are a member of), and the items by |
| 2289 | /// id in `unseen`. |
| 2290 | async fn forget(db: &D1Database, username: &str, repo_ids: &[String], unseen: &[String], members: &[String]) -> Result<()> { |
| 2291 | let which = "username = ?1 AND ( |
| 2292 | (repo_id IN (SELECT value FROM json_each(?2)) |
| 2293 | AND NOT (subject = 'item' AND workspace IN (SELECT value FROM json_each(?3)))) |
| 2294 | OR id IN (SELECT value FROM json_each(?4)))"; |
| 2295 | let values: Vec<JsValue> = vec![ |
| 2296 | username.into(), |
| 2297 | serde_json::to_string(repo_ids)?.into(), |
| 2298 | serde_json::to_string(members)?.into(), |
| 2299 | serde_json::to_string(unseen)?.into(), |
| 2300 | ]; |
| 2301 | db.batch(vec![ |
| 2302 | db.prepare(format!("DELETE FROM inbox_activity WHERE item_id IN (SELECT id FROM inbox_items WHERE {which})")) |
| 2303 | .bind(&values)?, |
| 2304 | db.prepare(format!("DELETE FROM inbox_items WHERE {which}")).bind(&values)?, |
| 2305 | ]) |
| 2306 | .await?; |
| 2307 | Ok(()) |
| 2308 | } |
| 2309 | |
| 2310 | #[derive(Deserialize)] |
| 2311 | struct CountRow { |
| 2312 | severity: String, |
| 2313 | n: f64, |
| 2314 | } |
| 2315 | |
| 2316 | pub async fn counts(db: &D1Database, a: InboxCountsArgs) -> Result<InboxCounts> { |
| 2317 | let rows = db |
| 2318 | .prepare( |
| 2319 | "SELECT severity, count(*) AS n FROM inbox_items |
| 2320 | WHERE username = ? AND read_at IS NULL AND done_at IS NULL |
| 2321 | AND (snoozed_until IS NULL OR snoozed_until <= ?) |
| 2322 | GROUP BY severity", |
| 2323 | ) |
| 2324 | .bind(&[a.username.to_lowercase().into(), rfc3339(now_ms()).into()])? |
| 2325 | .all() |
| 2326 | .await? |
| 2327 | .results::<CountRow>()?; |
| 2328 | let mut counts = InboxCounts::default(); |
| 2329 | for row in rows { |
| 2330 | let n = row.n as u32; |
| 2331 | counts.unread += n; |
| 2332 | match Severity::parse(&row.severity) { |
| 2333 | Some(Severity::Error) => counts.error += n, |
| 2334 | Some(Severity::Warning) => counts.warning += n, |
| 2335 | Some(Severity::Success) => counts.success += n, |
| 2336 | Some(Severity::Info) | None => counts.info += n, |
| 2337 | } |
| 2338 | } |
| 2339 | Ok(counts) |
| 2340 | } |
| 2341 | |
| 2342 | /// The change a mark makes, as a `SET` clause; `?1` is now. |
| 2343 | fn mark_change(mark: InboxMark) -> &'static str { |
| 2344 | match mark { |
| 2345 | InboxMark::Read => "read_at = COALESCE(read_at, ?1)", |
| 2346 | InboxMark::Unread => "read_at = NULL", |
| 2347 | InboxMark::Done => "done_at = ?1, read_at = COALESCE(read_at, ?1), settled_reason = NULL, settled_by = NULL", |
| 2348 | InboxMark::Undone => "done_at = NULL, settled_reason = NULL, settled_by = NULL", |
| 2349 | InboxMark::Save => "saved = 1", |
| 2350 | InboxMark::Unsave => "saved = 0", |
| 2351 | InboxMark::Snooze => "snoozed_until = ?2, read_at = COALESCE(read_at, ?1)", |
| 2352 | InboxMark::Unsnooze => "snoozed_until = NULL", |
| 2353 | } |
| 2354 | } |
| 2355 | |
| 2356 | #[derive(Deserialize)] |
| 2357 | struct IdRow { |
| 2358 | #[allow(dead_code)] |
| 2359 | id: String, |
| 2360 | } |
| 2361 | |
| 2362 | /// Changes the person's own items. Returns how many changed. |
| 2363 | pub async fn mark(db: &D1Database, a: MarkInboxArgs) -> Result<u32> { |
| 2364 | let now = rfc3339(now_ms()); |
| 2365 | let until = match (a.mark, a.until.as_deref().map(str::trim)) { |
| 2366 | // Times compare as text (`g1t_contracts::time`); a snooze is for later. |
| 2367 | (InboxMark::Snooze, Some(until)) if until.len() == now.len() && until > now.as_str() => until.to_owned(), |
| 2368 | (InboxMark::Snooze, _) => return Ok(0), |
| 2369 | _ => String::new(), |
| 2370 | }; |
| 2371 | let mut values: Vec<JsValue> = vec![now.as_str().into(), until.as_str().into(), a.username.to_lowercase().into()]; |
| 2372 | let target = if a.all && a.ids.is_empty() { |
| 2373 | let mut target = "done_at IS NULL".to_owned(); |
| 2374 | let mut bind = |values: &mut Vec<JsValue>, value: &str, condition: &str| { |
| 2375 | values.push(value.into()); |
| 2376 | target.push_str(&format!(" AND {}", condition.replace('?', &format!("?{}", values.len())))); |
| 2377 | }; |
| 2378 | if let Some(severity) = a.severity { |
| 2379 | bind(&mut values, severity.as_str(), "severity = ?"); |
| 2380 | } |
| 2381 | if let Some(repo_id) = &a.repo_id { |
| 2382 | bind(&mut values, repo_id, "repo_id = ?"); |
| 2383 | } |
| 2384 | if let Some(last_read_at) = a.last_read_at.as_deref().map(str::trim).filter(|at| !at.is_empty()) { |
| 2385 | bind(&mut values, last_read_at, "COALESCE(updated_at, created_at) <= ?"); |
| 2386 | } |
| 2387 | target |
| 2388 | } else { |
| 2389 | let ids: Vec<&String> = a.ids.iter().take(MAX_MARK).collect(); |
| 2390 | if ids.is_empty() { |
| 2391 | return Ok(0); |
| 2392 | } |
| 2393 | let first = values.len() + 1; |
| 2394 | values.extend(ids.iter().map(|id| JsValue::from(id.as_str()))); |
| 2395 | let marks: Vec<String> = (first..values.len() + 1).map(|at| format!("?{at}")).collect(); |
| 2396 | format!("id IN ({})", marks.join(", ")) |
| 2397 | }; |
| 2398 | let changed = db |
| 2399 | .prepare(format!( |
| 2400 | "UPDATE inbox_items SET {} WHERE username = ?3 AND {target} RETURNING id", |
| 2401 | mark_change(a.mark) |
| 2402 | )) |
| 2403 | .bind(&values)? |
| 2404 | .all() |
| 2405 | .await? |
| 2406 | .results::<IdRow>()?; |
| 2407 | Ok(changed.len() as u32) |
| 2408 | } |
| 2409 | |
| 2410 | #[derive(Deserialize)] |
| 2411 | struct ActivityRow { |
| 2412 | reason: String, |
| 2413 | severity: String, |
| 2414 | title: String, |
| 2415 | body: String, |
| 2416 | event: Option<String>, |
| 2417 | actor: Option<String>, |
| 2418 | created_at: String, |
| 2419 | } |
| 2420 | |
| 2421 | /// One of the viewer's threads, with its history and their subscription. |
| 2422 | pub async fn thread(db: &D1Database, repos: &Fetcher, work: &Fetcher, a: ThreadArgs) -> Result<Option<InboxThread>> { |
| 2423 | let Some(viewer) = &a.viewer else { |
| 2424 | return Ok(None); |
| 2425 | }; |
| 2426 | let username = viewer.username.to_lowercase(); |
| 2427 | let row = db |
| 2428 | .prepare(format!("SELECT {COLUMNS} FROM inbox_items WHERE id = ? AND username = ?")) |
| 2429 | .bind(&[a.id.as_str().into(), username.as_str().into()])? |
| 2430 | .first::<Row>(None) |
| 2431 | .await?; |
| 2432 | let Some(row) = readable_only(db, repos, &a.viewer, &username, row.into_iter().collect()).await?.pop() else { |
| 2433 | return Ok(None); |
| 2434 | }; |
| 2435 | let activity = db |
| 2436 | .prepare( |
| 2437 | "SELECT reason, severity, title, body, event, actor, created_at FROM inbox_activity |
| 2438 | WHERE item_id = ? ORDER BY id DESC LIMIT ?", |
| 2439 | ) |
| 2440 | .bind(&[row.id.as_str().into(), MAX_ACTIVITY.into()])? |
| 2441 | .all() |
| 2442 | .await? |
| 2443 | .results::<ActivityRow>()? |
| 2444 | .into_iter() |
| 2445 | .map(|row| InboxActivity { |
| 2446 | reason: Reason::parse(&row.reason).unwrap_or(Reason::Subscribed), |
| 2447 | severity: Severity::parse(&row.severity).unwrap_or(Severity::Info), |
| 2448 | title: row.title, |
| 2449 | body: row.body, |
| 2450 | event: row.event, |
| 2451 | actor: row.actor, |
| 2452 | created_at: row.created_at, |
| 2453 | }) |
| 2454 | .collect(); |
| 2455 | let item = row.into_item(); |
| 2456 | let subscription = match (item.subject, item.number) { |
| 2457 | (Some(SubjectKind::Item | SubjectKind::Pull), Some(_)) => { |
| 2458 | subscriptions::subscription( |
| 2459 | db, |
| 2460 | work, |
| 2461 | SubscriptionArgs { |
| 2462 | viewer: a.viewer.clone(), |
| 2463 | id: Some(item.id.clone()), |
| 2464 | ..SubscriptionArgs::default() |
| 2465 | }, |
| 2466 | ) |
| 2467 | .await? |
| 2468 | } |
| 2469 | _ => None, |
| 2470 | }; |
| 2471 | Ok(Some(InboxThread { |
| 2472 | item, |
| 2473 | activity, |
| 2474 | subscription, |
| 2475 | })) |
| 2476 | } |
| 2477 | |
| 2478 | // --- Keeping up ------------------------------------------------------------------ |
| 2479 | |
| 2480 | /// Moves rows with renamed workspaces and repositories, drops those of |
| 2481 | /// purged repositories, deleted workspaces and purged accounts, and |
| 2482 | /// rewrites what was kept by issue number as issues become work items |
| 2483 | /// (work_items.rs). |
| 2484 | pub async fn follow(db: &D1Database, events: &[Event]) -> Result<()> { |
| 2485 | let mut statements = Vec::new(); |
| 2486 | for event in events { |
| 2487 | let text = |key: &str| event.data[key].as_str().unwrap_or_default().to_lowercase(); |
| 2488 | match event.kind.as_str() { |
| 2489 | "workspace.renamed" => { |
| 2490 | let Ok(renamed) = serde_json::from_value::<WorkspaceRenamed>(event.data.clone()) else { |
| 2491 | continue; |
| 2492 | }; |
| 2493 | let (from, to) = (renamed.from.to_lowercase(), renamed.to.to_lowercase()); |
| 2494 | if from == to { |
| 2495 | continue; |
| 2496 | } |
| 2497 | // A work item's origin may be in another workspace by now. |
| 2498 | statements.push( |
| 2499 | db.prepare( |
| 2500 | "UPDATE inbox_items SET workspace = ?2, |
| 2501 | repo = CASE WHEN repo LIKE ?1 || '/%' THEN ?2 || substr(repo, length(?1) + 1) ELSE repo END, |
| 2502 | link = CASE WHEN link LIKE '/' || ?1 || '/%' THEN '/' || ?2 || substr(link, length(?1) + 2) ELSE link END |
| 2503 | WHERE workspace = ?1", |
| 2504 | ) |
| 2505 | .bind(&[from.as_str().into(), to.as_str().into()])?, |
| 2506 | ); |
| 2507 | statements.push( |
| 2508 | db.prepare("UPDATE inbox_items SET repo = ?2 || substr(repo, length(?1) + 1) WHERE workspace IS NOT ?2 AND repo LIKE ?1 || '/%'") |
| 2509 | .bind(&[from.as_str().into(), to.as_str().into()])?, |
| 2510 | ); |
| 2511 | statements.push( |
| 2512 | db.prepare("UPDATE inbox_watching SET repo = ?2 || substr(repo, length(?1) + 1) WHERE repo LIKE ?1 || '/%'") |
| 2513 | .bind(&[from.as_str().into(), to.as_str().into()])?, |
| 2514 | ); |
| 2515 | } |
| 2516 | "repo.renamed" => { |
| 2517 | let path = format!("{}/{}", text("namespace"), text("to")); |
| 2518 | for table in ["inbox_items", "inbox_watching"] { |
| 2519 | statements.push( |
| 2520 | db.prepare(format!("UPDATE {table} SET repo = ? WHERE repo_id = ?")) |
| 2521 | .bind(&[path.as_str().into(), text("repoId").into()])?, |
| 2522 | ); |
| 2523 | } |
| 2524 | } |
| 2525 | "repo.transferred" => { |
| 2526 | let path = format!("{}/{}", text("to"), text("name")); |
| 2527 | // A work item stays in its workspace when its origin moves. |
| 2528 | statements.push( |
| 2529 | db.prepare( |
| 2530 | "UPDATE inbox_items SET repo = ?1, workspace = CASE WHEN subject = 'item' THEN workspace ELSE ?2 END |
| 2531 | WHERE repo_id = ?3", |
| 2532 | ) |
| 2533 | .bind(&[path.as_str().into(), text("to").into(), text("repoId").into()])?, |
| 2534 | ); |
| 2535 | statements.push( |
| 2536 | db.prepare("UPDATE inbox_watching SET repo = ? WHERE repo_id = ?") |
| 2537 | .bind(&[path.as_str().into(), text("repoId").into()])?, |
| 2538 | ); |
| 2539 | } |
| 2540 | // Its work items stay in their workspace, with no origin now. |
| 2541 | "repo.purged" => { |
| 2542 | for sql in [ |
| 2543 | "UPDATE inbox_items SET repo_id = NULL, repo = NULL WHERE repo_id = ?1 AND subject = 'item'", |
| 2544 | "UPDATE inbox_subscriptions SET repo_id = NULL WHERE repo_id = ?1 AND thread LIKE 'item:%'", |
| 2545 | "DELETE FROM inbox_activity WHERE item_id IN (SELECT id FROM inbox_items WHERE repo_id = ?1)", |
| 2546 | "DELETE FROM inbox_items WHERE repo_id = ?1", |
| 2547 | "DELETE FROM inbox_subscriptions WHERE repo_id = ?1", |
| 2548 | "DELETE FROM inbox_watching WHERE repo_id = ?1", |
| 2549 | ] { |
| 2550 | statements.push(db.prepare(sql).bind(&[text("repoId").into()])?); |
| 2551 | } |
| 2552 | } |
| 2553 | "workspace.deleted" => { |
| 2554 | statements.push( |
| 2555 | db.prepare("DELETE FROM inbox_items WHERE workspace = ?") |
| 2556 | .bind(&[text("slug").into()])?, |
| 2557 | ); |
| 2558 | statements.push( |
| 2559 | db.prepare("DELETE FROM inbox_watching WHERE repo LIKE ? || '/%'") |
| 2560 | .bind(&[text("slug").into()])?, |
| 2561 | ); |
| 2562 | } |
| 2563 | // Issues moved into work items: what was kept by their numbers follows. |
| 2564 | "work.migrated" => statements.extend(crate::work_items::moved(db, event)?), |
| 2565 | // An account purged: its inbox, what it watched and its |
| 2566 | // settings go with it (identity's account_deletion.rs). |
| 2567 | "user.deleted" => { |
| 2568 | let username = text("username"); |
| 2569 | if username.is_empty() { |
| 2570 | continue; |
| 2571 | } |
| 2572 | for sql in [ |
| 2573 | "DELETE FROM inbox_activity WHERE username = ?", |
| 2574 | "DELETE FROM inbox_items WHERE username = ?", |
| 2575 | "DELETE FROM inbox_subscriptions WHERE username = ?", |
| 2576 | "DELETE FROM inbox_watching WHERE username = ?", |
| 2577 | "DELETE FROM inbox_settings WHERE username = ?", |
| 2578 | ] { |
| 2579 | statements.push(db.prepare(sql).bind(&[username.as_str().into()])?); |
| 2580 | } |
| 2581 | } |
| 2582 | _ => {} |
| 2583 | } |
| 2584 | } |
| 2585 | if !statements.is_empty() { |
| 2586 | db.batch(statements).await?; |
| 2587 | } |
| 2588 | Ok(()) |
| 2589 | } |
| 2590 | |
| 2591 | /// Removes items done more than [`DONE_DAYS`] ago, and any not saved older |
| 2592 | /// than [`MAX_DAYS`], with their history. Returns how many went. |
| 2593 | pub async fn purge(db: &D1Database, now: u64) -> Result<u32> { |
| 2594 | let done = crate::audit::keep_from(now, DONE_DAYS); |
| 2595 | let oldest = crate::audit::keep_from(now, MAX_DAYS); |
| 2596 | let statements: Vec<D1PreparedStatement> = vec![ |
| 2597 | db.prepare("DELETE FROM inbox_items WHERE saved = 0 AND done_at < ?") |
| 2598 | .bind(&[done.into()])?, |
| 2599 | db.prepare("DELETE FROM inbox_items WHERE saved = 0 AND COALESCE(updated_at, created_at) < ?") |
| 2600 | .bind(&[oldest.into()])?, |
| 2601 | db.prepare("DELETE FROM inbox_activity WHERE NOT EXISTS (SELECT 1 FROM inbox_items WHERE inbox_items.id = inbox_activity.item_id)"), |
| 2602 | ]; |
| 2603 | let results = db.batch(statements).await?; |
| 2604 | let mut removed = 0; |
| 2605 | for result in results.into_iter().take(2) { |
| 2606 | removed += result.meta()?.and_then(|meta| meta.changes).unwrap_or(0) as u32; |
| 2607 | } |
| 2608 | Ok(removed) |
| 2609 | } |
| 2610 | |
| 2611 | #[cfg(test)] |
| 2612 | mod tests { |
| 2613 | use super::*; |
| 2614 | use crate::subscriptions::{State, Subscription, Watcher}; |
| 2615 | use serde_json::json; |
| 2616 | |
| 2617 | fn event(kind: &str, actor: Option<&str>, data: serde_json::Value) -> Event { |
| 2618 | Event { |
| 2619 | id: "evt_1".into(), |
| 2620 | kind: kind.into(), |
| 2621 | source: "work".into(), |
| 2622 | time: "2026-10-07T12:00:00.000Z".into(), |
| 2623 | repo_id: Some("rep_1".into()), |
| 2624 | actor: actor.map(str::to_owned), |
| 2625 | data, |
| 2626 | } |
| 2627 | } |
| 2628 | |
| 2629 | fn person(id: &str, username: &str) -> Principal { |
| 2630 | Principal { |
| 2631 | id: id.into(), |
| 2632 | username: username.into(), |
| 2633 | } |
| 2634 | } |
| 2635 | |
| 2636 | fn actor(id: &str, username: &str) -> Actor { |
| 2637 | Actor { |
| 2638 | id: Some(id.into()), |
| 2639 | username: Some(username.into()), |
| 2640 | } |
| 2641 | } |
| 2642 | |
| 2643 | /// A pull request ana opened, assigned to bo, for a work item cy filed and dee is assigned. |
| 2644 | fn pull() -> InboxSubject { |
| 2645 | InboxSubject { |
| 2646 | kind: Some(SubjectKind::Pull), |
| 2647 | title: "Add the inbox".into(), |
| 2648 | author: person("usr_ana", "ana"), |
| 2649 | assignees: vec!["bo".into()], |
| 2650 | item: Some(Box::new(InboxSubject { |
| 2651 | kind: Some(SubjectKind::Item), |
| 2652 | title: "An inbox".into(), |
| 2653 | author: person("usr_cy", "cy"), |
| 2654 | assignees: vec!["dee".into()], |
| 2655 | ..InboxSubject::default() |
| 2656 | })), |
| 2657 | ..InboxSubject::default() |
| 2658 | } |
| 2659 | } |
| 2660 | |
| 2661 | /// A change g1t made for ana. |
| 2662 | fn g1t_pull() -> InboxSubject { |
| 2663 | InboxSubject { |
| 2664 | author: person(AGENT_ID, "g1t"), |
| 2665 | requested_by: Some(person("usr_ana", "ana")), |
| 2666 | ..pull() |
| 2667 | } |
| 2668 | } |
| 2669 | |
| 2670 | fn nobody() -> Audience { |
| 2671 | Audience::default() |
| 2672 | } |
| 2673 | |
| 2674 | fn told(notices: &[Notice]) -> Vec<(&str, Reason, Severity)> { |
| 2675 | notices |
| 2676 | .iter() |
| 2677 | .map(|notice| (notice.username.as_str(), notice.reason, notice.severity)) |
| 2678 | .collect() |
| 2679 | } |
| 2680 | |
| 2681 | fn comment(author: Principal, body: &str, mentions: &[&str]) -> InboxSubject { |
| 2682 | InboxSubject { |
| 2683 | comment: Some(InboxComment { |
| 2684 | author, |
| 2685 | excerpt: body.into(), |
| 2686 | mentions: mentions.iter().map(|name| (*name).to_owned()).collect(), |
| 2687 | ..InboxComment::default() |
| 2688 | }), |
| 2689 | ..pull() |
| 2690 | } |
| 2691 | } |
| 2692 | |
| 2693 | fn subscribed(rows: &[(&str, State, Option<Reason>)]) -> Audience { |
| 2694 | Audience { |
| 2695 | subscriptions: rows |
| 2696 | .iter() |
| 2697 | .map(|(name, state, reason)| Subscription { |
| 2698 | username: (*name).into(), |
| 2699 | state: *state, |
| 2700 | reason: *reason, |
| 2701 | }) |
| 2702 | .collect(), |
| 2703 | watchers: Vec::new(), |
| 2704 | } |
| 2705 | } |
| 2706 | |
| 2707 | fn watched(rows: &[(&str, WatchLevel, &[&str])]) -> Audience { |
| 2708 | Audience { |
| 2709 | subscriptions: Vec::new(), |
| 2710 | watchers: rows |
| 2711 | .iter() |
| 2712 | .map(|(name, level, events)| Watcher { |
| 2713 | username: (*name).into(), |
| 2714 | level: *level, |
| 2715 | events: events.iter().map(|kind| (*kind).to_owned()).collect(), |
| 2716 | }) |
| 2717 | .collect(), |
| 2718 | } |
| 2719 | } |
| 2720 | |
| 2721 | #[test] |
| 2722 | fn only_events_that_tell_someone_are_read() { |
| 2723 | let asked = |kind: &str, data| wants(&event(kind, None, data)); |
| 2724 | assert_eq!( |
| 2725 | asked("checks.completed", json!({ "repoId": "rep_1", "number": 4, "status": "failed" })), |
| 2726 | Some(Wanted { repo_id: Some("rep_1".into()), number: Some(4), ..Wanted::default() }) |
| 2727 | ); |
| 2728 | assert_eq!(asked("checks.completed", json!({ "repoId": "rep_1", "number": 4, "status": "passed" })), None); |
| 2729 | assert_eq!(asked("review.completed", json!({ "repoId": "rep_1", "number": 4, "verdict": "approve" })), None); |
| 2730 | assert_eq!(asked("agent.asked", json!({ "repoId": "rep_1", "number": 4 })), None); |
| 2731 | assert_eq!(asked("workflow.completed", json!({ "repoId": "rep_1", "conclusion": "success" })), None); |
| 2732 | assert_eq!( |
| 2733 | asked("workflow.completed", json!({ "repoId": "rep_1", "conclusion": "failure" })), |
| 2734 | Some(Wanted { repo_id: Some("rep_1".into()), ..Wanted::default() }) |
| 2735 | ); |
| 2736 | assert_eq!( |
| 2737 | asked("comment.created", json!({ "repoId": "rep_1", "number": 2, "commentId": "cmt_1" })).map(|w| w.comment_id), |
| 2738 | Some(Some("cmt_1".into())) |
| 2739 | ); |
| 2740 | assert_eq!(asked("git.push", json!({ "repoId": "rep_1" })), None); |
| 2741 | for kind in ["pull.review_requested", "pull.stalled", "pull.closed"] { |
| 2742 | assert!(asked(kind, json!({ "repoId": "rep_1", "number": 1 })).is_some(), "{kind}"); |
| 2743 | } |
| 2744 | assert_eq!(asked("deployment.failed", json!({ "repoId": "rep_1" })).map(|w| w.number), Some(None)); |
| 2745 | } |
| 2746 | |
| 2747 | #[test] |
| 2748 | fn a_work_items_events_are_read_by_its_id_with_or_without_an_origin() { |
| 2749 | let item = json!({ "itemId": "wki_1", "workspace": "Acme", "number": 40, "repoIds": ["rep_1", "rep_2"] }); |
| 2750 | for kind in ITEM_TOLD { |
| 2751 | let wanted = wants(&event(kind, None, item.clone())).unwrap_or_else(|| panic!("{kind}")); |
| 2752 | assert_eq!(wanted.repo_id.as_deref(), Some("rep_1")); |
| 2753 | assert_eq!(wanted.number, Some(40)); |
| 2754 | assert_eq!( |
| 2755 | wanted.item, |
| 2756 | Some(WantedItem { id: "wki_1".into(), workspace: "acme".into(), repo_ids: vec!["rep_1".into(), "rep_2".into()] }) |
| 2757 | ); |
| 2758 | } |
| 2759 | // Filed in the workspace: no origin. |
| 2760 | let filed = Event { repo_id: None, ..event("work_item.opened", None, item.clone()) }; |
| 2761 | assert_eq!(wants(&filed).map(|wanted| wanted.repo_id), Some(None)); |
| 2762 | // A comment on one names it; one on a pull request does not. |
| 2763 | let comment = json!({ "itemId": "wki_1", "workspace": "acme", "number": 40, "commentId": "cmt_1", "repoIds": [] }); |
| 2764 | let wanted = wants(&Event { repo_id: None, ..event("comment.created", None, comment) }).unwrap(); |
| 2765 | assert_eq!((wanted.comment_id.as_deref(), wanted.item.map(|item| item.id)), (Some("cmt_1"), Some("wki_1".into()))); |
| 2766 | // Without its id there is nothing to read. |
| 2767 | assert_eq!(wants(&event("work_item.opened", None, json!({ "number": 40 }))), None); |
| 2768 | // What the inbox does not tell of. |
| 2769 | assert_eq!(wants(&event("work_item.labeled", None, item)), None); |
| 2770 | } |
| 2771 | |
| 2772 | #[test] |
| 2773 | fn a_work_item_is_one_thread_in_its_workspace() { |
| 2774 | let data = json!({ "itemId": "wki_1", "workspace": "acme", "number": 40, "repoIds": ["rep_1"] }); |
| 2775 | let opened = event("work_item.opened", None, data.clone()); |
| 2776 | let wanted = wants(&opened).unwrap(); |
| 2777 | let thread = thread_of(&opened, &wanted, None); |
| 2778 | assert_eq!(thread.key, "item:wki_1"); |
| 2779 | assert_eq!(thread.kind, Some(SubjectKind::Item)); |
| 2780 | assert_eq!(url(Some("acme/rocket"), Some("acme"), thread.kind, thread.number, None, None), "/acme/-/work/40"); |
| 2781 | // Closing it settles everything on it, and says what landed it. |
| 2782 | let closed = event( |
| 2783 | "work_item.closed", |
| 2784 | None, |
| 2785 | json!({ "itemId": "wki_1", "workspace": "acme", "number": 40, "resolution": { "repo": "acme/api", "pull": 9 } }), |
| 2786 | ); |
| 2787 | assert_eq!(closes(&closed, Some("bo")), vec![Settle::thread("item:wki_1").saying("Closed", Some("bo"))]); |
| 2788 | let item = InboxSubject { kind: Some(SubjectKind::Item), title: "Ship it".into(), author: person("usr_cy", "cy"), ..InboxSubject::default() }; |
| 2789 | assert_eq!(notices(&closed, "acme", &Actor::default(), Some(&item), &nobody())[0].title, "acme#40 was closed by acme/api#9"); |
| 2790 | // A comment on it is handled on its thread. |
| 2791 | let comment = event("comment.created", None, json!({ "itemId": "wki_1", "workspace": "acme", "number": 40, "commentId": "cmt_1" })); |
| 2792 | let on = InboxSubject { |
| 2793 | comment: Some(InboxComment { author: person("usr_bo", "bo"), ..InboxComment::default() }), |
| 2794 | ..item |
| 2795 | }; |
| 2796 | assert_eq!(handled_by(&comment, Some(&on)).map(|settle| settle.scope), Some(Scope::Thread("item:wki_1".into()))); |
| 2797 | assert!(subscribable("item:wki_1") && subscribable("rep_1#7") && !subscribable("rep_1/run/ci@main")); |
| 2798 | } |
| 2799 | |
| 2800 | #[test] |
| 2801 | fn a_work_items_watchers_are_its_origins_then_its_other_repositories() { |
| 2802 | let watcher = |name: &str, level: WatchLevel| Watcher { username: name.into(), level, events: Vec::new() }; |
| 2803 | let own = vec![watcher("ana", WatchLevel::All), watcher("bo", WatchLevel::Ignore)]; |
| 2804 | let others = vec![vec![watcher("bo", WatchLevel::All), watcher("cy", WatchLevel::All), watcher("dee", WatchLevel::Ignore)]]; |
| 2805 | let (watchers, elsewhere) = subscriptions::linked_watchers(own, &others); |
| 2806 | let names: Vec<(&str, WatchLevel)> = watchers.iter().map(|w| (w.username.as_str(), w.level)).collect(); |
| 2807 | // Ignoring the origin stands; ignoring another repository says nothing. |
| 2808 | assert_eq!(names, vec![("ana", WatchLevel::All), ("bo", WatchLevel::Ignore), ("cy", WatchLevel::All)]); |
| 2809 | assert_eq!(elsewhere.into_iter().collect::<Vec<_>>(), vec!["cy".to_owned()]); |
| 2810 | } |
| 2811 | |
| 2812 | #[test] |
| 2813 | fn a_stopped_pull_request_needs_its_people_and_its_work_items_people_first() { |
| 2814 | let stalled = event("pull.stalled", None, json!({ "number": 7 })); |
| 2815 | let notices_ = notices(&stalled, "acme/rocket", &Actor::default(), Some(&pull()), &nobody()); |
| 2816 | assert_eq!( |
| 2817 | told(¬ices_), |
| 2818 | vec![ |
| 2819 | ("ana", Reason::Agent, Severity::Warning), |
| 2820 | ("cy", Reason::Agent, Severity::Warning), |
| 2821 | ("dee", Reason::Agent, Severity::Warning), |
| 2822 | ] |
| 2823 | ); |
| 2824 | assert_eq!(notices_[0].title, "g1t stopped on acme/rocket#7 and needs you"); |
| 2825 | assert_eq!(notices_[0].body, "Add the inbox"); |
| 2826 | // Stopping says why; even someone who unsubscribed hears of it. |
| 2827 | let stalled = event("pull.stalled", None, json!({ "number": 7, "detail": "Its checks could not be run." })); |
| 2828 | let audience = subscribed(&[("ana", State::Unsubscribed, None)]); |
| 2829 | let notices_ = notices(&stalled, "acme/rocket", &Actor::default(), Some(&g1t_pull()), &audience); |
| 2830 | assert_eq!(notices_[0].username, "ana"); |
| 2831 | assert_eq!(notices_[0].title, "g1t stopped on acme/rocket#7 and needs you"); |
| 2832 | assert_eq!(notices_[0].body, "Its checks could not be run."); |
| 2833 | // Ignoring the thread silences even that. |
| 2834 | let audience = subscribed(&[("ana", State::Ignored, None)]); |
| 2835 | let notices_ = notices(&stalled, "acme/rocket", &Actor::default(), Some(&g1t_pull()), &audience); |
| 2836 | assert!(!notices_.iter().any(|notice| notice.username == "ana")); |
| 2837 | } |
| 2838 | |
| 2839 | #[test] |
| 2840 | fn whoever_turned_on_auto_merge_hears_it_is_off() { |
| 2841 | let off = event("pull.auto_merge_disabled", None, json!({ "number": 7, "autoMergeBy": "bo", "detail": "Its branch conflicts with main." })); |
| 2842 | let notices_ = notices(&off, "acme/rocket", &Actor::default(), Some(&pull()), &nobody()); |
| 2843 | assert_eq!(told(¬ices_), vec![("bo", Reason::StateChange, Severity::Warning)]); |
| 2844 | assert_eq!(notices_[0].title, "Auto-merge was turned off on acme/rocket#7"); |
| 2845 | assert_eq!(notices_[0].body, "Its branch conflicts with main."); |
| 2846 | // Turning it off yourself tells no one. |
| 2847 | let notices_ = notices(&off, "acme/rocket", &actor("usr_bo", "bo"), Some(&pull()), &nobody()); |
| 2848 | assert!(notices_.is_empty()); |
| 2849 | } |
| 2850 | |
| 2851 | #[test] |
| 2852 | fn g1t_handing_a_pull_request_to_the_merge_queue_tells_no_one() { |
| 2853 | let off = event( |
| 2854 | "pull.auto_merge_disabled", |
| 2855 | None, |
| 2856 | json!({ "number": 7, "autoMergeBy": "bo", "detail": "It joined the merge queue.", "queued": true }), |
| 2857 | ); |
| 2858 | assert!(notices(&off, "acme/rocket", &Actor::default(), Some(&pull()), &nobody()).is_empty()); |
| 2859 | } |
| 2860 | |
| 2861 | #[test] |
| 2862 | fn whatever_an_agent_waits_on_closes_when_it_goes_on() { |
| 2863 | for kind in RESUMES { |
| 2864 | let settled = settles(&event(kind, None, json!({ "repoId": "rep_1", "number": 7 })), Some("ana")); |
| 2865 | let agent = settled.iter().find(|settle| settle.reasons == [Reason::Agent]).unwrap_or_else(|| panic!("{kind}")); |
| 2866 | assert_eq!(agent.scope, Scope::Thread("rep_1#7".into())); |
| 2867 | assert_eq!(agent.why.as_deref(), Some(resumed_because(kind))); |
| 2868 | assert_eq!(agent.by.as_deref(), Some("ana")); |
| 2869 | } |
| 2870 | assert_eq!(resumed_because("pull.updated"), "New commits were pushed"); |
| 2871 | assert!(settles(&event("comment.created", None, json!({ "repoId": "rep_1", "number": 7 })), None).is_empty()); |
| 2872 | } |
| 2873 | |
| 2874 | #[test] |
| 2875 | fn a_merge_or_a_close_settles_everything_about_it() { |
| 2876 | let merged = event("pull.merged", Some("usr_ana"), json!({ "repoId": "rep_1", "number": 7 })); |
| 2877 | assert_eq!( |
| 2878 | closes(&merged, Some("Ana")), |
| 2879 | vec![ |
| 2880 | Settle::thread("rep_1#7").saying("Merged", Some("ana")), |
| 2881 | Settle::matching("rep_1/deploy/*/7").saying("Merged", Some("ana")), |
| 2882 | ] |
| 2883 | ); |
| 2884 | let closed = event("pull.closed", None, json!({ "repoId": "rep_1", "number": 7 })); |
| 2885 | assert_eq!(closes(&closed, None).len(), 2); |
| 2886 | assert_eq!(closes(&closed, None)[0].why.as_deref(), Some("Closed")); |
| 2887 | assert_eq!(closes(&closed, None)[0].by, None); |
| 2888 | // A work item has no previews. |
| 2889 | let item = event("work_item.closed", None, json!({ "itemId": "wki_1", "workspace": "acme", "number": 3, "reason": "not_planned" })); |
| 2890 | assert_eq!(closes(&item, Some("bo")), vec![Settle::thread("item:wki_1").saying("Closed as not planned", Some("bo"))]); |
| 2891 | // Reopening is something to hear of, and settles nothing. |
| 2892 | assert!(closes(&event("work_item.reopened", None, json!({ "itemId": "wki_1", "number": 3 })), None).is_empty()); |
| 2893 | assert!(settles(&event("work_item.reopened", None, json!({ "itemId": "wki_1", "number": 3 })), None).is_empty()); |
| 2894 | } |
| 2895 | |
| 2896 | #[test] |
| 2897 | fn a_workflow_passing_on_a_branch_settles_its_failures_there() { |
| 2898 | let data = |conclusion: &str| { |
| 2899 | json!({ "repoId": "rep_1", "runId": "run_9", "workflow": "Deploy", "path": ".g1t/workflows/deploy.yml", "ref": "refs/heads/main", "conclusion": conclusion, "number": 328 }) |
| 2900 | }; |
| 2901 | let failed = event("workflow.completed", Some("usr_bo"), data("failure")); |
| 2902 | let thread = thread_of(&failed, &wants(&failed).unwrap(), None).key; |
| 2903 | assert_eq!(thread, "rep_1/run/.g1t/workflows/deploy.yml@main"); |
| 2904 | let passed = event("workflow.completed", Some("usr_bo"), data("success")); |
| 2905 | assert!(wants(&passed).is_none(), "a success tells no one"); |
| 2906 | // Whoever started the run did not settle anything: the run passing did. |
| 2907 | assert_eq!( |
| 2908 | settles(&passed, Some("bo")), |
| 2909 | vec![ |
| 2910 | Settle::thread(thread.clone()).saying("Deploy passed in run 328", None), |
| 2911 | Settle::matching("rep_1/review/run_9/*").because(&[Reason::ReviewRequested]).saying("Deploy finished in run 328", None), |
| 2912 | ] |
| 2913 | ); |
| 2914 | // A failure or a cancelled run settles no failure, but ends what its deployments waited for. |
| 2915 | for conclusion in ["failure", "cancelled"] { |
| 2916 | assert_eq!( |
| 2917 | settles(&event("workflow.completed", None, data(conclusion)), None), |
| 2918 | vec![Settle::matching("rep_1/review/run_9/*").because(&[Reason::ReviewRequested]).saying("Deploy finished in run 328", None)] |
| 2919 | ); |
| 2920 | } |
| 2921 | // On a pull request, its checks passing settles the failure instead. |
| 2922 | let on_pull = event("workflow.completed", None, json!({ "repoId": "rep_1", "runId": "run_9", "conclusion": "success", "pull": 7 })); |
| 2923 | assert!(!settles(&on_pull, None).iter().any(|settle| settle.scope == Scope::Thread(thread.clone()))); |
| 2924 | } |
| 2925 | |
| 2926 | #[test] |
| 2927 | fn checks_passing_settle_the_failure_its_owner_was_told_of() { |
| 2928 | let passed = event("checks.completed", None, json!({ "repoId": "rep_1", "number": 7, "status": "passed", "commit": "abcdef0123456" })); |
| 2929 | assert_eq!( |
| 2930 | settles(&passed, None), |
| 2931 | vec![Settle::thread("rep_1#7").because(&[Reason::CiActivity]).saying("Checks passed on abcdef0", None)] |
| 2932 | ); |
| 2933 | let failed = event("checks.completed", None, json!({ "repoId": "rep_1", "number": 7, "status": "failed" })); |
| 2934 | assert!(settles(&failed, None).is_empty()); |
| 2935 | } |
| 2936 | |
| 2937 | #[test] |
| 2938 | fn a_deployment_settles_the_failure_before_it() { |
| 2939 | let live = event("deployment.succeeded", Some("usr_bo"), json!({ "repoId": "rep_1", "projectId": "prj_1", "project": "web", "commit": "1234567890" })); |
| 2940 | assert_eq!( |
| 2941 | settles(&live, Some("bo")), |
| 2942 | vec![Settle::thread("rep_1/deploy/prj_1/production").after(&["deployment.failed"]).saying("Production of web deployed at 1234567", Some("bo"))] |
| 2943 | ); |
| 2944 | // Started by g1t or a workflow: the deployment names who. |
| 2945 | let preview = event("deployment.succeeded", None, json!({ "repoId": "rep_1", "projectId": "prj_1", "number": 7, "triggeredBy": "g1t" })); |
| 2946 | assert_eq!( |
| 2947 | settles(&preview, None), |
| 2948 | vec![Settle::thread("rep_1/deploy/prj_1/7").after(&["deployment.failed"]).saying("Preview of #7 deployed", Some("g1t"))] |
| 2949 | ); |
| 2950 | } |
| 2951 | |
| 2952 | #[test] |
| 2953 | fn requests_answered_settle_what_they_asked() { |
| 2954 | let removed = event( |
| 2955 | "pull.review_request_removed", |
| 2956 | None, |
| 2957 | json!({ "repoId": "rep_1", "number": 7, "reviewers": ["Bo"], "teams": [{ "team": "acme/web", "notified": ["cy"] }] }), |
| 2958 | ); |
| 2959 | let mut people: Vec<Option<String>> = settles(&removed, Some("ana")).into_iter().map(|settle| settle.username).collect(); |
| 2960 | people.sort(); |
| 2961 | assert_eq!(people, vec![Some("bo".to_owned()), Some("cy".to_owned())]); |
| 2962 | assert!(settles(&removed, Some("ana")).iter().all(|settle| settle.why.as_deref() == Some("Review no longer asked of you"))); |
| 2963 | let token = event("token.approval_reviewed", None, json!({ "workspace": "acme", "tokenId": "tok_1" })); |
| 2964 | assert_eq!( |
| 2965 | settles(&token, Some("ana")), |
| 2966 | vec![Settle::thread("workspace:acme/token/tok_1").because(&[Reason::ReviewRequested]).saying("Token request decided", Some("ana"))] |
| 2967 | ); |
| 2968 | let bypass = event("secret_scanning.bypass_reviewed", None, json!({ "repoId": "rep_1", "requestId": "byp_1" })); |
| 2969 | assert_eq!( |
| 2970 | settles(&bypass, None), |
| 2971 | vec![Settle::thread("rep_1/security/byp_1").because(&[Reason::SecurityAlert]).saying("Bypass request decided", None)] |
| 2972 | ); |
| 2973 | let invitation = event("workspace_invitation.declined", None, json!({ "thread": "invitation:inv_1" })); |
| 2974 | assert_eq!( |
| 2975 | settles(&invitation, Some("cy")), |
| 2976 | vec![Settle::thread("invitation:inv_1").because(&[Reason::ReviewRequested]).saying("Invitation declined", Some("cy"))] |
| 2977 | ); |
| 2978 | } |
| 2979 | |
| 2980 | #[test] |
| 2981 | fn your_own_comment_settles_your_item_on_the_thread() { |
| 2982 | let commented = event("comment.created", Some("usr_bo"), json!({ "repoId": "rep_1", "number": 7, "commentId": "cmt_1" })); |
| 2983 | let by_bo = comment(person("usr_bo", "Bo"), "Looks good", &[]); |
| 2984 | assert_eq!(handled_by(&commented, Some(&by_bo)), Some(Settle::thread("rep_1#7").of("bo").saying("Commented", Some("bo")))); |
| 2985 | let mut review = comment(person("usr_bo", "Bo"), "Ship it", &[]); |
| 2986 | review.comment.as_mut().unwrap().verdict = Some("approve".into()); |
| 2987 | assert_eq!(handled_by(&commented, Some(&review)).and_then(|settle| settle.why), Some("Reviewed".to_owned())); |
| 2988 | // Not g1t's, nor an agent's, nor a note the service wrote. |
| 2989 | let by_g1t = comment(person(AGENT_ID, "g1t"), "Done", &[]); |
| 2990 | assert_eq!(handled_by(&commented, Some(&by_g1t)), None); |
| 2991 | let mut note = comment(person("usr_bo", "bo"), "", &[]); |
| 2992 | note.comment.as_mut().unwrap().event = true; |
| 2993 | assert_eq!(handled_by(&commented, Some(¬e)), None); |
| 2994 | assert_eq!(handled_by(&event("pull.merged", None, json!({ "repoId": "rep_1", "number": 7 })), Some(&by_bo)), None); |
| 2995 | } |
| 2996 | |
| 2997 | #[test] |
| 2998 | fn a_deployments_reviewers_are_told() { |
| 2999 | let asked = event( |
| 3000 | "deployment.review_requested", |
| 3001 | Some("usr_ana"), |
| 3002 | json!({ |
| 3003 | "repoId": "rep_1", "runId": "run_7", "environment": "production", "workflow": "Deploy", |
| 3004 | "title": "Ship it", "notify": ["cy", "ana"], "link": "/acme/rocket/actions/runs/run_7" |
| 3005 | }), |
| 3006 | ); |
| 3007 | let wanted = wants(&asked).unwrap(); |
| 3008 | assert_eq!(wanted.number, None); |
| 3009 | let thread = thread_of(&asked, &wanted, None); |
| 3010 | assert_eq!(thread.key, "rep_1/review/run_7/production"); |
| 3011 | assert_eq!(thread.link.as_deref(), Some("/acme/rocket/actions/runs/run_7")); |
| 3012 | let told = notices(&asked, "acme/rocket", &actor("usr_ana", "ana"), None, &nobody()); |
| 3013 | let names: Vec<&str> = told.iter().map(|notice| notice.username.as_str()).collect(); |
| 3014 | // Whoever started the run is told too, when they review it. |
| 3015 | assert_eq!(names, ["cy", "ana"]); |
| 3016 | assert!(told[0].title.contains("waiting for your review to deploy to production")); |
| 3017 | } |
| 3018 | |
| 3019 | #[test] |
| 3020 | fn teams_asked_to_review_tell_the_people_they_name() { |
| 3021 | let requested = event( |
| 3022 | "pull.review_requested", |
| 3023 | Some("usr_ana"), |
| 3024 | json!({ "number": 7, "reviewers": ["cy"], "teams": [ |
| 3025 | { "team": "acme/backend", "notified": ["cy", "dee", "ana"], "assigned": ["cy"] } |
| 3026 | ] }), |
| 3027 | ); |
| 3028 | let notices_ = notices(&requested, "acme/rocket", &actor("usr_ana", "ana"), Some(&pull()), &nobody()); |
| 3029 | // cy was picked and is told as a reviewer; dee through the team; |
| 3030 | // never whoever asked. |
| 3031 | assert_eq!( |
| 3032 | told(¬ices_), |
| 3033 | vec![("cy", Reason::ReviewRequested, Severity::Warning), ("dee", Reason::ReviewRequested, Severity::Warning)] |
| 3034 | ); |
| 3035 | assert_eq!(notices_[0].title, "ana asked you to review acme/rocket#7"); |
| 3036 | assert_eq!(notices_[1].title, "ana asked @acme/backend to review acme/rocket#7"); |
| 3037 | assert_eq!( |
| 3038 | subscribes(&requested, Some(&pull())), |
| 3039 | vec![("cy".into(), Reason::ReviewRequested), ("dee".into(), Reason::ReviewRequested), ("ana".into(), Reason::ReviewRequested)] |
| 3040 | ); |
| 3041 | // Asked by the CODEOWNERS file. |
| 3042 | let owned = event( |
| 3043 | "pull.review_requested", |
| 3044 | None, |
| 3045 | json!({ "number": 7, "reviewers": ["bo"], "codeOwners": true, "teams": [{ "team": "acme/docs", "notified": ["wren"], "assigned": [] }] }), |
| 3046 | ); |
| 3047 | let notices_ = notices(&owned, "acme/rocket", &Actor::default(), Some(&pull()), &nobody()); |
| 3048 | assert_eq!(notices_[0].title, "acme/rocket#7 changes files you own"); |
| 3049 | assert_eq!(notices_[1].title, "acme/rocket#7 changes files @acme/docs owns"); |
| 3050 | } |
| 3051 | |
| 3052 | #[test] |
| 3053 | fn a_team_mention_tells_its_people_once_and_a_name_wins() { |
| 3054 | let mut on = comment(person("usr_bo", "bo"), "cc @ana @acme/backend", &["ana"]); |
| 3055 | if let Some(comment) = on.comment.as_mut() { |
| 3056 | comment.team_mentions = vec![TeamMentioned { |
| 3057 | team: "acme/backend".into(), |
| 3058 | members: vec!["ana".into(), "cy".into(), "bo".into()], |
| 3059 | }]; |
| 3060 | } |
| 3061 | let created = event("comment.created", Some("usr_bo"), json!({ "number": 7, "commentId": "cmt_1" })); |
| 3062 | let notices_ = notices(&created, "acme/rocket", &actor("usr_bo", "bo"), Some(&on), &nobody()); |
| 3063 | let mentioned: Vec<(&str, Reason)> = notices_.iter().map(|n| (n.username.as_str(), n.reason)).filter(|(_, r)| matches!(r, Reason::Mention | Reason::TeamMention)).collect(); |
| 3064 | assert_eq!(mentioned, vec![("ana", Reason::Mention), ("cy", Reason::TeamMention)]); |
| 3065 | assert_eq!( |
| 3066 | notices_.iter().find(|n| n.username == "cy").unwrap().title, |
| 3067 | "bo mentioned @acme/backend on acme/rocket#7" |
| 3068 | ); |
| 3069 | let subscribed = subscribes(&created, Some(&on)); |
| 3070 | assert!(subscribed.contains(&("cy".into(), Reason::TeamMention))); |
| 3071 | assert!(subscribed.contains(&("ana".into(), Reason::Mention))); |
| 3072 | } |
| 3073 | |
| 3074 | #[test] |
| 3075 | fn a_description_tells_the_people_and_teams_it_mentions() { |
| 3076 | let mut on = pull(); |
| 3077 | on.mentions = vec!["dee".into()]; |
| 3078 | on.team_mentions = vec![TeamMentioned { |
| 3079 | team: "acme/web".into(), |
| 3080 | members: vec!["eve".into()], |
| 3081 | }]; |
| 3082 | let opened = event("pull.opened", Some("usr_ana"), json!({ "number": 7 })); |
| 3083 | let notices_ = notices(&opened, "acme/rocket", &actor("usr_ana", "ana"), Some(&on), &nobody()); |
| 3084 | assert!(told(¬ices_).contains(&("dee", Reason::Mention, Severity::Info))); |
| 3085 | assert!(told(¬ices_).contains(&("eve", Reason::TeamMention, Severity::Info))); |
| 3086 | assert_eq!( |
| 3087 | subscribes(&opened, Some(&on)), |
| 3088 | vec![("dee".into(), Reason::Mention), ("eve".into(), Reason::TeamMention)] |
| 3089 | ); |
| 3090 | } |
| 3091 | |
| 3092 | #[test] |
| 3093 | fn reviewers_and_assignees_asked_are_told_never_whoever_asked() { |
| 3094 | let requested = event("pull.review_requested", Some("usr_ana"), json!({ "number": 7, "reviewers": ["bo", "g1t", "ana"] })); |
| 3095 | let notices_ = notices(&requested, "acme/rocket", &actor("usr_ana", "ana"), Some(&pull()), &nobody()); |
| 3096 | assert_eq!(told(¬ices_), vec![("bo", Reason::ReviewRequested, Severity::Warning)]); |
| 3097 | assert_eq!(notices_[0].title, "ana asked you to review acme/rocket#7"); |
| 3098 | let assigned = event("work_item.assigned", Some("usr_ana"), json!({ "number": 3, "added": ["ana", "eve"] })); |
| 3099 | let notices_ = notices(&assigned, "acme/rocket", &actor("usr_ana", "ana"), Some(&pull()), &nobody()); |
| 3100 | assert_eq!(told(¬ices_), vec![("eve", Reason::Assign, Severity::Info)]); |
| 3101 | assert_eq!(notices_[0].title, "ana assigned you to acme/rocket#3"); |
| 3102 | // Both subscribe whoever they name, never g1t. |
| 3103 | assert_eq!(subscribes(&requested, Some(&pull())), vec![("bo".into(), Reason::ReviewRequested), ("ana".into(), Reason::ReviewRequested)]); |
| 3104 | assert_eq!(subscribes(&assigned, Some(&pull())), vec![("ana".into(), Reason::Assign), ("eve".into(), Reason::Assign)]); |
| 3105 | } |
| 3106 | |
| 3107 | #[test] |
| 3108 | fn failures_go_to_whoever_answers_for_the_change() { |
| 3109 | let failed = event("checks.completed", None, json!({ "number": 7, "status": "failed" })); |
| 3110 | assert_eq!( |
| 3111 | told(¬ices(&failed, "acme/rocket", &Actor::default(), Some(&pull()), &nobody())), |
| 3112 | vec![("ana", Reason::CiActivity, Severity::Error)] |
| 3113 | ); |
| 3114 | // g1t's change is the person's who asked for it, never g1t's. |
| 3115 | let notices_ = notices(&failed, "acme/rocket", &Actor::default(), Some(&g1t_pull()), &nobody()); |
| 3116 | assert_eq!(told(¬ices_), vec![("ana", Reason::CiActivity, Severity::Error)]); |
| 3117 | let errored = event("checks.completed", None, json!({ "number": 7, "status": "errored" })); |
| 3118 | assert_eq!( |
| 3119 | notices(&errored, "acme/rocket", &Actor::default(), Some(&pull()), &nobody())[0].title, |
| 3120 | "Checks could not run on acme/rocket#7" |
| 3121 | ); |
| 3122 | } |
| 3123 | |
| 3124 | #[test] |
| 3125 | fn a_workflow_that_fails_tells_its_pull_requests_owner_even_if_they_pushed() { |
| 3126 | let failed = event("workflow.completed", Some("usr_ana"), json!({ "pull": 7, "workflow": "CI", "conclusion": "failure" })); |
| 3127 | let notices_ = notices(&failed, "acme/rocket", &actor("usr_ana", "ana"), Some(&pull()), &nobody()); |
| 3128 | assert_eq!(told(¬ices_), vec![("ana", Reason::CiActivity, Severity::Error)]); |
| 3129 | assert_eq!(notices_[0].title, "CI failed on acme/rocket#7"); |
| 3130 | // On a branch: whoever pushed. |
| 3131 | let pushed = event( |
| 3132 | "workflow.completed", |
| 3133 | Some("usr_bo"), |
| 3134 | json!({ "workflow": "Deploy", "path": ".g1t/workflows/deploy.yml", "conclusion": "failure", "ref": "refs/heads/main", "number": 12, "sha": "abcdef0123", "runId": "run_9" }), |
| 3135 | ); |
| 3136 | let notices_ = notices(&pushed, "acme/rocket", &actor("usr_bo", "bo"), None, &nobody()); |
| 3137 | assert_eq!(told(¬ices_), vec![("bo", Reason::CiActivity, Severity::Error)]); |
| 3138 | assert_eq!(notices_[0].title, "Deploy failed on main in acme/rocket"); |
| 3139 | assert_eq!(notices_[0].body, "Run 12 at abcdef0"); |
| 3140 | // Nobody to tell when g1t pushed. |
| 3141 | assert!(notices(&pushed, "acme/rocket", &actor("g1t", "g1t"), None, &nobody()).is_empty()); |
| 3142 | // Every failure of a workflow on a branch is one thread. |
| 3143 | let wanted = wants(&pushed).unwrap(); |
| 3144 | let thread = thread_of(&pushed, &wanted, None); |
| 3145 | assert_eq!(thread.key, "rep_1/run/.g1t/workflows/deploy.yml@main"); |
| 3146 | assert_eq!(thread.run_id.as_deref(), Some("run_9")); |
| 3147 | } |
| 3148 | |
| 3149 | #[test] |
| 3150 | fn deployments_tell_whoever_answers_for_them_and_watchers() { |
| 3151 | let failed = event( |
| 3152 | "deployment.failed", |
| 3153 | Some("usr_bo"), |
| 3154 | json!({ "repoId": "rep_1", "projectId": "prj_1", "project": "rocket", "deploymentId": "dpl_1", "error": "The build failed.", "path": "/acme/rocket/deployments/dpl_1" }), |
| 3155 | ); |
| 3156 | let audience = watched(&[("cy", WatchLevel::Custom, &["deployments"]), ("dee", WatchLevel::Custom, &["work_items"]), ("eve", WatchLevel::All, &[])]); |
| 3157 | let notices_ = notices(&failed, "acme/rocket", &actor("usr_bo", "bo"), None, &audience); |
| 3158 | assert_eq!( |
| 3159 | told(¬ices_), |
| 3160 | vec![ |
| 3161 | ("bo", Reason::CiActivity, Severity::Error), |
| 3162 | ("cy", Reason::Subscribed, Severity::Error), |
| 3163 | ("eve", Reason::Subscribed, Severity::Error), |
| 3164 | ] |
| 3165 | ); |
| 3166 | assert_eq!(notices_[0].title, "Production of rocket failed to deploy"); |
| 3167 | assert_eq!(notices_[0].body, "The build failed."); |
| 3168 | let thread = thread_of(&failed, &wants(&failed).unwrap(), None); |
| 3169 | assert_eq!(thread.key, "rep_1/deploy/prj_1/production"); |
| 3170 | assert_eq!(url(Some("acme/rocket"), None, thread.kind, None, None, thread.link.as_deref()), "/acme/rocket/deployments/dpl_1"); |
| 3171 | // A success tells the owner nothing, even after a failure: it |
| 3172 | // settles the failure (settles). Watchers who chose deployments hear of it. |
| 3173 | let live = event("deployment.succeeded", Some("usr_bo"), json!({ "repoId": "rep_1", "projectId": "prj_1", "project": "rocket", "commit": "abcdef0123" })); |
| 3174 | assert!(notices(&live, "acme/rocket", &actor("usr_bo", "bo"), None, &nobody()).is_empty()); |
| 3175 | let recovered = event("deployment.succeeded", Some("usr_bo"), json!({ "repoId": "rep_1", "projectId": "prj_1", "project": "rocket", "recovered": true })); |
| 3176 | assert!(notices(&recovered, "acme/rocket", &actor("usr_bo", "bo"), None, &nobody()).is_empty()); |
| 3177 | let notices_ = notices(&recovered, "acme/rocket", &actor("usr_bo", "bo"), None, &audience); |
| 3178 | assert_eq!(told(¬ices_), vec![("cy", Reason::Subscribed, Severity::Success), ("eve", Reason::Subscribed, Severity::Success)]); |
| 3179 | assert_eq!(notices_[0].title, "Production of rocket is live"); |
| 3180 | // A preview's is the pull request's owner's. |
| 3181 | let preview = event("deployment.failed", None, json!({ "repoId": "rep_1", "projectId": "prj_1", "number": 7, "triggeredBy": "g1t" })); |
| 3182 | assert_eq!(told(¬ices(&preview, "acme/rocket", &Actor::default(), Some(&pull()), &nobody())), vec![("ana", Reason::CiActivity, Severity::Error)]); |
| 3183 | assert_eq!(thread_of(&preview, &wants(&preview).unwrap(), Some(&pull())).key, "rep_1/deploy/prj_1/7"); |
| 3184 | } |
| 3185 | |
| 3186 | /// A scan's summary, as the security service publishes it. |
| 3187 | fn summary(alert_type: &str, opened: &[&str], new: (u32, u32, u32, u32), open: (u32, u32, u32, u32), pusher: Option<&str>) -> Event { |
| 3188 | let counts = |(critical, high, medium, low): (u32, u32, u32, u32)| json!({ "critical": critical, "high": high, "medium": medium, "low": low, "unknown": 0 }); |
| 3189 | let worst = [(new.0, "critical"), (new.1, "high"), (new.2, "medium"), (new.3, "low")].into_iter().find(|(n, _)| *n > 0).map(|(_, name)| name); |
| 3190 | let page = match alert_type { |
| 3191 | "secret_scanning" => "secret-scanning", |
| 3192 | "code_scanning" => "code-scanning", |
| 3193 | _ => "vulnerabilities", |
| 3194 | }; |
| 3195 | event( |
| 3196 | &format!("{alert_type}_alert.summary"), |
| 3197 | None, |
| 3198 | json!({ |
| 3199 | "repoId": "rep_1", "alertType": alert_type, "scan": if pusher.is_some() { "push" } else { "dependencies" }, |
| 3200 | "opened": opened, "openedCount": opened.len(), "fixedCount": 0, "dismissedCount": 0, |
| 3201 | "newBySeverity": counts(new), "open": counts(open), "worst": worst, |
| 3202 | "latest": if opened.is_empty() { serde_json::Value::Null } else { json!("lodash 4.17.20 in package-lock.json: GHSA-1") }, |
| 3203 | "link": format!("/acme/rocket/security/{page}"), |
| 3204 | "pusher": pusher, "blocked": if pusher.is_some() { opened.len() } else { 0 }, |
| 3205 | "notify": ["ana"], "members": ["ana", "bo", "cy"] |
| 3206 | }), |
| 3207 | ) |
| 3208 | } |
| 3209 | |
| 3210 | #[test] |
| 3211 | fn a_scan_is_one_item_per_repository_and_alert_type() { |
| 3212 | let found = summary("vulnerability", &["vul_3", "vul_2", "vul_1"], (1, 2, 0, 0), (1, 2, 0, 0), None); |
| 3213 | assert_eq!(wants(&found), Some(Wanted { repo_id: Some("rep_1".into()), ..Wanted::default() })); |
| 3214 | // cy watches for security alerts and is a member; eve watches |
| 3215 | // everything but cannot see findings; dee watches work items only. |
| 3216 | let audience = watched(&[ |
| 3217 | ("cy", WatchLevel::Custom, &["security"]), |
| 3218 | ("dee", WatchLevel::Custom, &["work_items"]), |
| 3219 | ("eve", WatchLevel::All, &[]), |
| 3220 | ]); |
| 3221 | let notices_ = notices(&found, "acme/rocket", &Actor::default(), None, &audience); |
| 3222 | assert_eq!(told(¬ices_), vec![("ana", Reason::SecurityAlert, Severity::Error), ("cy", Reason::SecurityAlert, Severity::Error)]); |
| 3223 | assert_eq!(notices_[0].title, "3 new vulnerabilities in acme/rocket: 1 critical, 2 high"); |
| 3224 | assert_eq!(notices_[0].body, "lodash 4.17.20 in package-lock.json: GHSA-1"); |
| 3225 | // The same thread for every scan of this type, however many alerts. |
| 3226 | let thread = thread_of(&found, &wants(&found).unwrap(), None); |
| 3227 | assert_eq!(thread.key, "rep_1/security/vulnerability"); |
| 3228 | assert_eq!(url(Some("acme/rocket"), None, thread.kind, None, None, thread.link.as_deref()), "/acme/rocket/security/vulnerabilities"); |
| 3229 | // Medium and low are news, but not urgent: an info item, or the digest. |
| 3230 | let quiet = summary("code_scanning", &["cod_1"], (0, 0, 1, 0), (0, 0, 1, 0), None); |
| 3231 | let notices_ = notices(&quiet, "acme/rocket", &Actor::default(), None, &audience); |
| 3232 | assert_eq!(told(¬ices_), vec![("ana", Reason::SecurityAlert, Severity::Info), ("cy", Reason::SecurityAlert, Severity::Info)]); |
| 3233 | assert_eq!(notices_[0].title, "1 new code scanning alert in acme/rocket: 1 medium"); |
| 3234 | // A scan that opened nothing tells nobody: the thread is brought up to date instead. |
| 3235 | let fixed = summary("vulnerability", &[], (0, 0, 0, 0), (0, 1, 0, 0), None); |
| 3236 | assert!(notices(&fixed, "acme/rocket", &Actor::default(), None, &audience).is_empty()); |
| 3237 | let (title, body) = refreshed_text("acme/rocket", &SecuritySummary { fixed_count: 2, ..security_summary(&fixed).unwrap() }); |
| 3238 | assert_eq!(title, "1 open vulnerability in acme/rocket: 1 high"); |
| 3239 | assert_eq!(body, "2 fixed"); |
| 3240 | let settled = SecuritySummary { fixed_count: 1, dismissed_count: 1, open: SeverityCounts::default(), ..security_summary(&fixed).unwrap() }; |
| 3241 | assert_eq!(refreshed_text("acme/rocket", &settled), ("No open vulnerabilities in acme/rocket".to_owned(), "1 fixed, 1 dismissed".to_owned())); |
| 3242 | // Per-alert events are for webhooks. |
| 3243 | assert_eq!(wants(&event("vulnerability_alert.created", None, json!({ "repoId": "rep_1" }))), None); |
| 3244 | assert_eq!(wants(&event("code_scanning_alert.fixed", None, json!({ "repoId": "rep_1" }))), None); |
| 3245 | } |
| 3246 | |
| 3247 | #[test] |
| 3248 | fn a_refused_push_tells_the_pusher_at_once_and_the_owners_once() { |
| 3249 | let blocked = summary("secret_scanning", &["sec_1", "sec_2"], (2, 0, 0, 0), (2, 0, 0, 0), Some("bo")); |
| 3250 | let notices_ = notices(&blocked, "acme/rocket", &Actor::default(), None, &nobody()); |
| 3251 | assert_eq!(told(¬ices_), vec![("bo", Reason::SecurityAlert, Severity::Error), ("ana", Reason::SecurityAlert, Severity::Error)]); |
| 3252 | assert_eq!(notices_[0].title, "A push to acme/rocket was blocked: it adds 2 secrets"); |
| 3253 | assert_eq!(notices_[1].title, "2 new secrets in acme/rocket: 2 critical"); |
| 3254 | assert_eq!(thread_of(&blocked, &wants(&blocked).unwrap(), None).key, "rep_1/security/secret_scanning"); |
| 3255 | // Whatever bo chose, the push is theirs to fix; ana, an owner, is told whatever she chose. |
| 3256 | let summary_ = security_summary(&blocked).unwrap(); |
| 3257 | let off = InboxSettings { security_alerts: false, security_digest: DigestCadence::Off, ..InboxSettings::default() }; |
| 3258 | assert_eq!(security_delivery(&summary_, "bo", &off), Delivery::Now); |
| 3259 | assert_eq!(security_delivery(&summary_, "ana", &off), Delivery::Now); |
| 3260 | // A watcher who turned security alerts off hears of nothing urgent. |
| 3261 | assert_eq!(security_delivery(&summary_, "cy", &off), Delivery::Never); |
| 3262 | assert_eq!(security_delivery(&summary_, "cy", &InboxSettings::default()), Delivery::Now); |
| 3263 | } |
| 3264 | |
| 3265 | #[test] |
| 3266 | fn what_is_not_urgent_waits_for_the_digest_unless_the_person_chose_otherwise() { |
| 3267 | let medium = security_summary(&summary("vulnerability", &["vul_1"], (0, 0, 1, 0), (0, 0, 1, 0), None)).unwrap(); |
| 3268 | assert!(!medium.urgent()); |
| 3269 | let choose = |cadence| InboxSettings { security_digest: cadence, ..InboxSettings::default() }; |
| 3270 | // Owners too: a medium alert is for the digest, as they chose. |
| 3271 | assert_eq!(security_delivery(&medium, "ana", &choose(DigestCadence::Daily)), Delivery::Digest); |
| 3272 | assert_eq!(security_delivery(&medium, "cy", &choose(DigestCadence::Weekly)), Delivery::Digest); |
| 3273 | assert_eq!(security_delivery(&medium, "cy", &choose(DigestCadence::AtOnce)), Delivery::Now); |
| 3274 | assert_eq!(security_delivery(&medium, "ana", &choose(DigestCadence::Off)), Delivery::Never); |
| 3275 | let high = security_summary(&summary("vulnerability", &["vul_1"], (0, 1, 0, 0), (0, 1, 0, 0), None)).unwrap(); |
| 3276 | assert_eq!(security_delivery(&high, "ana", &choose(DigestCadence::Off)), Delivery::Now); |
| 3277 | assert_eq!(breakdown(&SeverityCounts { critical: 1, low: 3, ..SeverityCounts::default() }), "1 critical, 3 low"); |
| 3278 | assert_eq!(breakdown(&SeverityCounts::default()), ""); |
| 3279 | } |
| 3280 | |
| 3281 | #[test] |
| 3282 | fn bypass_requests_reports_and_advisories_tell_who_they_name() { |
| 3283 | let audience = watched(&[("cy", WatchLevel::Custom, &["security"]), ("eve", WatchLevel::All, &[])]); |
| 3284 | // A bypass request goes to the reviewers named, never to watchers. |
| 3285 | let requested = event( |
| 3286 | "secret_scanning.bypass_requested", |
| 3287 | Some("usr_bo"), |
| 3288 | json!({ "repoId": "rep_1", "alertId": "sec_1", "requestId": "byp_1", "title": "An AWS access key in a.env", "notify": ["ana"], "link": "/acme/-/security/bypass-requests" }), |
| 3289 | ); |
| 3290 | let notices_ = notices(&requested, "acme/rocket", &actor("usr_bo", "bo"), None, &audience); |
| 3291 | assert_eq!(told(¬ices_), vec![("ana", Reason::SecurityAlert, Severity::Warning)]); |
| 3292 | assert_eq!(notices_[0].title, "bo asked to bypass push protection in acme/rocket"); |
| 3293 | assert_eq!(thread_of(&requested, &wants(&requested).unwrap(), None).key, "rep_1/security/byp_1"); |
| 3294 | // A private report is for the owners and security managers, at once, with no reporter named. |
| 3295 | let reported = event( |
| 3296 | "security_advisory.reported", |
| 3297 | None, |
| 3298 | json!({ "repoId": "rep_1", "id": "vrp_1", "title": "XSS in the search box", "state": "new", "link": "/acme/rocket/security/reports", "notify": ["ana"], "members": ["ana", "cy"] }), |
| 3299 | ); |
| 3300 | let notices_ = notices(&reported, "acme/rocket", &Actor::default(), None, &audience); |
| 3301 | assert_eq!(told(¬ices_), vec![("ana", Reason::SecurityAlert, Severity::Warning)]); |
| 3302 | assert_eq!(notices_[0].title, "A vulnerability was reported privately to acme/rocket"); |
| 3303 | assert_eq!(thread_of(&reported, &wants(&reported).unwrap(), None).key, "rep_1/security/reports"); |
| 3304 | // A published advisory is for watchers who chose security; it is public, so no members list is needed. |
| 3305 | let published = event( |
| 3306 | "security_advisory.published", |
| 3307 | Some("usr_ana"), |
| 3308 | json!({ "repoId": "rep_1", "id": "adv_1", "g1tsaId": "G1TSA-2026-abcd-efgh", "title": "XSS in the search box", "severity": "high", "state": "published", "link": "/acme/rocket/security/advisories/G1TSA-2026-abcd-efgh" }), |
| 3309 | ); |
| 3310 | let notices_ = notices(&published, "acme/rocket", &actor("usr_ana", "ana"), None, &audience); |
| 3311 | assert_eq!(told(¬ices_), vec![("cy", Reason::Subscribed, Severity::Info), ("eve", Reason::Subscribed, Severity::Info)]); |
| 3312 | assert_eq!(thread_of(&published, &wants(&published).unwrap(), None).key, "rep_1/security/advisories/adv_1"); |
| 3313 | } |
| 3314 | |
| 3315 | #[test] |
| 3316 | fn nobody_hears_of_what_they_did_themselves() { |
| 3317 | let merged = event("pull.merged", Some("usr_ana"), json!({ "number": 7 })); |
| 3318 | let by_ana = notices(&merged, "acme/rocket", &actor("usr_ana", "ana"), Some(&pull()), &nobody()); |
| 3319 | // The assignee still hears; ana, who merged, does not. |
| 3320 | assert_eq!(told(&by_ana), vec![("bo", Reason::StateChange, Severity::Success)]); |
| 3321 | let by_bo = notices(&merged, "acme/rocket", &actor("usr_bo", "bo"), Some(&pull()), &nobody()); |
| 3322 | assert_eq!(told(&by_bo), vec![("ana", Reason::StateChange, Severity::Success)]); |
| 3323 | assert_eq!(by_bo[0].title, "bo merged acme/rocket#7"); |
| 3324 | let by_queue = notices(&merged, "acme/rocket", &Actor::default(), Some(&pull()), &nobody()); |
| 3325 | assert_eq!(by_queue[0].title, "acme/rocket#7 was merged"); |
| 3326 | } |
| 3327 | |
| 3328 | #[test] |
| 3329 | fn closing_and_reopening_tells_everyone_subscribed_and_watchers() { |
| 3330 | let closed = event("work_item.closed", Some("usr_bo"), json!({ "number": 3, "reason": "completed" })); |
| 3331 | let item = InboxSubject { |
| 3332 | kind: Some(SubjectKind::Item), |
| 3333 | title: "Crash".into(), |
| 3334 | author: person("usr_cy", "cy"), |
| 3335 | assignees: vec!["bo".into()], |
| 3336 | ..InboxSubject::default() |
| 3337 | }; |
| 3338 | let mut audience = subscribed(&[("eve", State::Subscribed, Some(Reason::Comment)), ("fay", State::Unsubscribed, None)]); |
| 3339 | audience.watchers = watched(&[("gus", WatchLevel::All, &[]), ("hal", WatchLevel::Custom, &["pulls"])]).watchers; |
| 3340 | let notices_ = notices(&closed, "acme", &actor("usr_bo", "bo"), Some(&item), &audience); |
| 3341 | assert_eq!( |
| 3342 | told(¬ices_), |
| 3343 | vec![ |
| 3344 | ("cy", Reason::StateChange, Severity::Info), |
| 3345 | ("eve", Reason::StateChange, Severity::Info), |
| 3346 | ("gus", Reason::Subscribed, Severity::Info), |
| 3347 | ] |
| 3348 | ); |
| 3349 | assert_eq!(notices_[0].title, "bo closed acme#3"); |
| 3350 | let by_pull = event("work_item.closed", None, json!({ "number": 3, "resolution": { "repo": "acme/rocket", "commit": "1a2b3c4d5e" } })); |
| 3351 | assert_eq!(notices(&by_pull, "acme", &Actor::default(), Some(&item), &nobody())[0].title, "acme#3 was closed by acme/rocket@1a2b3c4"); |
| 3352 | let reopened = event("work_item.reopened", Some("usr_cy"), json!({ "number": 3 })); |
| 3353 | assert_eq!(told(¬ices(&reopened, "acme", &actor("usr_cy", "cy"), Some(&item), &nobody())), vec![("bo", Reason::StateChange, Severity::Info)]); |
| 3354 | } |
| 3355 | |
| 3356 | #[test] |
| 3357 | fn opening_tells_who_it_names_and_watchers_of_its_kind() { |
| 3358 | let opened = event("pull.opened", Some("usr_ana"), json!({ "number": 7 })); |
| 3359 | let subject = InboxSubject { reviewers: vec!["cy".into(), "g1t".into()], ..pull() }; |
| 3360 | let audience = watched(&[("bo", WatchLevel::All, &[]), ("dee", WatchLevel::Custom, &["work_items"]), ("eve", WatchLevel::Custom, &["pulls"]), ("fay", WatchLevel::Participating, &[])]); |
| 3361 | let notices_ = notices(&opened, "acme/rocket", &actor("usr_ana", "ana"), Some(&subject), &audience); |
| 3362 | assert_eq!( |
| 3363 | told(¬ices_), |
| 3364 | vec![ |
| 3365 | ("bo", Reason::Assign, Severity::Info), |
| 3366 | ("cy", Reason::ReviewRequested, Severity::Warning), |
| 3367 | ("eve", Reason::Subscribed, Severity::Info), |
| 3368 | ] |
| 3369 | ); |
| 3370 | assert_eq!(notices_[2].title, "ana opened acme/rocket#7"); |
| 3371 | } |
| 3372 | |
| 3373 | #[test] |
| 3374 | fn ignoring_a_repository_silences_it_and_unsubscribing_keeps_only_what_is_asked() { |
| 3375 | let created = event("comment.created", Some("usr_bo"), json!({ "number": 7, "commentId": "cmt_1" })); |
| 3376 | let on = comment(person("usr_bo", "bo"), "@cy have a look", &["cy"]); |
| 3377 | let audience = watched(&[("cy", WatchLevel::Ignore, &[]), ("ana", WatchLevel::All, &[])]); |
| 3378 | assert!(notices(&created, "acme/rocket", &actor("usr_bo", "bo"), Some(&on), &audience).iter().all(|notice| notice.username != "cy")); |
| 3379 | let audience = subscribed(&[("cy", State::Unsubscribed, None), ("ana", State::Unsubscribed, None)]); |
| 3380 | let notices_ = notices(&created, "acme/rocket", &actor("usr_bo", "bo"), Some(&on), &audience); |
| 3381 | // cy was mentioned, which is asked of them; ana unsubscribed from the conversation. |
| 3382 | assert_eq!(told(¬ices_), vec![("cy", Reason::Mention, Severity::Info)]); |
| 3383 | } |
| 3384 | |
| 3385 | #[test] |
| 3386 | fn an_agent_s_review_is_shown_by_its_name_and_marked_advisory() { |
| 3387 | // Margo (@margo), acting for bo, asks for changes on ana's pull request. |
| 3388 | let created = event("comment.created", Some("usr_bo"), json!({ "number": 7, "commentId": "cmt_1" })); |
| 3389 | let mut on = comment(person("agt_1", "ana"), "Trim the name.", &[]); |
| 3390 | if let Some(said) = on.comment.as_mut() { |
| 3391 | said.agent = Some(g1t_contracts::work::AgentRef { |
| 3392 | id: "agt_1".into(), |
| 3393 | handle: "ana".into(), |
| 3394 | display_name: "Margo".into(), |
| 3395 | avatar_seed: "margo".into(), |
| 3396 | }); |
| 3397 | said.acting_for = Some(person("usr_bo", "bo")); |
| 3398 | said.verdict = Some("request_changes".into()); |
| 3399 | said.advisory = true; |
| 3400 | } |
| 3401 | let notices_ = notices(&created, "acme/rocket", &actor("usr_bo", "bo"), Some(&on), &nobody()); |
| 3402 | // Its handle sharing ana's name leaves nobody out: ana owns it and hears. |
| 3403 | assert!(told(¬ices_).contains(&("ana", Reason::Author, Severity::Info))); |
| 3404 | assert_eq!(notices_[0].title, "Margo (agent) asked for changes on acme/rocket#7 (advisory)"); |
| 3405 | // An agent subscribes nobody by its handle. |
| 3406 | assert!(subscribes(&created, Some(&on)).iter().all(|(name, _)| name != "ana")); |
| 3407 | } |
| 3408 | |
| 3409 | #[test] |
| 3410 | fn comments_tell_those_mentioned_then_everyone_subscribed_never_the_writer() { |
| 3411 | let created = event("comment.created", Some("usr_bo"), json!({ "number": 7, "commentId": "cmt_1" })); |
| 3412 | let on = comment(person("usr_bo", "bo"), "@cy @bo have a look", &["cy", "bo", "g1t"]); |
| 3413 | let audience = subscribed(&[("eve", State::Subscribed, Some(Reason::Comment)), ("fay", State::Subscribed, Some(Reason::Manual))]); |
| 3414 | let notices_ = notices(&created, "acme/rocket", &actor("usr_bo", "bo"), Some(&on), &audience); |
| 3415 | assert_eq!( |
| 3416 | told(¬ices_), |
| 3417 | vec![ |
| 3418 | ("cy", Reason::Mention, Severity::Info), |
| 3419 | ("ana", Reason::Author, Severity::Info), |
| 3420 | ("eve", Reason::Comment, Severity::Info), |
| 3421 | ("fay", Reason::Manual, Severity::Info), |
| 3422 | ] |
| 3423 | ); |
| 3424 | assert_eq!(notices_[0].title, "bo mentioned you on acme/rocket#7"); |
| 3425 | assert_eq!(notices_[1].title, "bo commented on acme/rocket#7"); |
| 3426 | assert_eq!(notices_[0].body, "@cy @bo have a look"); |
| 3427 | // Mentioned and the owner: told once, as mentioned. |
| 3428 | let on = comment(person("usr_bo", "bo"), "@ana", &["ana"]); |
| 3429 | assert_eq!( |
| 3430 | told(¬ices(&created, "acme/rocket", &actor("usr_bo", "bo"), Some(&on), &nobody())), |
| 3431 | vec![("ana", Reason::Mention, Severity::Info)] |
| 3432 | ); |
| 3433 | // The owner's own comment tells the assignee, not the owner. |
| 3434 | let on = comment(person("usr_ana", "ana"), "thanks", &[]); |
| 3435 | assert_eq!( |
| 3436 | told(¬ices(&created, "acme/rocket", &actor("usr_ana", "ana"), Some(&on), &nobody())), |
| 3437 | vec![("bo", Reason::Assign, Severity::Info)] |
| 3438 | ); |
| 3439 | // Something that happened, not something written, tells nobody. |
| 3440 | let mut on = comment(person("usr_bo", "bo"), "assigned cy", &[]); |
| 3441 | on.comment.as_mut().unwrap().event = true; |
| 3442 | assert!(notices(&created, "acme/rocket", &actor("usr_bo", "bo"), Some(&on), &nobody()).is_empty()); |
| 3443 | // An approval is good news. |
| 3444 | let mut on = comment(person("usr_cy", "cy"), "", &[]); |
| 3445 | on.comment.as_mut().unwrap().verdict = Some("approve".into()); |
| 3446 | let notices_ = notices(&created, "acme/rocket", &actor("usr_cy", "cy"), Some(&on), &nobody()); |
| 3447 | assert_eq!(told(¬ices_)[0], ("ana", Reason::Author, Severity::Success)); |
| 3448 | assert_eq!(notices_[0].body, "Add the inbox"); |
| 3449 | // Writing and being mentioned subscribe, never g1t. |
| 3450 | let on = comment(person("usr_bo", "bo"), "@cy", &["cy"]); |
| 3451 | assert_eq!(subscribes(&created, Some(&on)), vec![("bo".into(), Reason::Comment), ("cy".into(), Reason::Mention)]); |
| 3452 | let on = comment(person(AGENT_ID, "g1t"), "done", &[]); |
| 3453 | assert!(subscribes(&created, Some(&on)).is_empty()); |
| 3454 | } |
| 3455 | |
| 3456 | #[test] |
| 3457 | fn a_commit_comment_tells_who_it_mentions_and_the_commit_s_author() { |
| 3458 | let created = event( |
| 3459 | "commit_comment.created", |
| 3460 | Some("usr_bo"), |
| 3461 | json!({ |
| 3462 | "repoId": "rep_1", "commit": "abcdef1234567890", "link": "/acme/rocket/commit/abcdef1234567890", |
| 3463 | "excerpt": "@cy why this?", "mentions": ["cy", "bo"], "commitAuthor": "ana", |
| 3464 | "teamMentions": [{ "team": "acme/web", "members": ["dee", "cy"] }], |
| 3465 | }), |
| 3466 | ); |
| 3467 | let wanted = wants(&created).unwrap(); |
| 3468 | assert_eq!(wanted.number, None); |
| 3469 | let thread = thread_of(&created, &wanted, None); |
| 3470 | assert_eq!(thread.key, "rep_1/commit/abcdef1234567890"); |
| 3471 | assert_eq!(url(Some("acme/rocket"), None, thread.kind, thread.number, None, thread.link.as_deref()), "/acme/rocket/commit/abcdef1234567890"); |
| 3472 | let notices_ = notices(&created, "acme/rocket", &actor("usr_bo", "bo"), None, &nobody()); |
| 3473 | assert_eq!( |
| 3474 | told(¬ices_), |
| 3475 | vec![ |
| 3476 | ("cy", Reason::Mention, Severity::Info), |
| 3477 | ("dee", Reason::TeamMention, Severity::Info), |
| 3478 | ("ana", Reason::Author, Severity::Info), |
| 3479 | ] |
| 3480 | ); |
| 3481 | assert_eq!(notices_[0].title, "bo mentioned you on acme/rocket@abcdef1"); |
| 3482 | assert_eq!(notices_[2].title, "bo commented on your commit acme/rocket@abcdef1"); |
| 3483 | assert_eq!(notices_[0].body, "@cy why this?"); |
| 3484 | } |
| 3485 | |
| 3486 | #[test] |
| 3487 | fn pull_requests_are_one_thread_each() { |
| 3488 | let created = event("comment.created", Some("usr_bo"), json!({ "repoId": "rep_1", "number": 7, "commentId": "cmt_1" })); |
| 3489 | let wanted = wants(&created).unwrap(); |
| 3490 | let thread = thread_of(&created, &wanted, Some(&pull())); |
| 3491 | assert_eq!(thread.key, "rep_1#7"); |
| 3492 | assert_eq!(thread.kind, Some(SubjectKind::Pull)); |
| 3493 | let merged = event("pull.merged", None, json!({ "repoId": "rep_1", "number": 7 })); |
| 3494 | assert_eq!(thread_of(&merged, &wants(&merged).unwrap(), Some(&pull())).key, thread.key); |
| 3495 | } |
| 3496 | |
| 3497 | #[test] |
| 3498 | fn items_link_to_what_they_are_about() { |
| 3499 | assert_eq!(url(Some("acme/rocket"), None, Some(SubjectKind::Pull), Some(7), None, None), "/acme/rocket/pull/7"); |
| 3500 | assert_eq!(url(Some("acme/rocket"), Some("acme"), Some(SubjectKind::Item), Some(3), None, None), "/acme/-/work/3"); |
| 3501 | assert_eq!(url(None, Some("acme"), Some(SubjectKind::Item), Some(3), None, None), "/acme/-/work/3"); |
| 3502 | assert_eq!(url(Some("acme/rocket"), None, Some(SubjectKind::Run), None, Some("run_1"), None), "/acme/rocket/actions/runs/run_1"); |
| 3503 | assert_eq!(url(Some("acme/rocket"), None, Some(SubjectKind::Deploy), None, None, Some("/acme/site/deployments/dpl_1")), "/acme/site/deployments/dpl_1"); |
| 3504 | assert_eq!(url(Some("acme/rocket"), None, None, None, None, None), "/acme/rocket"); |
| 3505 | assert_eq!(url(None, None, None, None, None, None), "/inbox"); |
| 3506 | } |
| 3507 | |
| 3508 | #[test] |
| 3509 | fn long_titles_are_cut_to_a_line() { |
| 3510 | let long = "x".repeat(400); |
| 3511 | assert_eq!(clip(&long, MAX_TITLE).chars().count(), MAX_TITLE); |
| 3512 | assert_eq!(clip(" short ", MAX_TITLE), "short"); |
| 3513 | } |
| 3514 | |
| 3515 | #[test] |
| 3516 | fn marks_change_only_what_they_say() { |
| 3517 | assert_eq!(mark_change(InboxMark::Read), "read_at = COALESCE(read_at, ?1)"); |
| 3518 | assert!(mark_change(InboxMark::Done).contains("done_at = ?1")); |
| 3519 | assert_eq!(mark_change(InboxMark::Unsnooze), "snoozed_until = NULL"); |
| 3520 | assert!(ranked(&ListInboxArgs::default())); |
| 3521 | assert!(!ranked(&ListInboxArgs { reason: Some(Reason::Mention), ..ListInboxArgs::default() })); |
| 3522 | assert!(!ranked(&ListInboxArgs { participating: true, ..ListInboxArgs::default() })); |
| 3523 | } |
| 3524 | |
| 3525 | #[test] |
| 3526 | fn filters_bind_in_order_after_what_is_bound() { |
| 3527 | let a = ListInboxArgs { |
| 3528 | reason: Some(Reason::Mention), |
| 3529 | repo_id: Some("rep_1".into()), |
| 3530 | participating: true, |
| 3531 | unread: true, |
| 3532 | ..ListInboxArgs::default() |
| 3533 | }; |
| 3534 | // Two values come first: the username and now. |
| 3535 | let (conditions, values) = filters(&a, 2); |
| 3536 | assert_eq!( |
| 3537 | conditions, |
| 3538 | vec!["reason = ?3", "repo_id = ?4", "reason NOT IN ('manual', 'subscribed')", "read_at IS NULL"] |
| 3539 | ); |
| 3540 | assert_eq!(values, vec!["mention", "rep_1"]); |
| 3541 | } |
| 3542 | |
| 3543 | #[test] |
| 3544 | fn the_bump_keeps_whatever_is_most_urgent_while_unread() { |
| 3545 | assert!(BUMP.contains("WHERE NOT EXISTS (SELECT 1 FROM inbox_activity WHERE event_id = ?4 AND username = ?2)")); |
| 3546 | assert!(BUMP.contains("ON CONFLICT (username, thread) DO UPDATE")); |
| 3547 | assert!(BUMP.contains("activity = inbox_items.activity + 1")); |
| 3548 | // Its numbered parameters run from 1 to 19. |
| 3549 | for at in 1..=19 { |
| 3550 | assert!(BUMP.contains(&format!("?{at}")), "?{at}"); |
| 3551 | } |
| 3552 | assert!(!BUMP.contains("?20")); |
| 3553 | } |
| 3554 | |
| 3555 | #[test] |
| 3556 | fn live_notifications_say_what_and_where() { |
| 3557 | let notice = Notice { |
| 3558 | username: "ana".into(), |
| 3559 | reason: Reason::Agent, |
| 3560 | severity: Severity::Warning, |
| 3561 | title: "g1t needs you on acme/api#4".into(), |
| 3562 | body: "Which database?".into(), |
| 3563 | }; |
| 3564 | let live = live_notification("evt_1", ¬ice, "/Acme/api/pull/4#c1", "2026-10-08T00:00:00Z", Some("rep_1#4")); |
| 3565 | assert_eq!(live["id"], "inbox:evt_1"); |
| 3566 | // A stop that needs a person is an ordinary inbox item. |
| 3567 | assert_eq!(live["kind"], "inbox"); |
| 3568 | assert_eq!(live["workspace"], "acme"); |
| 3569 | assert_eq!(live["href"], "/Acme/api/pull/4#c1"); |
| 3570 | assert_eq!(live["actor"]["name"], "acme/api"); |
| 3571 | // Notify keeps the thread, to stop replaying it once it settles. |
| 3572 | assert_eq!(live["inbox_thread"], "rep_1#4"); |
| 3573 | let mention = Notice { reason: Reason::TeamMention, ..notice }; |
| 3574 | assert_eq!(live_notification("evt_2", &mention, "https://elsewhere", "t", None)["href"], "/inbox"); |
| 3575 | assert_eq!(live_notification("evt_2", &mention, "/x", "t", None)["kind"], "mention"); |
| 3576 | } |
| 3577 | |
| 3578 | #[test] |
| 3579 | fn inbox_counts_are_told_as_they_are_by_username() { |
| 3580 | assert_eq!(inbox_count_update("Ana", 3), serde_json::json!({ "username": "ana", "unread": 3 })); |
| 3581 | assert_eq!(inbox_count_update("bo", 0)["unread"], 0); |
| 3582 | // What settled is told with the count, each thread once. |
| 3583 | let threads = vec!["rep_1#7".to_owned(), "rep_1/deploy/*/7".to_owned(), "rep_1#7".to_owned()]; |
| 3584 | assert_eq!( |
| 3585 | inbox_settled_update("Ana", 2, &threads), |
| 3586 | serde_json::json!({ "username": "ana", "unread": 2, "settled": ["rep_1#7", "rep_1/deploy/*/7"] }) |
| 3587 | ); |
| 3588 | } |
| 3589 | |
| 3590 | #[test] |
| 3591 | fn a_settle_says_why_and_who_and_clears_on_new_activity() { |
| 3592 | let settle = Settle::thread("rep_1#7").saying("Merged", Some("@Ana")); |
| 3593 | assert_eq!(settle.why.as_deref(), Some("Merged")); |
| 3594 | assert_eq!(settle.by.as_deref(), Some("ana")); |
| 3595 | assert_eq!(Settle::thread("rep_1#7").saying("Checks passed", Some(" ")).by, None); |
| 3596 | // New activity brings a thread back with no reason left on it, and so does marking it by hand. |
| 3597 | assert!(BUMP.contains("settled_reason = NULL")); |
| 3598 | assert!(mark_change(InboxMark::Done).contains("settled_reason = NULL")); |
| 3599 | assert!(mark_change(InboxMark::Undone).contains("settled_reason = NULL")); |
| 3600 | } |
| 3601 | |
| 3602 | #[test] |
| 3603 | fn token_approvals_tell_the_people_named_about_no_repository() { |
| 3604 | let mut asked = event( |
| 3605 | "token.approval_requested", |
| 3606 | Some("usr_ana"), |
| 3607 | json!({ "workspace": "acme", "tokenId": "tok_1", "notify": ["Bo", "cy", "bo", "g1t"], "title": "ana asks", "body": "ci: contents: write", "link": "/acme/-/settings/tokens" }), |
| 3608 | ); |
| 3609 | asked.repo_id = None; |
| 3610 | let (thread, told) = workspace_notices(&asked, None); |
| 3611 | assert_eq!(thread, "workspace:acme/token/tok_1"); |
| 3612 | let mut names: Vec<&str> = told.iter().map(|notice| notice.username.as_str()).collect(); |
| 3613 | names.sort(); |
| 3614 | assert_eq!(names, ["bo", "cy"], "each once, lowercased, never g1t"); |
| 3615 | assert!(told.iter().all(|notice| notice.reason == Reason::ReviewRequested && notice.severity == Severity::Warning)); |
| 3616 | assert!(wants(&asked).is_none(), "about no repository"); |
| 3617 | let reviewed = event("token.approval_reviewed", None, json!({ "workspace": "acme", "tokenId": "tok_1", "notify": ["ana"], "title": "approved" })); |
| 3618 | let (_, told) = workspace_notices(&reviewed, None); |
| 3619 | assert_eq!(told[0].reason, Reason::Author); |
| 3620 | assert!(WORKSPACE_EVENTS.contains(&"token.approval_reviewed")); |
| 3621 | } |
| 3622 | |
| 3623 | #[test] |
| 3624 | fn a_workspace_invitation_asks_its_person_and_tells_whoever_sent_it_the_answer() { |
| 3625 | let mut sent = event( |
| 3626 | "workspace_invitation.created", |
| 3627 | Some("usr_owner"), |
| 3628 | json!({ "workspace": "flagon-io", "invitationId": "inv_1", "thread": "invitation:inv_1", "notify": ["daweazl"], "title": "@syntaqx invited you to join Flagon, Inc.", "link": "/invitations" }), |
| 3629 | ); |
| 3630 | sent.repo_id = None; |
| 3631 | let (thread, told) = workspace_notices(&sent, None); |
| 3632 | assert_eq!(thread, "invitation:inv_1"); |
| 3633 | assert_eq!(told.len(), 1); |
| 3634 | assert_eq!((told[0].username.as_str(), told[0].reason, told[0].severity), ("daweazl", Reason::ReviewRequested, Severity::Warning)); |
| 3635 | let accepted = event("workspace_invitation.accepted", None, json!({ "workspace": "flagon-io", "thread": "invitation:inv_1", "notify": ["syntaqx"] })); |
| 3636 | let (thread, told) = workspace_notices(&accepted, None); |
| 3637 | assert_eq!(thread, "invitation:inv_1"); |
| 3638 | assert_eq!((told[0].reason, told[0].severity), (Reason::Author, Severity::Success)); |
| 3639 | let declined = event("workspace_invitation.declined", None, json!({ "workspace": "flagon-io", "thread": "invitation:inv_1", "notify": ["syntaqx"] })); |
| 3640 | assert_eq!(workspace_notices(&declined, None).1[0].severity, Severity::Info); |
| 3641 | // Answered or revoked, the person's item is done; a revocation tells nobody. |
| 3642 | for kind in ["workspace_invitation.accepted", "workspace_invitation.declined", "workspace_invitation.revoked"] { |
| 3643 | assert!(INVITATION_ANSWERED.contains(&kind)); |
| 3644 | } |
| 3645 | assert!(!WORKSPACE_EVENTS.contains(&"workspace_invitation.revoked")); |
| 3646 | } |
| 3647 | } |