| 1 | /** |
| 2 | * CODEOWNERS on the site: a file's problems listed like a linter's, and on |
| 3 | * a pull request, who owns what it changes and whose approval it still |
| 4 | * needs. Teams are named `@workspace/team` and link to their pages. |
| 5 | */ |
| 6 | import { CircleCheck, CircleDashed, CircleSlash, FileWarning, Hourglass, ShieldCheck, Users } from "lucide-react"; |
| 7 | import { Link } from "react-router"; |
| 8 | |
| 9 | import { |
| 10 | CODEOWNERS_ERROR_LABELS, |
| 11 | CODEOWNERS_LOCATIONS, |
| 12 | type CodeownersError, |
| 13 | type CodeownersReport, |
| 14 | type OwnerReview, |
| 15 | type PullCodeOwners, |
| 16 | } from "@g1t/contracts"; |
| 17 | |
| 18 | import { Badge } from "./ui/badge"; |
| 19 | import { Card } from "./ui/card"; |
| 20 | import { Skeleton } from "./ui/skeleton"; |
| 21 | import { UserCard } from "./user-card"; |
| 22 | |
| 23 | /** The guide to the file. */ |
| 24 | export const CODEOWNERS_DOCS = "https://docs.g1t.sh/guides/codeowners/"; |
| 25 | |
| 26 | /** Where a file at `path` on `ref` is shown, optionally at a line. */ |
| 27 | export function blobHref(base: string, ref: string, path: string, line?: number): string { |
| 28 | return `${base}/blob/${encodeURIComponent(ref)}/${path}${line ? `#L${line}` : ""}`; |
| 29 | } |
| 30 | |
| 31 | /** A team's page, from `workspace/slug` (with or without the `@`). */ |
| 32 | export function teamHref(handle: string): string { |
| 33 | const [workspace, slug] = handle.replace(/^@/, "").split("/"); |
| 34 | return `/${workspace}/-/teams/${slug}`; |
| 35 | } |
| 36 | |
| 37 | /** An owner as written: a person, a team, or an email address, linked where it can be. */ |
| 38 | export function OwnerLink({ owner }: { owner: string }) { |
| 39 | const name = owner.replace(/^@/, ""); |
| 40 | const className = "font-mono text-xs text-fg-soft hover:text-accent hover:underline"; |
| 41 | if (owner.startsWith("@") && name.includes("/")) { |
| 42 | return ( |
| 43 | <Link to={teamHref(name)} className={className}> |
| 44 | {owner} |
| 45 | </Link> |
| 46 | ); |
| 47 | } |
| 48 | if (owner.startsWith("@") && /^[a-z0-9-]{1,39}$/i.test(name) && name !== "g1t") { |
| 49 | return ( |
| 50 | <UserCard username={name.toLowerCase()}> |
| 51 | <Link to={`/u/${name.toLowerCase()}`} className={className}> |
| 52 | {owner} |
| 53 | </Link> |
| 54 | </UserCard> |
| 55 | ); |
| 56 | } |
| 57 | return <span className="font-mono text-xs text-fg-soft">{owner}</span>; |
| 58 | } |
| 59 | |
| 60 | /** A team asked to review: `@workspace/team`, linking to its page. */ |
| 61 | export function TeamReviewer({ team }: { team: string }) { |
| 62 | return ( |
| 63 | <li className="flex items-center gap-2 px-1"> |
| 64 | <span className="flex size-5 shrink-0 items-center justify-center rounded bg-raised text-muted ring-1 ring-line"> |
| 65 | <Users size={12} /> |
| 66 | </span> |
| 67 | <Link to={teamHref(team)} className="grow truncate font-mono text-xs hover:text-accent hover:underline"> |
| 68 | @{team} |
| 69 | </Link> |
| 70 | <span className="text-xs text-faint">Review requested</span> |
| 71 | </li> |
| 72 | ); |
| 73 | } |
| 74 | |
| 75 | /** A file's problems, one row each: the line, what kind, the token at fault, and why. */ |
| 76 | export function CodeownersErrorList({ errors, lineHref }: { errors: CodeownersError[]; lineHref: (line: number) => string | null }) { |
| 77 | return ( |
| 78 | <ul className="divide-y divide-line"> |
| 79 | {errors.map((error, index) => { |
| 80 | const href = error.line > 0 ? lineHref(error.line) : null; |
| 81 | return ( |
| 82 | <li key={`${error.line}-${index}`} className="flex flex-wrap items-baseline gap-x-3 gap-y-1 px-4 py-2.5 text-sm"> |
| 83 | <span className="w-14 shrink-0 font-mono text-xs text-faint"> |
| 84 | {error.line === 0 ? ( |
| 85 | "File" |
| 86 | ) : href ? ( |
| 87 | <Link to={href} className="hover:text-accent hover:underline"> |
| 88 | Line {error.line} |
| 89 | </Link> |
| 90 | ) : ( |
| 91 | `Line ${error.line}` |
| 92 | )} |
| 93 | </span> |
| 94 | <Badge tone="danger">{CODEOWNERS_ERROR_LABELS[error.kind] ?? error.kind}</Badge> |
| 95 | {error.token && <code className="min-w-0 truncate font-mono text-xs text-fg">{error.token}</code>} |
| 96 | <span className="min-w-0 basis-full text-muted sm:pl-17">{error.message}</span> |
| 97 | </li> |
| 98 | ); |
| 99 | })} |
| 100 | </ul> |
| 101 | ); |
| 102 | } |
| 103 | |
| 104 | /** The file a branch's code owners come from, and what is wrong with it: Settings → Branches and merging. */ |
| 105 | export function CodeownersReportPanel({ report, base, branch }: { report: CodeownersReport | null; base: string; branch: string }) { |
| 106 | if (!report) { |
| 107 | return ( |
| 108 | <Card asChild className="p-4 text-sm text-muted"> |
| 109 | <p> |
| 110 | The CODEOWNERS file could not be read just now. Reload the page to try again. |
| 111 | </p> |
| 112 | </Card> |
| 113 | ); |
| 114 | } |
| 115 | if (!report.path) { |
| 116 | return ( |
| 117 | <Card tone="plain" className="border-dashed p-4 text-sm"> |
| 118 | <p className="font-medium">No CODEOWNERS file</p> |
| 119 | <p className="mt-1 text-muted"> |
| 120 | g1t looks on {branch} for the first of these, and asks the owners it names to review changes to their files: |
| 121 | </p> |
| 122 | <ul className="mt-2 flex flex-wrap gap-1.5"> |
| 123 | {CODEOWNERS_LOCATIONS.map((location) => ( |
| 124 | <li key={location}> |
| 125 | <code className="rounded border border-line bg-bg px-1.5 py-0.5 font-mono text-xs">{location}</code> |
| 126 | </li> |
| 127 | ))} |
| 128 | </ul> |
| 129 | <p className="mt-3"> |
| 130 | <a href={CODEOWNERS_DOCS} className="text-accent hover:underline"> |
| 131 | How to write one |
| 132 | </a> |
| 133 | </p> |
| 134 | </Card> |
| 135 | ); |
| 136 | } |
| 137 | const path = report.path; |
| 138 | const errors = report.errors.length; |
| 139 | return ( |
| 140 | <Card tone="plain" className="overflow-hidden"> |
| 141 | <div className="flex flex-wrap items-center gap-x-3 gap-y-1 bg-surface px-4 py-3 text-sm"> |
| 142 | {errors > 0 ? ( |
| 143 | <FileWarning size={16} className="shrink-0 text-danger" /> |
| 144 | ) : ( |
| 145 | <ShieldCheck size={16} className="shrink-0 text-success" /> |
| 146 | )} |
| 147 | <Link to={blobHref(base, branch, path)} className="font-mono text-sm hover:text-accent hover:underline"> |
| 148 | {path} |
| 149 | </Link> |
| 150 | <span className="text-xs text-muted"> |
| 151 | {report.rules === 1 ? "1 rule" : `${report.rules} rules`} |
| 152 | {report.sections.length > 0 && |
| 153 | ` · ${report.sections.length === 1 ? "1 section" : `${report.sections.length} sections`}`} |
| 154 | </span> |
| 155 | <span className={`ml-auto text-xs ${errors > 0 ? "text-danger" : "text-muted"}`}> |
| 156 | {errors === 0 ? "No errors" : errors === 1 ? "1 error" : `${errors} errors`} |
| 157 | </span> |
| 158 | </div> |
| 159 | {errors > 0 && ( |
| 160 | <div className="border-t border-line"> |
| 161 | <CodeownersErrorList errors={report.errors} lineHref={(line) => blobHref(base, branch, path, line)} /> |
| 162 | </div> |
| 163 | )} |
| 164 | </Card> |
| 165 | ); |
| 166 | } |
| 167 | |
| 168 | /** The panel's shape while the file is read. */ |
| 169 | export function CodeownersReportSkeleton() { |
| 170 | return ( |
| 171 | <Card aria-busy="true" className="flex items-center gap-3 px-4 py-3"> |
| 172 | <Skeleton className="size-4 rounded-full" /> |
| 173 | <Skeleton className="h-3 w-36" /> |
| 174 | <Skeleton className="h-3 w-20" /> |
| 175 | <Skeleton className="ml-auto h-3 w-14" /> |
| 176 | </Card> |
| 177 | ); |
| 178 | } |
| 179 | |
| 180 | /** Above a CODEOWNERS file: what is wrong with it, or that nothing is. */ |
| 181 | export function CodeownersFileErrors({ report, path, base }: { report: CodeownersReport; path: string; base: string }) { |
| 182 | // Not read at this ref (a commit, say): nothing to say about it. |
| 183 | if (!report.path) return null; |
| 184 | // Another location comes first on this branch, so this file is not read. |
| 185 | if (report.path !== path) { |
| 186 | return ( |
| 187 | <p className="mb-4 flex items-center gap-2 text-sm text-muted"> |
| 188 | <CircleDashed size={15} className="shrink-0 text-faint" /> |
| 189 | <span> |
| 190 | Not in use: g1t reads{" "} |
| 191 | <Link to={blobHref(base, report.ref, report.path)} className="font-mono text-fg hover:underline"> |
| 192 | {report.path} |
| 193 | </Link>{" "} |
| 194 | on this branch, which comes first. |
| 195 | </span> |
| 196 | </p> |
| 197 | ); |
| 198 | } |
| 199 | const errors = report.errors.length; |
| 200 | if (errors === 0) { |
| 201 | return ( |
| 202 | <p className="mb-4 flex items-center gap-2 text-sm text-muted" role="status"> |
| 203 | <CircleCheck size={15} className="shrink-0 text-success" /> |
| 204 | No errors in this CODEOWNERS file. |
| 205 | </p> |
| 206 | ); |
| 207 | } |
| 208 | return ( |
| 209 | <section className="mb-4 overflow-hidden rounded-xl border border-danger/40" aria-label="CODEOWNERS errors"> |
| 210 | <p className="flex items-center gap-2 border-b border-danger/30 bg-danger/5 px-4 py-2.5 text-sm font-medium"> |
| 211 | <FileWarning size={15} className="shrink-0 text-danger" /> |
| 212 | {errors === 1 ? "1 error" : `${errors} errors`} in this CODEOWNERS file |
| 213 | <a href={CODEOWNERS_DOCS} className="ml-auto text-xs font-normal text-muted hover:text-fg hover:underline"> |
| 214 | Syntax |
| 215 | </a> |
| 216 | </p> |
| 217 | <CodeownersErrorList errors={report.errors} lineHref={(line) => `#L${line}`} /> |
| 218 | </section> |
| 219 | ); |
| 220 | } |
| 221 | |
| 222 | /** |
| 223 | * Where one rule's review stands, in a few words. When the ruleset does not |
| 224 | * require code owners' approval (`required` false), a rule nobody approved |
| 225 | * yet is said plainly, not as something merging waits for. |
| 226 | */ |
| 227 | function ReviewStatus({ review, required }: { review: OwnerReview; required: boolean }) { |
| 228 | const names = (list: string[]) => list.join(", "); |
| 229 | if (review.changes_requested_by.length > 0) { |
| 230 | return ( |
| 231 | <span className="flex items-center gap-1 text-xs text-danger"> |
| 232 | <CircleSlash size={13} className="shrink-0" /> Changes requested by {names(review.changes_requested_by)} |
| 233 | </span> |
| 234 | ); |
| 235 | } |
| 236 | if (review.satisfied && review.approved_by.length > 0) { |
| 237 | return ( |
| 238 | <span className="flex items-center gap-1 text-xs text-success"> |
| 239 | <CircleCheck size={13} className="shrink-0" /> Approved by {names(review.approved_by)} |
| 240 | </span> |
| 241 | ); |
| 242 | } |
| 243 | if (review.optional) { |
| 244 | return <span className="text-xs text-faint">Optional</span>; |
| 245 | } |
| 246 | if (review.satisfied) { |
| 247 | return ( |
| 248 | <span className="flex items-center gap-1 text-xs text-success"> |
| 249 | <CircleCheck size={13} className="shrink-0" /> Approved |
| 250 | </span> |
| 251 | ); |
| 252 | } |
| 253 | if (!required) { |
| 254 | return ( |
| 255 | <span className="text-xs text-faint"> |
| 256 | {review.approved_by.length > 0 ? `Approved by ${names(review.approved_by)}` : "No approval yet"} |
| 257 | </span> |
| 258 | ); |
| 259 | } |
| 260 | const more = Math.max(review.required - review.approved_by.length, 1); |
| 261 | return ( |
| 262 | <span className="flex items-center gap-1 text-xs text-warn"> |
| 263 | <Hourglass size={13} className="shrink-0" /> |
| 264 | Waiting for {more} more {more === 1 ? "approval" : "approvals"} |
| 265 | {review.approved_by.length > 0 && <span className="text-faint">· approved by {names(review.approved_by)}</span>} |
| 266 | </span> |
| 267 | ); |
| 268 | } |
| 269 | |
| 270 | /** One rule: its section, pattern and line, its owners, the files it covers, and where its review stands. */ |
| 271 | function OwnerReviewRow({ |
| 272 | review, |
| 273 | required, |
| 274 | fileHref, |
| 275 | }: { |
| 276 | review: OwnerReview; |
| 277 | /** Whether the ruleset requires code owners' approval to merge. */ |
| 278 | required: boolean; |
| 279 | fileHref: (line: number) => string; |
| 280 | }) { |
| 281 | const many = review.files.length > 3; |
| 282 | const files = ( |
| 283 | <ul className="mt-1 space-y-0.5"> |
| 284 | {review.files.map((file) => ( |
| 285 | <li key={file} className="truncate font-mono text-xs text-muted"> |
| 286 | {file} |
| 287 | </li> |
| 288 | ))} |
| 289 | </ul> |
| 290 | ); |
| 291 | return ( |
| 292 | <li className="px-4 py-3 text-sm"> |
| 293 | <div className="flex flex-wrap items-center gap-x-2 gap-y-1"> |
| 294 | {review.section && <Badge>{review.section}</Badge>} |
| 295 | <code className="font-mono text-xs text-fg">{review.pattern}</code> |
| 296 | <Link to={fileHref(review.line)} className="font-mono text-xs text-faint hover:text-accent hover:underline"> |
| 297 | line {review.line} |
| 298 | </Link> |
| 299 | <span className="ml-auto"> |
| 300 | <ReviewStatus review={review} required={required} /> |
| 301 | </span> |
| 302 | </div> |
| 303 | <p className="mt-1 flex flex-wrap items-center gap-x-2 gap-y-0.5 text-xs text-muted"> |
| 304 | <span>Owners</span> |
| 305 | {review.owners.length === 0 ? ( |
| 306 | <span className="text-faint">none</span> |
| 307 | ) : ( |
| 308 | review.owners.map((owner) => <OwnerLink key={owner} owner={owner} />) |
| 309 | )} |
| 310 | </p> |
| 311 | {many ? ( |
| 312 | <details className="mt-1"> |
| 313 | <summary className="cursor-pointer text-xs text-faint hover:text-fg">{review.files.length} files</summary> |
| 314 | {files} |
| 315 | </details> |
| 316 | ) : ( |
| 317 | files |
| 318 | )} |
| 319 | </li> |
| 320 | ); |
| 321 | } |
| 322 | |
| 323 | /** |
| 324 | * Who owns what a pull request changes: each rule that matched, its |
| 325 | * owners and files, and whose approval it still needs. |
| 326 | */ |
| 327 | export function PullCodeOwnersPanel({ |
| 328 | owners, |
| 329 | base, |
| 330 | branch, |
| 331 | errorsHref, |
| 332 | }: { |
| 333 | owners: PullCodeOwners; |
| 334 | base: string; |
| 335 | /** The branch it merges into, where the file is read. */ |
| 336 | branch: string; |
| 337 | /** Where the file's errors are listed. */ |
| 338 | errorsHref: string; |
| 339 | }) { |
| 340 | const fileHref = (line: number) => blobHref(base, branch, owners.path, line); |
| 341 | return ( |
| 342 | <Card asChild tone="plain" className="overflow-hidden"> |
| 343 | <section aria-label="Code owners"> |
| 344 | <div className="flex flex-wrap items-center gap-x-3 gap-y-1 border-b border-line bg-surface px-4 py-2.5 text-sm"> |
| 345 | <span className="flex items-center gap-2 font-medium"> |
| 346 | <ShieldCheck size={15} className="shrink-0 text-faint" /> |
| 347 | Code owners |
| 348 | </span> |
| 349 | <Link to={blobHref(base, branch, owners.path)} className="font-mono text-xs text-muted hover:text-fg hover:underline"> |
| 350 | {owners.path} |
| 351 | </Link> |
| 352 | <span className="ml-auto flex items-center gap-2"> |
| 353 | {owners.errors > 0 && ( |
| 354 | <Link to={errorsHref} className="text-xs text-danger hover:underline"> |
| 355 | {owners.errors === 1 ? "1 error" : `${owners.errors} errors`} in the file |
| 356 | </Link> |
| 357 | )} |
| 358 | {owners.required ? <Badge tone="warn">Approval required</Badge> : <Badge>Approval not required</Badge>} |
| 359 | </span> |
| 360 | </div> |
| 361 | {owners.reviews.length === 0 ? ( |
| 362 | <p className="px-4 py-3 text-sm text-muted">No rule in the file covers what this changes.</p> |
| 363 | ) : ( |
| 364 | <ul className="divide-y divide-line"> |
| 365 | {owners.reviews.map((review) => ( |
| 366 | <OwnerReviewRow key={`${review.section ?? ""}:${review.line}`} review={review} required={owners.required} fileHref={fileHref} /> |
| 367 | ))} |
| 368 | </ul> |
| 369 | )} |
| 370 | </section> |
| 371 | </Card> |
| 372 | ); |
| 373 | } |