Skip to content

Where people and agents ship software together. The open-source git platform for the whole job: issues, agents, checks and deploys to the edge.

Prettier over the repository #166

Mergedsyntaqx merged format-repo into main
LandedRun Prettier over the repository#165

Merged into main by syntaqx via a merge commit in 5a992f0

syntaqxopened this pull request

Runs Prettier (.prettierrc.json) over the repository with npm run format -- ., and nothing else.

Closes #165

Left out, now in .prettierignore

  • Test fixtures: **/fixtures/, *.fixtures.json and *_fixtures.json. They stay byte for byte as captured: real repositories' dependabot.yml, SARIF output, and SSO/JWT vectors.
  • apps/docs/src/content/docs/guides/self-hosted-runners.mdx: Prettier's MDX printer rewrites it again on every run, so formatting it would only churn.

Checks

  • npx prettier --check .: clean.
  • No hand edits.
syntaqxcommented

I pushed two follow-up commits after CI failed:

  • Trailing commas: .prettierrc.json keeps trailingComma: none for *.jsonc. Prettier 3's trailing commas in wrangler.jsonc broke the readers that strip comments and JSON.parse the file (services/runner/src/machines.test.ts, scripts/deploy).
  • Generated files are back to what generates them and in .prettierignore: reference/cli.md (cli_reference_is_current), data/openapi.json and **/worker-configuration.d.ts.
  • Architecture tables: architecture/services.md and guides/self-hosting-architecture.md are back too, and ignored. scripts/deploy/deploy.test.mjs finds each row by its exact text, and Prettier pads table cells. That test runs only in Deploy's Check job, so PR CI wouldn't have caught it before the deploy.
syntaqxcommented

One more: packages/contracts/src/datasets.ts and scopes.ts are back to how they were and in .prettierignore, because crates/contracts (datasets.rs, scopes.rs) reads them line by line. cargo test -p g1t-contracts -p g1t-actions -p g1t-api passes on this branch.

syntaqxmerged this·

All checks have passed

2 passed · on 6f9c81f

Workflows

CI / pull_request — CI passedDetails
Dependency review — No dependency changesDetails

Merged and closed: the branch can be deleted safely

Everything on it is in its base now.

Sign in to comment.