Greet with Hi instead of Hello
3 files+13−130/3 viewed
| 13 | 13 | ||
| 14 | 14 | ```sh | |
| 15 | 15 | $ cargo run -- Ada | |
| 16 | − | Hello, Ada! | |
| 16 | + | Hi, Ada! | |
| 17 | 17 | ``` | |
| 18 | 18 | ||
| 19 | 19 | ```sh | |
| 20 | 20 | $ cargo run -- --shout Ada | |
| 21 | − | HELLO, ADA! | |
| 21 | + | HI, ADA! | |
| 22 | 22 | ``` | |
| 23 | 23 | ||
| 24 | 24 | ```sh | |
| 25 | 25 | $ cargo run -- --times 2 Ada | |
| 26 | − | Hello, Ada! | |
| 27 | − | Hello, Ada! | |
| 26 | + | Hi, Ada! | |
| 27 | + | Hi, Ada! | |
| 28 | 28 | ``` | |
| 29 | 29 | ||
| 30 | 30 | ```sh | |
| 48 | 48 | ||
| 49 | 49 | `--times` needs a whole number of zero or more. If the value is anything else, such as `abc`, `-1` or `2.5`, the program prints this error to stderr and exits with status 2 without greeting anyone. Pass a plain number, for example `--times 3`. A `--times` with no value after it also fails, with `--times requires a value`. | |
| 50 | 50 | ||
| 51 | − | **The greeting says `Hello, world!` when I gave a name** | |
| 51 | + | **The greeting says `Hi, world!` when I gave a name** | |
| 52 | 52 | ||
| 53 | 53 | An empty or whitespace-only name, such as `cargo run -- ""`, is treated as no name and the greeting uses `world`. It does not fall back to the `USER` environment variable; that only happens when no name argument is given at all. Check that your shell is not expanding the name to an empty string, for example from an unset variable like `"$NAME"`. | |
| 54 | 54 |
| 64 | 64 | pub fn greeting(name: &str) -> String { | |
| 65 | 65 | let trimmed = name.trim(); | |
| 66 | 66 | let display_name = if trimmed.is_empty() { "world" } else { trimmed }; | |
| 67 | − | format!("Hello, {display_name}!") | |
| 67 | + | format!("Hi, {display_name}!") | |
| 68 | 68 | } | |
| 69 | 69 | ||
| 70 | 70 | /// The farewell for `name`. | |
| 162 | 162 | ||
| 163 | 163 | #[test] | |
| 164 | 164 | fn shout_upper_cases_greeting() { | |
| 165 | − | assert_eq!(shout(&greeting("Ada")), "HELLO, ADA!"); | |
| 165 | + | assert_eq!(shout(&greeting("Ada")), "HI, ADA!"); | |
| 166 | 166 | } | |
| 167 | 167 | ||
| 168 | 168 | #[test] | |
| 169 | 169 | fn greets_by_name() { | |
| 170 | − | assert_eq!(greeting("Ada"), "Hello, Ada!"); | |
| 170 | + | assert_eq!(greeting("Ada"), "Hi, Ada!"); | |
| 171 | 171 | } | |
| 172 | 172 | ||
| 173 | 173 | #[test] | |
| 174 | 174 | fn greets_world_with_empty_string() { | |
| 175 | − | assert_eq!(greeting(""), "Hello, world!"); | |
| 175 | + | assert_eq!(greeting(""), "Hi, world!"); | |
| 176 | 176 | } | |
| 177 | 177 | ||
| 178 | 178 | #[test] | |
| 179 | 179 | fn greets_world_with_whitespace_only() { | |
| 180 | − | assert_eq!(greeting(" "), "Hello, world!"); | |
| 180 | + | assert_eq!(greeting(" "), "Hi, world!"); | |
| 181 | 181 | } | |
| 182 | 182 | ||
| 183 | 183 | #[test] | |
| 184 | 184 | fn trims_whitespace_from_name() { | |
| 185 | − | assert_eq!(greeting(" Ada "), "Hello, Ada!"); | |
| 185 | + | assert_eq!(greeting(" Ada "), "Hi, Ada!"); | |
| 186 | 186 | } | |
| 187 | 187 | ||
| 188 | 188 | #[test] |
| 26 | 26 | assert!(output.status.success()); | |
| 27 | 27 | assert_eq!( | |
| 28 | 28 | String::from_utf8(output.stdout).unwrap(), | |
| 29 | − | "Hello, Ada!\n".repeat(3) | |
| 29 | + | "Hi, Ada!\n".repeat(3) | |
| 30 | 30 | ); | |
| 31 | 31 | } | |
| 32 | 32 | ||
| 36 | 36 | assert!(output.status.success()); | |
| 37 | 37 | assert_eq!( | |
| 38 | 38 | String::from_utf8(output.stdout).unwrap(), | |
| 39 | − | "HELLO, ADA!\n".repeat(2) | |
| 39 | + | "HI, ADA!\n".repeat(2) | |
| 40 | 40 | ); | |
| 41 | 41 | } | |
| 42 | 42 |