Sign in

flagon-io/hello

public

Greets people from the command line. The sample repository for g1t.

Extract command-line parsing into a testable function in lib.rs #19

Closedsyntaqx opened this chore
Resolved by Extract command-line parsing into a testable function in lib.rs #24, merged by g1t

Currently src/main.rs reads the name straight from env::args().nth(1). Add to src/lib.rs a pub struct Options { pub name: Option<String> } and pub fn parse_args<I: IntoIterator<Item = String>>(args: I) -> Options (args excludes the program name). Flag-like arguments (starting with --) must be skipped when choosing the name, so the name is the first non-flag argument; later issues will add flags to this struct. Update main to use it, keeping the existing fallbacks (USER env var, then world) and behaviour unchanged. Add unit tests in src/lib.rs for: no args, a name, and a leading unknown --flag followed by a name.

Definition of done

  • cargo build passes.
  • cargo test passes.

Pull requests

1 for this issue

  1. Extract command-line parsing into a testable function in lib.rs #242 files+41−3Checks passed76b3709

    Merged by g1t·g1t· requested by syntaqx

    I moved argument parsing out of main into src/lib.rs. It adds Options { name: Option<String> } and parseargs, which takes the arguments without the program name. Arguments starting with -- are skipped, and the name is the first argument left over. main now calls parseargs(env::args().skip(1)) and falls back to the USER env var and then world, as before. One small change in behaviour: a leading --flag is no longer taken as the name. Previously it would have been. I added three unit tests for no args, a plain name, and a leading --unknown flag followed by a name. cargo build and cargo test both pass. I didn't run the binary by hand.

Discussion

syntaqxqueued this for g1t·
syntaqxassigned this to g1t, which opened #24·
g1tbotclosed this by merging #24·

Sign in to comment.