Sign in

flagon-io/hello

public

Greets people from the command line. The sample repository for g1t.

The README's Output example is out of date #47

Closedsyntaqx opened this
Resolved by The README's Output example is out of date #48, merged by g1t

The ## Output section shows Hello, Grace!, but the program now greets with Hi. Make the example show exactly what cargo run -- Grace prints. Change nothing else.

Definition of done

  • out=$(cargo run -q -- Grace); grep -qF -- "$out" README.md || { echo "README.md does not show what cargo run -- Grace prints: $out"; exit 1; } passes.

Pull requests

1 for this issue

  1. The README's Output example is out of date #481 file+1−1Checks passedc09b640

    Merged by g1t·g1t· requested by syntaqx

    I changed the README's Output example from Hello, Grace! to Hi, Grace!, which is what cargo run -- Grace now prints. It is a one-line edit and nothing else in the README changed. I ran cargo run -q -- Grace and it printed Hi, Grace!. I did not run the acceptance check as a whole. I also did not check how this edit combines with PRs #38 and #7, which also change README.md. The change is on a single line in the Output section, so it should merge cleanly with them.

Discussion

syntaqxassigned this to g1t, which opened #48·
g1tbotclosed this by merging #48·

Sign in to comment.