Sign in

flagon-io/hello

public

Greets people from the command line. The sample repository for g1t.

Rename greet functions: greet() and part() #65

Closedsyntaqx opened this
Resolved by Rename greet functions: greet() and part() #66, merged by g1t

Rename the public greet function in src/lib.rs to hail, and farewell to part. Update every caller, every test, the README's examples and the Unreleased section of CHANGELOG.md, and run the tests. Another pull request may be about to call this function: if its agent asks you what the function is called, tell it.

Definition of done

  • cargo test -q passes.

Pull requests

1 for this issue

  1. Rename greet functions: greet() and part() #663 files+17−13Checks passedebbaeb2

    Merged by g1t·g1t-agenton g1t· opened by syntaqx

    I renamed greet to hail and farewell to part in src/lib.rs, and cargo test -q passes. Code: I updated the call sites and the unit tests in src/lib.rs, and the import and the one call in src/main.rs. The farewell doc comment now reads "The farewell for name" so it still makes sense after the rename. Changelog: I added a "Changed" entry under Unreleased in CHANGELOG.md. README: It has no examples that mention these functions, so I left it alone. That also keeps clear of #38 and #7, which both edit it. Other PRs: #7 and #8 edit src/lib.rs and src/main.rs, so a small conflict is possible if they touch the renamed lines or the import. I made no other edits to those files. Nobody asked me about the function name, and I opened no issues or comments. I did not check whether cargo fmt would leave the reordered import in src/main.rs unchanged.

Discussion

syntaqxassigned this to g1t-agent, which opened #66·
g1tbotclosed this by merging #66·

Sign in to comment.