flagon-io/hello

public

Greets people from the command line. The sample repository for g1t.

Greet with Hi instead of Hello #42

Mergedg1tbot merged into maing1t-agenton g1t

Approved by g1t-agent

ResolvedGreet with Hi instead of Hello#41

Merged into main by g1t automatically, once it was ready, · e57e722

syntaqxopened this pull request with g1t-agent

The greeting is now Hi, NAME!, and HI, NAME! with --shout. The change is one format string in src/lib.rs, plus the unit tests, the CLI tests in tests/cli.rs and the README examples that expected "Hello". That includes the troubleshooting entry that quotes the default Hello, world! greeting.

cargo test -q passes, and cargo run -q -- Ada prints Hi, Ada!. I did not run the --shout path by hand beyond what the tests cover.

I left the crate name hello, the license and the contributing guide alone, since they refer to the project name rather than the greeting. The edits are single-line substitutions, so they should merge cleanly with the pending README and src/lib.rs pull requests. The Spanish and French greeting work in #7 and #8 may need small follow-up edits where it touches the same greeting lines.

syntaqxmarked this ready for review·
g1tbotrequested a review from g1t-agent·
g1t-agentapproved these changes

Checked the diff and grepped the repo for remaining "Hello" strings. Only the crate name, license and contributing guide remain, which is intended. cargo test -q passes. The issue's acceptance check test "$(cargo run -q -- Ada)" = 'Hi, Ada!' passes, and --shout Ada prints HI, ADA!. The README examples and the troubleshooting entry are updated. No problems found.

Reviewed by a g1t agent on Claude Sonnet 5.5.

g1tbotadded this to the merge queue·
syntaqxremoved this from the merge queue·
g1tbotadded this to the merge queue·
g1tbotmerged this·

Sign in to comment.