flagon-io/hello

public

Greets people from the command line. The sample repository for g1t.

Add a --quiet flag #58

Mergedg1tbot merged into mainrequested by syntaqx

Approved by g1t

3 files+21−00/3 viewed

+11−0Viewed

34	34		pub times: usize,
35	35		/// The greeting language (`--lang CODE`).
36	36		pub lang: Lang,
	37	+	/// Whether to print nothing (`--quiet`).
	38	+	pub quiet: bool,
37	39		}
38	40
39	41		impl Default for Options {
⋯
44	46		version: false,
45	47		times: 1,
46	48		lang: Lang::En,
	49	+	quiet: false,
47	50		}
48	51		}
49	52		}
⋯
67	70		options.shout = true;
68	71		} else if arg == "--version" {
69	72		options.version = true;
	73	+	} else if arg == "--quiet" {
	74	+	options.quiet = true;
70	75		} else if arg == "--times" {
71	76		let value = args
72	77		.next()
⋯
125	130		}
126	131
127	132		#[test]
	133	+	fn parse_args_quiet() {
	134	+	assert!(parse_args(args(&["--quiet", "Ada"])).unwrap().quiet);
	135	+	assert!(!parse_args(args(&["Ada"])).unwrap().quiet);
	136	+	}
	137	+
	138	+	#[test]
128	139		fn parse_args_no_args() {
129	140		assert_eq!(parse_args(args(&[])).unwrap().name, None);
130	141		}

1+3−0Viewed

14	14		println!("{}", env!("CARGO_PKG_VERSION"));
15	15		return;
16	16		}
	17	+	if options.quiet {
g1t4d ago This check runs after the `--version` early return, so `--quiet --version` still prints the version. That contradicts the PR description, which says quiet takes precedence. Decide which behavior you want and make the code, description, and a test agree.
	18	+	return;
	19	+	}
17	20		// The name given, or whoever is signed in.
18	21		let name = options
19	22		.name

+7−0Viewed

85	85		let stderr = String::from_utf8(output.stderr).unwrap();
86	86		assert!(stderr.contains("--lang requires a value"), "stderr was {stderr:?}");
87	87		}
	88	+
	89	+	#[test]
	90	+	fn quiet_prints_nothing() {
	91	+	let output = run(&["--quiet", "Ada"]);
	92	+	assert!(output.status.success());
	93	+	assert!(output.stdout.is_empty());
	94	+	}