flagon-io/hello

public

Greets people from the command line. The sample repository for g1t.

A blank name greets nobody #6

Closedg1tbot wants to merge into mainrequested by syntaqx

Note
Running on Claude Haiku 4.5 (Fast).
Prompt
You are a coding agent working in the git repository checked out in the current directory.

Issue #1: A blank name greets nobody

hello "" prints Hello, !, and hello " " prints Hello, !.

A name that is empty or only whitespace should be treated as no name at all and greet world. Surrounding whitespace on a real name should be trimmed.

Add tests for both.

These commands must pass when you are done. Run them if the tools are installed:
- cargo test
Make the change and keep it focused on the issue. Commit your work with a clear message. Do not push; that is done for you. Finish with a short summary of what you changed and why. It becomes the description of your pull request, so write it for a reviewer and leave out whether anything was committed or pushed.
g1t
I'll start by exploring the repository structure to understand the codebase and then fix the issue.
Bashfind /work/repo -type f -name "*.rs" | head -20
```
find /work/repo -type f -name "*.rs" | head -20
```

result→ /work/repo/src/main.rs

/work/repo/src/main.rs
/work/repo/src/lib.rs

Read/work/repo/src/lib.rs
```
/work/repo/src/lib.rs
```

result→ 1 //! Greetings.

1	//! Greetings.
2	
3	/// The greeting for `name`.
4	pub fn greeting(name: &str) -> String {
5	    format!("Hello, {name}!")
6	}
7	
8	#[cfg(test)]
9	mod tests {
10	    use super::*;
11	
12	    #[test]
13	    fn greets_by_name() {
14	        assert_eq!(greeting("Ada"), "Hello, Ada!");
15	    }
16	}
17

Read/work/repo/src/main.rs
```
/work/repo/src/main.rs
```

result→ 1 use std::env;

1	use std::env;
2	
3	use hello::greeting;
4	
5	fn main() {
6	    // The name given, or whoever is signed in.
7	    let name = env::args()
8	        .nth(1)
9	        .or_else(|| env::var("USER").ok())
10	        .unwrap_or_else(|| "world".to_owned());
11	    println!("{}", greeting(&name));
12	}
13

g1t
Now I can see the issue. The greeting function doesn't handle empty or whitespace-only names. Let me fix it by updating the greeting function to trim the name and default to "world" if it's empty.
Edit/work/repo/src/lib.rs
```
/work/repo/src/lib.rs
```
result→ The file /work/repo/src/lib.rs has been updated successfully. (file state is current in your context — no need to Read it back)
```
The file /work/repo/src/lib.rs has been updated successfully. (file state is current in your context — no need to Read it back)
```
g1t
Now let me verify the fix by running the tests:
Bashcargo test
```
cargo test
```

result→ Compiling hello v0.1.0 (/work/repo)

Compiling hello v0.1.0 (/work/repo)
    Finished `test` profile [unoptimized + debuginfo] target(s) in 5.59s
     Running unittests src/lib.rs (target/debug/deps/hello-4f41328864442bc2)

running 4 tests
test tests::greets_by_name ... ok
test tests::greets_world_for_empty_name ... ok
test tests::greets_world_for_whitespace_only ... ok
test tests::trims_surrounding_whitespace ... ok

test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/main.rs (target/debug/deps/hello-2398416ff99fc267)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests hello

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

g1t
Perfect! All tests pass. Let me also verify the command line behavior works correctly:
Bashcargo build --quiet && ./target/debug/hello "" && ./target/debug/hello " " && ./target/debug/hello "Alice"
```
cargo build --quiet && ./target/debug/hello "" && ./target/debug/hello "  " && ./target/debug/hello "Alice"
```

result→ Hello, world!

Hello, world!
Hello, world!
Hello, Alice!

g1t
Excellent! The fix works correctly. Now let me commit the changes:

Bashgit add -A && git commit -m "$(cat <<'EOF'

git add -A && git commit -m "$(cat <<'EOF'
Handle empty and whitespace-only names

- Trim surrounding whitespace from names
- Treat empty or whitespace-only names as no name (greet 'world')
- Add tests for empty strings, whitespace-only strings, and trimming
EOF
)"

result→ [main 39afacc] Handle empty and whitespace-only names

[main 39afacc] Handle empty and whitespace-only names
 2 files changed, 29 insertions(+), 1 deletion(-)
 create mode 100644 Cargo.lock

g1t
Summary

Fixed the greeting function to properly handle empty and whitespace-only names. The function now trims surrounding whitespace from the input name and defaults to greeting "world" when the name is empty or contains only whitespace.

Changes:
- Modified greeting() in src/lib.rs to trim the input and check if it's empty
- Added three new tests: one for empty strings, one for whitespace-only strings, and one to verify trimming of surrounding whitespace
- All existing and new tests pass
The issue where hello "" printed Hello, ! and hello " " printed Hello, ! is now resolved—both now correctly print Hello, world!
Note
Pushed 39afacc9b289.

flagon-io/hello

Summary