flagon-io/hello

public

Greets people from the command line. The sample repository for g1t.

Add CI: formatting, lints and tests on every pull request #79

Mergedg1t merged into maing1t-agenton g1t

Approved by g1t-agent

ResolvedAdd CI: formatting, lints and tests on every pull request#78

Merged into main by g1t automatically, once it was ready, · 6d3fd45

syntaqxopened this pull request with g1t-agent

I added the CI workflow at .g1t/workflows/ci.yml with the exact content from the issue. It runs cargo fmt --check, cargo clippy --all-targets -- -D warnings and cargo test on pushes to main, pull requests and merge groups. The README's Develop section now says every pull request runs formatting, lints and tests.

I also ran cargo fmt so the Formatting step passes. It changed src/lib.rs, src/main.rs and tests/cli.rs, and the changes are formatting only. #7 and #8 both edit src/lib.rs and src/main.rs, and #7 edits the README, so whichever merges second may hit small conflicts in the lines cargo fmt touched. I did not message either pull request about this. If #7 or #8 adds code that isn't formatted, the Formatting step will fail on it until they run cargo fmt.

I ran cargo clippy --all-targets -- -D warnings locally and it is clean. cargo test passes, and I did not run cargo fmt --check as a separate step after formatting. I have not seen the workflow run on g1t, so I haven't confirmed the action versions in the file (actions/checkout@v7, actions/cache@v6) resolve there.

syntaqxmarked this ready for review·
g1trequested a review from g1t-agent·
g1t-agentapproved these changes

Workflow file matches the issue's content exactly and is at .g1t/workflows/ci.yml; the README line is added; the cargo fmt changes in src/lib.rs, src/main.rs and tests/cli.rs are whitespace/line-wrapping only and look like standard rustfmt output. cargo test passes here. I could not run cargo fmt --check or clippy (rustfmt and clippy are not installed in this environment), so I could not independently confirm the Formatting and Lints steps pass. The author also did not run fmt --check after formatting, so it is worth confirming on the first CI run. The action versions (checkout@v7, cache@v6) are as specified in the issue and unverified on g1t. Merge-conflict risk with #7/#8 is noted by the author and is acceptable.

Reviewed by a g1t agent on Claude Sonnet 5.5.

g1tadded this to the merge queue·
g1tmerged this·

Sign in to comment.