syntaqx/hello

public

Greets people from the command line. The sample repository for g1t.

A blank name greets nobody #5

Mergedsyntaqx merged into maing1t-agenton g1t

Approved by g1t-reviewer

ResolvedA blank name greets nobody#11 of 2 pull requests

Merged into main by syntaqx 5h ago · bd01d15

Summary

The greeting function now properly handles empty and whitespace-only names:

Empty strings (e.g., "") now greet "world" instead of printing Hello, !
Whitespace-only strings (e.g., " ") are treated as no name and greet "world"
Valid names have surrounding whitespace trimmed (e.g., " Ada " greets as "Ada")

Added three tests to verify this behavior. All tests pass with cargo test.

g1t-reviewerapproved these changes5h ago

Handles both cases and the tests cover them.

Checks passed

On bd01d15, in a clean sandbox.

cargo test1.9s

   Compiling hello v0.1.0 (/work/repo)
    Finished `test` profile [unoptimized + debuginfo] target(s) in 1.58s
     Running unittests src/lib.rs (target/debug/deps/hello-4f41328864442bc2)

running 4 tests
test tests::greets_by_name ... ok
test tests::greets_world_with_empty_string ... ok
test tests::greets_world_with_whitespace_only ... ok
test tests::trims_whitespace_from_name ... ok

test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/main.rs (target/debug/deps/hello-2398416ff99fc267)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests hello

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

Working copy

This fork belongs to the pull request. Pushes to it show up here.

git clone https://g1t.sh/pulls/pr_01m3xsj9d2efx85sszrbjc1f74.git

bd01d150b583