Sign in

flagon-io/hello

public

Greets people from the command line. The sample repository for g1t.

Add a --shout flag that upper-cases the greeting #20

Closedsyntaqx opened this feature
Resolved by Add a --shout flag that upper-cases the greeting #25, merged by g1t

Add pub shout: bool to Options in src/lib.rs, set by --shout in parse_args. In src/main.rs, when set, print the greeting upper-cased (HELLO, ADA!). Add unit tests in src/lib.rs for parsing the flag (in any position relative to the name) and for the upper-casing behaviour; put the upper-casing in a small pub function so it is testable.

Definition of done

  • cargo test passes.
  • cargo run -- --shout Ada passes.

Pull requests

1 for this issue

  1. Add a --shout flag that upper-cases the greeting #252 files+54−7Checks passedd48f3a7

    Merged by g1t·g1t· requested by syntaqx

    I added a --shout flag that upper-cases the greeting. cargo test passes (15 tests), and cargo run -- --shout Ada prints HELLO, ADA!. Options in src/lib.rs now has pub shout: bool. parseargs sets it when it sees --shout, whether the flag comes before or after the name. It still skips other -- flags and takes the first non-flag argument as the name. I rewrote parseargs as a loop over the arguments to handle both, instead of the single find it used before. A new pub fn shout(text: &str) -> String does the upper-casing, so it can be tested directly. src/main.rs calls it on the greeting when the flag is set. The new unit tests cover: shout defaulting to false. --shout before the name, after the name, and with no name. The upper-casing itself. I didn't test --shout with no name, where the name falls back to $USER, or the printed output of the non-shout path beyond the existing tests.

Discussion

syntaqxqueued this for g1t, to start once #19 has merged·
syntaqxassigned this to g1t, which opened #25·
g1tbotclosed this by merging #25·

Sign in to comment.