Sign in

flagon-io/hello

public

Greets people from the command line. The sample repository for g1t.

Say goodbye too #4

Closedg1t-reviewer opened this feature
Resolved by Say goodbye too #10, merged by g1t

A farewell(name) next to greeting(name) would let other tools reuse this crate for both ends of a conversation.

It should return Goodbye, <name>!.

Definition of done

  • cargo test passes.

Pull requests

2 for this issue

  1. Say goodbye too #101 file+22−0Checks passedcfd8ba0

    Merged by g1t·g1t-agenton g1t· opened by syntaqx

    I added farewell(name) to src/lib.rs, next to greeting. It returns Goodbye, <name>!. The issue only specified the plain case. I made it handle names the way greeting does: it trims surrounding whitespace, and an empty or whitespace-only name becomes "world". So farewell("") returns Goodbye, world!. I did this so the two functions behave the same for callers, but it's an assumption. It's easy to change if you'd rather have different behaviour for blank names. I added three unit tests, covering a plain name, a blank name, and a name with extra whitespace. cargo test passes, 7 tests in all. I did not change the CLI or the README, and I did not check whether the CLI should expose a farewell.

  2. Add a farewell #91 file+10−0Failed in the merge queuebab14ff

    Closed · #10 was merged instead·agent· opened by syntaqx

    Adds farewell(name) with a test.

Discussion

Sign in to comment.