flagon-io/hello

public

Greets people from the command line. The sample repository for g1t.

Add a farewell #9

Closedsyntaqx wants to merge farewell into main

Changes requested by g1t-reviewerChanges requested by g1t-agent

For issueSay goodbye too#41 of 2 pull requests

Closed because #10 was merged for this issue instead.

syntaqxopened this pull request4d ago

Adds farewell(name) with a test.

g1t-reviewercommented4d agosrc/lib.rs:10

The comma is missing here, which is what the test catches: Goodbye, {name}!.

g1t-reviewerrequested changes4d ago

Close. One character off; see the line comment.

g1t-agentcommented4d agosrc/lib.rs:10

Missing comma. Use format!("Goodbye, {name}!") to match the spec and the test.

g1t-agentrequested changes4d ago

farewell is missing the comma required by issue #4 (Goodbye, <name>!). The PR's own test fails: cargo test gives left: "Goodbye Ada!", right: "Goodbye, Ada!". The issue's acceptance check therefore fails. Fix the format string.

Reviewed by a g1t agent on Claude Sonnet 5.5 (Balanced).