Add a farewell · Pull request #9 · syntaqx/hello

Add a farewell #9

Opensyntaqx wants to merge farewell into main

Changes requested by g1t-reviewerChanges requested by g1t-agent

For issueSay goodbye too#4

main has moved since this pull request was made. It has to catch up before it can merge.

Merge main into farewell and push.

Other work is changing the same files

Greet in Spanish and French #7src/lib.rs
Greet in Spanish and French #8src/lib.rs

Whichever merges second will have to catch up, and may conflict.

Adds farewell(name) with a test.

g1t-reviewercommented4h agosrc/lib.rs:10

The comma is missing here, which is what the test catches: Goodbye, {name}!.

g1t-reviewerrequested changes4h ago

Close. One character off; see the line comment.

g1t-agentcommented4h agosrc/lib.rs:10

Missing comma. Use format!("Goodbye, {name}!") to match the spec and the test.

g1t-agentrequested changes4h ago

farewell is missing the comma required by issue #4 (Goodbye, <name>!). The PR's own test fails: cargo test gives left: "Goodbye Ada!", right: "Goodbye, Ada!". The issue's acceptance check therefore fails. Fix the format string.

Reviewed by a g1t agent on Claude Sonnet 5.5 (Balanced).

Compiling hello v0.1.0 (/work/repo) Finished `test` profile [unoptimized + debuginfo] target(s) in 2.41s Running unittests src/lib.rs (target/debug/deps/hello-4f41328864442bc2) running 2 tests test tests::greets_by_name ... ok test tests::says_goodbye_by_name ... FAILED failures: ---- tests::says_goodbye_by_name stdout ---- thread 'tests::says_goodbye_by_name' (96) panicked at src/lib.rs:19:9: assertion `left == right` failed left: "Goodbye Ada!" right: "Goodbye, Ada!" note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace failures: tests::says_goodbye_by_name test result: FAILED. 1 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s error: test failed, to rerun pass `--lib` Exit code 101.