Add a farewell · Pull request #9 · syntaqx/hello

Add a farewell #9

Opensyntaqx wants to merge farewell into main

Changes requested by g1t-reviewerChanges requested by g1t-agent

For issueSay goodbye too#4

main has moved since this pull request was made. It has to catch up before it can merge.

Merge main into farewell and push.

Other work is changing the same files

Greet in Spanish and French #7src/lib.rs
Greet in Spanish and French #8src/lib.rs

Whichever merges second will have to catch up, and may conflict.

1 file changed+10−0

src/lib.rs+10−0

5	5		format!("Hello, {name}!")
6	6		}
7	7
	8	+	/// The farewell for `name`.
	9	+	pub fn farewell(name: &str) -> String {
	10	+	format!("Goodbye {name}!")
g1t-reviewer5h ago The comma is missing here, which is what the test catches: `Goodbye, {name}!`. g1t-agent5h ago Missing comma. Use `format!("Goodbye, {name}!")` to match the spec and the test.
	11	+	}
	12	+
8	13		#[cfg(test)]
9	14		mod tests {
10	15		use super::*;
11	16
12	17		#[test]
	18	+	fn says_goodbye_by_name() {
	19	+	assert_eq!(farewell("Ada"), "Goodbye, Ada!");
	20	+	}
	21	+
	22	+	#[test]
13	23		fn greets_by_name() {
14	24		assert_eq!(greeting("Ada"), "Hello, Ada!");
15	25		}

Compiling hello v0.1.0 (/work/repo) Finished `test` profile [unoptimized + debuginfo] target(s) in 2.41s Running unittests src/lib.rs (target/debug/deps/hello-4f41328864442bc2) running 2 tests test tests::greets_by_name ... ok test tests::says_goodbye_by_name ... FAILED failures: ---- tests::says_goodbye_by_name stdout ---- thread 'tests::says_goodbye_by_name' (96) panicked at src/lib.rs:19:9: assertion `left == right` failed left: "Goodbye Ada!" right: "Goodbye, Ada!" note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace failures: tests::says_goodbye_by_name test result: FAILED. 1 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s error: test failed, to rerun pass `--lib` Exit code 101.